From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by mx.groups.io with SMTP id smtpd.web11.9905.1619605326125516929
 for <devel@edk2.groups.io>;
 Wed, 28 Apr 2021 03:22:06 -0700
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: pierre.gondois@arm.com)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
	by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id BC4291FB;
	Wed, 28 Apr 2021 03:22:05 -0700 (PDT)
Received: from [10.57.1.97] (unknown [10.57.1.97])
	by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 15BF33F70D;
	Wed, 28 Apr 2021 03:22:04 -0700 (PDT)
Subject: Re: [edk2-devel] [PATCH v2 05/15] ArmPkg: Document libraries in ArmPkg.dec
To: sami.mujawar@arm.com, devel@edk2.groups.io
References: <20210427153251.11576-6-Pierre.Gondois@arm.com>
 <12737.1619545315284790387@groups.io>
From: "PierreGondois" <pierre.gondois@arm.com>
Message-ID: <5e2074cb-05ac-9f7c-3529-220054a9360e@arm.com>
Date: Wed, 28 Apr 2021 11:22:01 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.10.0
MIME-Version: 1.0
In-Reply-To: <12737.1619545315284790387@groups.io>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US

Hi Sami,

Thanks for the review, I sent a v3 with this change.
Sorry for the spam,

Regards,
Pierre

On 4/27/21 6:41 PM, Sami Mujawar via Groups.Io wrote:
> Hi Pierre,
>
> On Tue, Apr 27, 2021 at 08:33 AM, PierreGondois wrote:
>
>     +
>     + ## @libraryclass Provides an interface to initialize a
>     + # Generic Interrupt Controller (GIC).
>     + #
>     SemihostLib|Include/Library/SemihostLib.h
>     +
>     + ## @libraryclass Provides a Generic Interrupt Controller (GIC)
>     + # configuration interface.
>     + #
>     DefaultExceptionHandlerLib|Include/Library/DefaultExceptionHandlerLib.h
>
> The help text seems to mismatch for the libraries above. However, this 
> seems to be correct in the patch that Re-orders the libraries 
> alphabetically.
> Can you update this patch, please?
>
> With that changed.
>
> Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
>
> Regards,
>
> Sami Mujawar