From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web08.14927.1663270902402546366 for ; Thu, 15 Sep 2022 12:41:42 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@linux.microsoft.com header.s=default header.b=pJ8bK2Ie; spf=pass (domain: linux.microsoft.com, ip: 13.77.154.182, mailfrom: mikuback@linux.microsoft.com) Received: from [192.168.4.22] (unknown [47.195.228.134]) by linux.microsoft.com (Postfix) with ESMTPSA id 542C92056DD7; Thu, 15 Sep 2022 12:41:41 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 542C92056DD7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1663270901; bh=1dkclkH2K5tOGUnH9YuVSjdLh0vVk3RT5RJT4oQ/4H8=; h=Date:Subject:From:To:Cc:Reply-To:References:In-Reply-To:From; b=pJ8bK2Ie9Tb19U2yi6v3Ylxp62Av0DqTeaXSPbgO6bFI0AtoHvncFeDDmo5xye1FW T+Sulg3SHMn2nb2+zPqIWUmez18dodyuKSj0kKyCcJ6izHcEfdV5IIPmbr6cjLChfc QtqwnY0LbgiqZ7bGg+B/UkV1gR3WypC0Rl8N9XEw= Message-ID: <5e42cc3d-c618-5ba9-ca36-6d09ec11d27f@linux.microsoft.com> Date: Thu, 15 Sep 2022 15:41:40 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [edk2-devel] [PATCH v2 3/6] IntelFsp2Pkg: Add CI YAML file From: "Michael Kubacki" To: devel@edk2.groups.io, Chasel Chiu Cc: Nate DeSimone , Star Zeng Reply-To: devel@edk2.groups.io, mikuback@linux.microsoft.com References: <20220915185508.997-1-mikuback@linux.microsoft.com> <17151D8FB6D820D9.18791@groups.io> In-Reply-To: <17151D8FB6D820D9.18791@groups.io> Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Chasel, Your CI YAML file feedback in v1 is addressed now in v2. Can you please provide your review on this patch and [PATCH v2 5/6]? Note that I updated the commit message for this patch to remove the info about the build being broken since that was recently fixed. That update is in the branch: https://github.com/makubacki/edk2/commit/c37e6dfa482ed075cd4ab6712e6d17b3cf17786a With these reviews, the series will be covered. Thanks, Michael On 9/15/2022 2:55 PM, Michael Kubacki wrote: > From: Michael Kubacki > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4048 > > Adds IntelFsp2Pkg to the list of supported build packages for edk2 > CI and defines an initial set of CI configuration options. > > The compiler plugin is disabled as the package currently does not > build due to some changes in the FSP 2.4 interface addition. > > Specifically, in commit df25a54 "Fsp24SecCore.inf" files were > added to IntelFspPkg.dsc but the actual files were not added. > > Simply removing these files from the DSC exposes a linker failure. > > Recommendation: > > 1. Enable package CI (accept this change) > 2. Add IntelFsp2Pkg.dsc to the "CompilerPlugin" "DscPath" in > IntelFsp2Pkg/IntelFsp2Pkg.ci.yaml to enable compilation > 3. Verify compilation and all currently enabled package CI checks > pass > 4. Check-in fixes in (3) with change in (2) > > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Star Zeng > Signed-off-by: Michael Kubacki > --- > .pytool/CISettings.py | 1 + > IntelFsp2Pkg/IntelFsp2Pkg.ci.yaml | 90 ++++++++++++++++++++ > 2 files changed, 91 insertions(+) > > diff --git a/.pytool/CISettings.py b/.pytool/CISettings.py > index cf9e0d77b19b..0205c26a58f8 100644 > --- a/.pytool/CISettings.py > +++ b/.pytool/CISettings.py > @@ -54,6 +54,7 @@ class Settings(CiBuildSettingsManager, UpdateSettingsManager, SetupSettingsManag > "ArmVirtPkg", > "DynamicTablesPkg", > "EmulatorPkg", > + "IntelFsp2Pkg", > "MdePkg", > "MdeModulePkg", > "NetworkPkg", > diff --git a/IntelFsp2Pkg/IntelFsp2Pkg.ci.yaml b/IntelFsp2Pkg/IntelFsp2Pkg.ci.yaml > new file mode 100644 > index 000000000000..9ce401b20164 > --- /dev/null > +++ b/IntelFsp2Pkg/IntelFsp2Pkg.ci.yaml > @@ -0,0 +1,90 @@ > +## @file > +# Core CI configuration for IntelFsp2Pkg > +# > +# Copyright (c) Microsoft Corporation > +# > +# SPDX-License-Identifier: BSD-2-Clause-Patent > +## > +{ > + ## options defined .pytool/Plugin/LicenseCheck > + "LicenseCheck": { > + "IgnoreFiles": [] > + }, > + > + "EccCheck": { > + ## Exception sample looks like below: > + ## "ExceptionList": [ > + ## "", "" > + ## ] > + "ExceptionList": [ > + ], > + ## Both file path and directory path are accepted. > + "IgnoreFiles": [] > + }, > + > + ## options defined .pytool/Plugin/CompilerPlugin > + "CompilerPlugin": { > + "DscPath": "IntelFsp2Pkg.dsc" > + }, > + > + ## options defined .pytool/Plugin/HostUnitTestCompilerPlugin > + "HostUnitTestCompilerPlugin": { > + "DscPath": "" # Don't support this test > + }, > + > + ## options defined .pytool/Plugin/CharEncodingCheck > + "CharEncodingCheck": { > + "IgnoreFiles": [] > + }, > + > + ## options defined .pytool/Plugin/DependencyCheck > + "DependencyCheck": { > + "AcceptableDependencies": [ > + "IntelFsp2Pkg/IntelFsp2Pkg.dec", > + "MdeModulePkg/MdeModulePkg.dec", > + "MdePkg/MdePkg.dec", > + "UefiCpuPkg/UefiCpuPkg.dec" > + ], > + # For host based unit tests > + "AcceptableDependencies-HOST_APPLICATION":[ > + "UnitTestFrameworkPkg/UnitTestFrameworkPkg.dec" > + ], > + # For UEFI shell based apps > + "AcceptableDependencies-UEFI_APPLICATION":[], > + "IgnoreInf": [] > + }, > + > + ## options defined .pytool/Plugin/DscCompleteCheck > + "DscCompleteCheck": { > + "IgnoreInf": [""], > + "DscPath": "IntelFsp2Pkg.dsc" > + }, > + > + ## options defined .pytool/Plugin/HostUnitTestDscCompleteCheck > + "HostUnitTestDscCompleteCheck": { > + "IgnoreInf": [""], > + "DscPath": "" # Don't support this test > + }, > + > + ## options defined .pytool/Plugin/GuidCheck > + "GuidCheck": { > + "IgnoreGuidName": [], > + "IgnoreGuidValue": [], > + "IgnoreFoldersAndFiles": [], > + "IgnoreDuplicates": [], > + }, > + > + ## options defined .pytool/Plugin/LibraryClassCheck > + "LibraryClassCheck": { > + "IgnoreHeaderFile": [] > + }, > + > + ## options defined .pytool/Plugin/SpellCheck > + "SpellCheck": { > + "AuditOnly": True, # Fails right now with over 270 errors > + "IgnoreFiles": [], # use gitignore syntax to ignore errors in matching files > + "ExtendWords": [], # words to extend to the dictionary for this package > + "IgnoreStandardPaths": [], # Standard Plugin defined paths that should be ignore > + "AdditionalIncludePaths": [] # Additional paths to spell check (wildcards supported) > + } > +}