From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.groups.io with SMTP id smtpd.web11.1764.1616437906558258491 for ; Mon, 22 Mar 2021 11:31:46 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ORx/qH82; spf=pass (domain: redhat.com, ip: 216.205.24.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1616437905; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2/bZNYaL4jlFweHxn7xm2SJjFyKO8DPDT0M3DxYrjBk=; b=ORx/qH82DpfldwGTbHwPdEU1MkzU0TlyZ31aaRn9zOesxLL+yT4+nElXyEioytSO03qYSt Yt2HyAUjQjmPzX5TSA71aHgveam2VarG0hFQRmGS6wO5AVvMzfKudDR95F6X7kZVEomj6j TpToK1p6tZ0hrUGUy4XrfRChpYwPjeY= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-415-8dDIQRr0MCuoVjEbTYeSWw-1; Mon, 22 Mar 2021 14:31:40 -0400 X-MC-Unique: 8dDIQRr0MCuoVjEbTYeSWw-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 02718180FCA6; Mon, 22 Mar 2021 18:31:39 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-115-223.ams2.redhat.com [10.36.115.223]) by smtp.corp.redhat.com (Postfix) with ESMTP id C7D6A19C78; Mon, 22 Mar 2021 18:31:37 +0000 (UTC) Subject: Re: [patch V2 17/29] OvmfPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib To: Dandan Bi , devel@edk2.groups.io Cc: Ard Biesheuvel , Jordan Justen References: <20210322080941.6780-1-dandan.bi@intel.com> <20210322080941.6780-18-dandan.bi@intel.com> From: "Laszlo Ersek" Message-ID: <5e47d4e4-1c8a-0a4f-691a-1a19cd926fd0@redhat.com> Date: Mon, 22 Mar 2021 19:31:36 +0100 MIME-Version: 1.0 In-Reply-To: <20210322080941.6780-18-dandan.bi@intel.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 03/22/21 09:09, Dandan Bi wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 > > MdeLibs.dsc.inc was added for some basic/default library > instances provided by MdePkg and RegisterFilterLibNull Library > was also added into it as the first version of MdeLibs.dsc.inc. > > So update platform dsc to consume MdeLibs.dsc.inc for > RegisterFilterLibNull which will be consumed by IoLib and BaseLib. > > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Cc: Jordan Justen > Signed-off-by: Dandan Bi > --- > OvmfPkg/AmdSev/AmdSevX64.dsc | 4 +++- > OvmfPkg/Bhyve/BhyveX64.dsc | 4 +++- > OvmfPkg/OvmfPkgIa32.dsc | 4 +++- > OvmfPkg/OvmfPkgIa32X64.dsc | 4 +++- > OvmfPkg/OvmfPkgX64.dsc | 4 +++- > OvmfPkg/OvmfXen.dsc | 4 +++- > 6 files changed, 18 insertions(+), 6 deletions(-) Same comment (for all 6 DSC files) as under the ArmVirtPkg patch -- please un-indent the !include directives. With that: Reviewed-by: Laszlo Ersek Thanks Laszlo > > diff --git a/OvmfPkg/AmdSev/AmdSevX64.dsc b/OvmfPkg/AmdSev/AmdSevX64.dsc > index 65c42284d9..7bb94b8e11 100644 > --- a/OvmfPkg/AmdSev/AmdSevX64.dsc > +++ b/OvmfPkg/AmdSev/AmdSevX64.dsc > @@ -1,11 +1,11 @@ > ## @file > # EFI/Framework Open Virtual Machine Firmware (OVMF) platform for SEV secure > # virtual machine remote attestation and secret injection > # > # Copyright (c) 2020 James Bottomley, IBM Corporation. > -# Copyright (c) 2006 - 2020, Intel Corporation. All rights reserved.
> +# Copyright (c) 2006 - 2021, Intel Corporation. All rights reserved.
> # (C) Copyright 2016 Hewlett Packard Enterprise Development LP
> # > # SPDX-License-Identifier: BSD-2-Clause-Patent > # > ## > @@ -112,10 +112,12 @@ [SkuIds] > # > # Library Class section - list of all Library Classes needed by this Platform. > # > ################################################################################ > [LibraryClasses] > + !include MdePkg/MdeLibs.dsc.inc > + > PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf > TimerLib|OvmfPkg/Library/AcpiTimerLib/BaseAcpiTimerLib.inf > ResetSystemLib|OvmfPkg/Library/ResetSystemLib/BaseResetSystemLib.inf > PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf > BaseMemoryLib|MdePkg/Library/BaseMemoryLibRepStr/BaseMemoryLibRepStr.inf > diff --git a/OvmfPkg/Bhyve/BhyveX64.dsc b/OvmfPkg/Bhyve/BhyveX64.dsc > index 4a1cdf5aca..3a1a76a3ad 100644 > --- a/OvmfPkg/Bhyve/BhyveX64.dsc > +++ b/OvmfPkg/Bhyve/BhyveX64.dsc > @@ -1,8 +1,8 @@ > # > # Copyright (c) 2020, Rebecca Cran > -# Copyright (c) 2006 - 2020, Intel Corporation. All rights reserved.
> +# Copyright (c) 2006 - 2021, Intel Corporation. All rights reserved.
> # (C) Copyright 2016 Hewlett Packard Enterprise Development LP
> # Copyright (c) 2014, Pluribus Networks, Inc. > # > # SPDX-License-Identifier: BSD-2-Clause-Patent > # > @@ -112,10 +112,12 @@ [SkuIds] > # > # Library Class section - list of all Library Classes needed by this Platform. > # > ################################################################################ > [LibraryClasses] > + !include MdePkg/MdeLibs.dsc.inc > + > PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf > TimerLib|OvmfPkg/Library/AcpiTimerLib/BaseAcpiTimerLibBhyve.inf > PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf > BaseMemoryLib|MdePkg/Library/BaseMemoryLibRepStr/BaseMemoryLibRepStr.inf > BaseLib|MdePkg/Library/BaseLib/BaseLib.inf > diff --git a/OvmfPkg/OvmfPkgIa32.dsc b/OvmfPkg/OvmfPkgIa32.dsc > index 1eaf3e99c6..7b49e2a648 100644 > --- a/OvmfPkg/OvmfPkgIa32.dsc > +++ b/OvmfPkg/OvmfPkgIa32.dsc > @@ -1,9 +1,9 @@ > ## @file > # EFI/Framework Open Virtual Machine Firmware (OVMF) platform > # > -# Copyright (c) 2006 - 2020, Intel Corporation. All rights reserved.
> +# Copyright (c) 2006 - 2021, Intel Corporation. All rights reserved.
> # (C) Copyright 2016 Hewlett Packard Enterprise Development LP
> # Copyright (c) Microsoft Corporation. > # > # SPDX-License-Identifier: BSD-2-Clause-Patent > # > @@ -116,10 +116,12 @@ [SkuIds] > # > # Library Class section - list of all Library Classes needed by this Platform. > # > ################################################################################ > [LibraryClasses] > + !include MdePkg/MdeLibs.dsc.inc > + > PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf > TimerLib|OvmfPkg/Library/AcpiTimerLib/BaseAcpiTimerLib.inf > ResetSystemLib|OvmfPkg/Library/ResetSystemLib/BaseResetSystemLib.inf > PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf > BaseMemoryLib|MdePkg/Library/BaseMemoryLibRepStr/BaseMemoryLibRepStr.inf > diff --git a/OvmfPkg/OvmfPkgIa32X64.dsc b/OvmfPkg/OvmfPkgIa32X64.dsc > index 4a5a430147..b60212843b 100644 > --- a/OvmfPkg/OvmfPkgIa32X64.dsc > +++ b/OvmfPkg/OvmfPkgIa32X64.dsc > @@ -1,9 +1,9 @@ > ## @file > # EFI/Framework Open Virtual Machine Firmware (OVMF) platform > # > -# Copyright (c) 2006 - 2020, Intel Corporation. All rights reserved.
> +# Copyright (c) 2006 - 2021, Intel Corporation. All rights reserved.
> # (C) Copyright 2016 Hewlett Packard Enterprise Development LP
> # Copyright (c) Microsoft Corporation. > # > # SPDX-License-Identifier: BSD-2-Clause-Patent > # > @@ -120,10 +120,12 @@ [SkuIds] > # > # Library Class section - list of all Library Classes needed by this Platform. > # > ################################################################################ > [LibraryClasses] > + !include MdePkg/MdeLibs.dsc.inc > + > PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf > TimerLib|OvmfPkg/Library/AcpiTimerLib/BaseAcpiTimerLib.inf > ResetSystemLib|OvmfPkg/Library/ResetSystemLib/BaseResetSystemLib.inf > PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf > BaseMemoryLib|MdePkg/Library/BaseMemoryLibRepStr/BaseMemoryLibRepStr.inf > diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc > index d4d601b444..0c06f33782 100644 > --- a/OvmfPkg/OvmfPkgX64.dsc > +++ b/OvmfPkg/OvmfPkgX64.dsc > @@ -1,9 +1,9 @@ > ## @file > # EFI/Framework Open Virtual Machine Firmware (OVMF) platform > # > -# Copyright (c) 2006 - 2020, Intel Corporation. All rights reserved.
> +# Copyright (c) 2006 - 2021, Intel Corporation. All rights reserved.
> # (C) Copyright 2016 Hewlett Packard Enterprise Development LP
> # Copyright (c) Microsoft Corporation. > # > # SPDX-License-Identifier: BSD-2-Clause-Patent > # > @@ -120,10 +120,12 @@ [SkuIds] > # > # Library Class section - list of all Library Classes needed by this Platform. > # > ################################################################################ > [LibraryClasses] > + !include MdePkg/MdeLibs.dsc.inc > + > PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf > TimerLib|OvmfPkg/Library/AcpiTimerLib/BaseAcpiTimerLib.inf > ResetSystemLib|OvmfPkg/Library/ResetSystemLib/BaseResetSystemLib.inf > PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf > BaseMemoryLib|MdePkg/Library/BaseMemoryLibRepStr/BaseMemoryLibRepStr.inf > diff --git a/OvmfPkg/OvmfXen.dsc b/OvmfPkg/OvmfXen.dsc > index 507029404f..92e8d1967c 100644 > --- a/OvmfPkg/OvmfXen.dsc > +++ b/OvmfPkg/OvmfXen.dsc > @@ -1,9 +1,9 @@ > ## @file > # EFI/Framework Open Virtual Machine Firmware (OVMF) platform > # > -# Copyright (c) 2006 - 2020, Intel Corporation. All rights reserved.
> +# Copyright (c) 2006 - 2021, Intel Corporation. All rights reserved.
> # (C) Copyright 2016 Hewlett Packard Enterprise Development LP
> # Copyright (c) 2019, Citrix Systems, Inc. > # Copyright (c) Microsoft Corporation. > # > # SPDX-License-Identifier: BSD-2-Clause-Patent > @@ -110,10 +110,12 @@ [SkuIds] > # > # Library Class section - list of all Library Classes needed by this Platform. > # > ################################################################################ > [LibraryClasses] > + !include MdePkg/MdeLibs.dsc.inc > + > PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf > TimerLib|MdePkg/Library/SecPeiDxeTimerLibCpu/SecPeiDxeTimerLibCpu.inf > ResetSystemLib|OvmfPkg/Library/ResetSystemLib/BaseResetSystemLib.inf > PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf > BaseMemoryLib|MdePkg/Library/BaseMemoryLibRepStr/BaseMemoryLibRepStr.inf >