From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::544; helo=mail-pg1-x544.google.com; envelope-from=ming.huang@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-pg1-x544.google.com (mail-pg1-x544.google.com [IPv6:2607:f8b0:4864:20::544]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 0F26F21A07094 for ; Tue, 12 Feb 2019 20:43:29 -0800 (PST) Received: by mail-pg1-x544.google.com with SMTP id s198so569664pgs.2 for ; Tue, 12 Feb 2019 20:43:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=/Id8MwuoXj4yEGhlOLxR3ChzaJAPCUEO/ud/5IemdzM=; b=ENYJVGc/iHgLFx0kBywBL47VQaHoZiFr98Zyk9IfOUohaedZYLk2VKqpNpGzJ/X1RP T/rNM2eDN0j67zJN3InVIHuhxyL1LJmndK7luH22tnqDye3+Fl5Awd4ALFagJqSDcfZt hHM3xW57teMPJlM9HEF+CiGmQkNeGXE+FFS4eyYNQ2bBhCrGnQb1m2xHlLxQZtl1Vn/o Z9EA9zS+2jeMRFBzOuOzentR1frGcwOoXh5RgqaUFZxfC+49BAcwDDjXXZCgz9nGG9dr 0FJfAEC6STyqR8ZJHJ0azPRckaj+gLEsRI5SxP9WazB4OLFrRfguKCBr7HFuHCy1nhIO AWEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=/Id8MwuoXj4yEGhlOLxR3ChzaJAPCUEO/ud/5IemdzM=; b=F+LH3qKo2D2HRrJ20FIV85HYvBLZz3rKMoVI2wszvaO007DQ/06FFpvO6whBpXca1y v5dm8J9LLRfikM6LR+7DqD2atenae9qgn+kPTG8mj0U+1CKK56b+6z+08gJVVqm2aOzj jDKh+lePj/wTmBIIe7lwGH/LCXTAxlYPSacW876LiKaRn8BWT4ILtvdPUPz4oHHOu/qt KA0RpuSLty7Evhk3h4GOAg+/m1aKR/s+I8YppE/QveQOqKHxTeUVJgd7LFdTQHY4FnRF Wu4/0rr3ZmQuVZ5KHx+kmY5uPNqYq7HR5pH+5PXsR8gf8iJ4VHAlfLTDNuCqsY8FEMWC Iu9A== X-Gm-Message-State: AHQUAuYglHGqCfpsM2Kw/hglS/Q5nGtma8kghQpBOgHQsnkMXJ/5D+rt KmmP2HDeiZFi7myz3qngJAtqdA== X-Google-Smtp-Source: AHgI3IbgjkgiPQm4OCPt+kHvDShPbZ8hzjvAgh6CAG5WiTe+LZUOhmCmnKCpZbS5R/MYgbKDKztmXA== X-Received: by 2002:a62:4b56:: with SMTP id y83mr7558179pfa.235.1550033009657; Tue, 12 Feb 2019 20:43:29 -0800 (PST) Received: from [10.58.0.74] ([64.64.108.254]) by smtp.gmail.com with ESMTPSA id i24sm7187207pgg.14.2019.02.12.20.43.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 12 Feb 2019 20:43:29 -0800 (PST) To: Leif Lindholm Cc: linaro-uefi@lists.linaro.org, edk2-devel@lists.01.org, graeme.gregory@linaro.org, ard.biesheuvel@linaro.org, michael.d.kinney@intel.com, lersek@redhat.com, wanghuiqiang@huawei.com, huangming23@huawei.com, zhangjinsong2@huawei.com, huangdaode@hisilicon.com, john.garry@huawei.com, xinliang.liu@linaro.org, zhangfeng56@huawei.com References: <20190201133436.10500-1-ming.huang@linaro.org> <20190201133436.10500-13-ming.huang@linaro.org> <20190211145436.arcms5iqpu6vah7f@bivouac.eciton.net> From: Ming Huang Message-ID: <5e49dd77-5141-0809-2a00-989d6ff03cbe@linaro.org> Date: Wed, 13 Feb 2019 12:43:17 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.0 MIME-Version: 1.0 In-Reply-To: <20190211145436.arcms5iqpu6vah7f@bivouac.eciton.net> Subject: Re: [PATCH edk2-platforms v1 12/16] Hisilicon/D06: Use new flash layout X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Feb 2019 04:43:30 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 2/11/2019 10:54 PM, Leif Lindholm wrote: > On Fri, Feb 01, 2019 at 09:34:32PM +0800, Ming Huang wrote: >> In new flash layout, BIOS fd change from offset 1M to 8M in 16M >> spi flash. > > This bit > >> Use the new CustomData.Fv which indicate the offset >> of fd and which flash area can be updated for BMC. > > is of critical importance. Should be its own paragraph. > > How does this change affect variable storage? Will the server maintain > state after a firmware upgrade, or will the operator need to rescue it > manually via the BMC? As the address of variable is change, need to update via the BMC for 19.02. Thanks > > / > Leif > >> >> This patch is relative with patch "Use new flash layout" in >> edk2-non-osi. >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Ming Huang >> --- >> Platform/Hisilicon/D06/D06.fdf | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/Platform/Hisilicon/D06/D06.fdf b/Platform/Hisilicon/D06/D06.fdf >> index d495ad7f264c..f72b513352fb 100644 >> --- a/Platform/Hisilicon/D06/D06.fdf >> +++ b/Platform/Hisilicon/D06/D06.fdf >> @@ -29,7 +29,7 @@ [DEFINES] >> ################################################################################ >> [FD.D06] >> >> -BaseAddress = 0x204100000|gArmTokenSpaceGuid.PcdFdBaseAddress # The base address of the Firmware in NOR Flash. >> +BaseAddress = 0x204800000|gArmTokenSpaceGuid.PcdFdBaseAddress # The base address of the Firmware in NOR Flash. >> >> Size = 0x00400000|gArmTokenSpaceGuid.PcdFdSize # The size in bytes of the FLASH Device >> ErasePolarity = 1 >> @@ -124,7 +124,7 @@ [FD.D06] >> 0x003E0000|0x00010000 >> >> 0x003F0000|0x00010000 >> -FILE = Platform/Hisilicon/D0x-CustomData.Fv >> +FILE = Platform/Hisilicon/D06/CustomData.Fv >> >> ################################################################################ >> # >> -- >> 2.9.5 >>