From: "Rebecca Cran" <rebecca@bsdio.com>
To: devel@edk2.groups.io, TonyLo@ami.com,
"Richard Ho (何明忠)" <RichardHo@ami.com>
Cc: Andrew Fish <afish@apple.com>,
Leif Lindholm <quic_llindhol@quicinc.com>,
Michael D Kinney <michael.d.kinney@intel.com>,
Michael Kubacki <michael.kubacki@microsoft.com>,
Zhiguang Liu <zhiguang.liu@intel.com>,
Liming Gao <gaoliming@byosoft.com.cn>,
Dos Hsieh <doshsieh@ami.com>, Felix Polyudov <Felixp@ami.com>,
Srini Narayana <SriniN@ami.com>,
Harikrishna Doppalapudi <Harikrishnad@ami.com>
Subject: Re: [edk2-devel] [PATCH v3 1/3] UsbNetworkPkg/UsbRndis: Add USB RNDIS devices support
Date: Wed, 15 Feb 2023 10:28:06 -0700 [thread overview]
Message-ID: <5e5f67c7-2149-4f6d-d3d3-d4800923edf7@bsdio.com> (raw)
In-Reply-To: <CO1PR10MB46921DBA625360399739A9C1DFA39@CO1PR10MB4692.namprd10.prod.outlook.com>
It looks like the emails are still getting mangled: when I "View Source"
in Thunderbird I'm seeing "=" replaced with "=3D" for example.
Could you make sure you've run "py3 BaseTools\Scripts\SetupGit.py" to
configure your edk2 repo? That should also cause a cover letter to be
generated when you run "git format-patch" since I've noticed it's missing.
Also, it looks like the files have UNIX line endings. Could you convert
them to DOS please? It would be nice if you could run the paches through
EDK2 CI either locally
(https://github.com/tianocore/tianocore.github.io/wiki/How-to-Build-With-Stuart)
or by pushing them to a personal GitHub fork and opening a PR. For
example, one issue the ECC tool will likely complain about is the header
guard format:
> +#ifndef EDKII_USB_ETHERNET_PROTOCOL_H
> +#define EDKII_USB_ETHERNET_PROTOCOL_H
While there shouldn't be leading underscrore, there _should_ be a
trailing underscore.
--
Rebecca Cran
On 2/14/23 22:47, Tony Lo (羅金松) via groups.io wrote:
> +teams
>
> -----Original Message-----
> From: Richard Ho (何明忠) <RichardHo@ami.com>
> Sent: Wednesday, February 15, 2023 1:37 PM
> To: devel@edk2.groups.io
> Cc: Andrew Fish <afish@apple.com>; Leif Lindholm <quic_llindhol@quicinc.com>; Michael D Kinney <michael.d.kinney@intel.com>; Michael Kubacki <michael.kubacki@microsoft.com>; Zhiguang Liu <zhiguang.liu@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; Tony Lo (羅金松) <TonyLo@ami.com>
> Subject: [PATCH v3 1/3] UsbNetworkPkg/UsbRndis: Add USB RNDIS devices support
>
> This driver provides UEFI driver for USB RNDIS device
>
> Signed-off-by: Richard Ho <richardho@ami.com>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Michael Kubacki <michael.kubacki@microsoft.com>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Reviewed-by: Tony Lo <tonylo@ami.com>
> ---
> UsbNetworkPkg/Config/UsbNetworkPkg.inc.dsc | 9 +
> .../Config/UsbNetworkPkgComponentsDxe.inc.dsc | 20 +
> .../Config/UsbNetworkPkgComponentsDxe.inc.fdf | 20 +
> .../Config/UsbNetworkPkgDefines.inc.dsc | 23 +
> .../Protocol/EdkIIUsbEthernetProtocol.h | 877 ++++++++
> UsbNetworkPkg/NetworkCommon/ComponentName.c | 263 +++
> UsbNetworkPkg/NetworkCommon/DriverBinding.c | 588 ++++++
> UsbNetworkPkg/NetworkCommon/DriverBinding.h | 266 +++
> UsbNetworkPkg/NetworkCommon/NetworkCommon.inf | 49 +
> UsbNetworkPkg/NetworkCommon/PxeFunction.c | 1797 +++++++++++++++++
> UsbNetworkPkg/ReadMe.md | 65 +
> UsbNetworkPkg/ReleaseNotes.md | 11 +
> UsbNetworkPkg/UsbNetworkPkg.dec | 46 +
> UsbNetworkPkg/UsbRndis/ComponentName.c | 172 ++
> UsbNetworkPkg/UsbRndis/UsbRndis.c | 886 ++++++++
> UsbNetworkPkg/UsbRndis/UsbRndis.h | 586 ++++++
> UsbNetworkPkg/UsbRndis/UsbRndis.inf | 42 +
> UsbNetworkPkg/UsbRndis/UsbRndisFunction.c | 1714 ++++++++++++++++
> 18 files changed, 7434 insertions(+)
> create mode 100644 UsbNetworkPkg/Config/UsbNetworkPkg.inc.dsc
> create mode 100644 UsbNetworkPkg/Config/UsbNetworkPkgComponentsDxe.inc.dsc
> create mode 100644 UsbNetworkPkg/Config/UsbNetworkPkgComponentsDxe.inc.fdf
> create mode 100644 UsbNetworkPkg/Config/UsbNetworkPkgDefines.inc.dsc
> create mode 100644 UsbNetworkPkg/Include/Protocol/EdkIIUsbEthernetProtocol.h
> create mode 100644 UsbNetworkPkg/NetworkCommon/ComponentName.c
> create mode 100644 UsbNetworkPkg/NetworkCommon/DriverBinding.c
> create mode 100644 UsbNetworkPkg/NetworkCommon/DriverBinding.h
> create mode 100644 UsbNetworkPkg/NetworkCommon/NetworkCommon.inf
> create mode 100644 UsbNetworkPkg/NetworkCommon/PxeFunction.c
> create mode 100644 UsbNetworkPkg/ReadMe.md
> create mode 100644 UsbNetworkPkg/ReleaseNotes.md
> create mode 100644 UsbNetworkPkg/UsbNetworkPkg.dec
> create mode 100644 UsbNetworkPkg/UsbRndis/ComponentName.c
> create mode 100644 UsbNetworkPkg/UsbRndis/UsbRndis.c
> create mode 100644 UsbNetworkPkg/UsbRndis/UsbRndis.h
> create mode 100644 UsbNetworkPkg/UsbRndis/UsbRndis.inf
> create mode 100644 UsbNetworkPkg/UsbRndis/UsbRndisFunction.c
next prev parent reply other threads:[~2023-02-15 17:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-15 5:36 [PATCH v3 1/3] UsbNetworkPkg/UsbRndis: Add USB RNDIS devices support RichardHo [何明忠]
2023-02-15 5:36 ` [PATCH v3 2/3] UsbNetworkPkg/UsbCdcEcm: Add USB Cdc ECM " RichardHo [何明忠]
2023-02-15 5:36 ` [PATCH v3 3/3] UsbNetworkPkg/UsbCdcNcm: Add USB Cdc NCM " RichardHo [何明忠]
2023-02-15 5:47 ` [PATCH v3 1/3] UsbNetworkPkg/UsbRndis: Add USB RNDIS " Tony Lo (羅金松)
2023-02-15 17:28 ` Rebecca Cran [this message]
2023-02-16 7:06 ` [edk2-devel] " RichardHo [何明忠]
2023-02-15 10:23 ` Michael Brown
2023-02-16 2:21 ` RichardHo [何明忠]
2023-02-15 15:13 ` Rebecca Cran
2023-02-16 11:52 ` Tinh Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e5f67c7-2149-4f6d-d3d3-d4800923edf7@bsdio.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox