From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Mon, 16 Sep 2019 12:31:09 -0700 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E927D83F3C; Mon, 16 Sep 2019 19:31:08 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-124-96.rdu2.redhat.com [10.10.124.96]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0A9A060A9F; Mon, 16 Sep 2019 19:31:06 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH 09/11] OvmfPkg/XenBusDxe: Fix NotifyExitBoot to avoid Memory Allocation Services To: Andrew Fish , devel@edk2.groups.io Cc: Anthony Perard , Ard Biesheuvel , Julien Grall , Jordan Justen , xen-devel@lists.xenproject.org References: <20190913145100.303433-1-anthony.perard@citrix.com> <20190913145100.303433-10-anthony.perard@citrix.com> <26405443-8a65-5d03-dd35-1000ac3fbf0a@redhat.com> From: "Laszlo Ersek" Message-ID: <5e73e526-0f76-5f91-aa7c-a4adaeee4608@redhat.com> Date: Mon, 16 Sep 2019 21:31:06 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Mon, 16 Sep 2019 19:31:09 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 09/16/19 20:36, Andrew Fish wrote: > > >> On Sep 16, 2019, at 10:36 AM, Laszlo Ersek wrote: >> >> On 09/13/19 16:50, Anthony PERARD wrote: >>> This patch fix the EVT_SIGNAL_EXIT_BOOT_SERVICES handler to avoid >>> using the Memory Allocation Services. >>> >>> This comes with a new interface named RegisterExitCallback so that PV >>> drivers can disconnect from the backend before XenBusDxe is teared >>> down. >>> >>> Instead of using Disconnect() to tear down the XenBus driver and the >>> children drivers, we are going to ask every driver using >>> XENBUS_PROTOCOL to disconnect from the hardware via the callback set >>> with RegisterExitCallback, then reset the xenstore shared ring and >>> the grant table. >> >> I think this approach -- a lower-level bus driver calling out to >> dependent device drivers -- is quite unusual. >> > > Laszlo, > > I agree given the timer event activity is stopped prior to calling any of the EXIT_BOOT_SERVICES events there is usually not a requirement to call the drivers Stop() function. Generally Exit Boot Services events just turn off DMA, or any other hardware that could touch memory that is being freed back for OS usage. Since the timer activity, and thus all event activity is stopped there is not a lot of ways for the drivers to ever have any EFI code run again. > > The only other exception I can think of is if the OS driver makes some kind of assumption about the state of the hardware. The hardware that could touch memory that is being freed back for OS usage is the part that applies here. Most paravirtual devices work by sharing at least some memory between the host-side device model (emulation) and guest-side device driver. When the guest is transitioning from firmware to OS (and those of course have different guest drivers for the paravirtual device), the host must be made forget the memory shared with the guest firmware driver (as the guest OS boot loader or the guest OS itself might load anything at all into that RAM area after ExitBootServices()). So what I found unusual in this patch wasn't the necessity of EBS notification functions, but how they would be ordered / coordinated between each other. There is a bus-like device that shares its own resources (RAM) with the host, and installs protocol interfaces. And there are dependent endpoint-like devices that consume those protocol interfaces, and share their own stuff (RAM) with the host OS. All of that shared memory needs to be cleared from the host's book-keeping when we leave firmware land; the tricky part is that the bus-like device can't request the host for its bus-level shared memory to be forgotten before all of the dependent endpoints ask for their shared ranges to be forgotten. Thanks! Laszlo >> How about the following instead: >> >> - introduce two XenBusIo protocol member functions, AddReference() and >> RemoveReference(). RemoveReference() should take a BOOLEAN called >> "HandOffToOs". The device drivers should call AddReference() just before >> exiting DriverBindingStart() with success, and RemoveReference(FALSE) in >> DriverBindingStop(). >> >> - these protocol member functions would increment / decrement a >> reference counter in the underlying XenBus abstraction. Additionally, >> RemoveReference() would store the HandOffToOs parameter to a bus-level >> BOOLEAN too (regardless of previous value stored there -- a TRUE->FALSE >> transition would never happen anyway; see below). >> >> - both XenBusDxe and the Xen device drivers should register EBS >> callbacks, per controller handle (in BindingStart()), and unregister >> them (in BindingStop()) >> >> - the ordering between EBS notification functions (queued at the same >> TPL) is unspecified. In the device driver notification functions, the >> last action should be a call to XenBusIo->RemoveReference(TRUE) -- after >> the device-specific "forget me" actions have been done. >> >> - if RemoveReference() gets a TRUE parameter, then it should check the >> resultant (post-decrement) value of the refcount. If it has gone to >> zero, RemoveReference() should re-set the xenbus / xenstore connection. >> If the parameter is FALSE, it shouldn't do anything particular after >> decrementing the refcount. >> >> - in the XenBus EBS handler, if the refcount is positive at the time of >> the call, nothing should be done. Otherwise, if HandOffToOs is TRUE, >> nothing should be done, similarly. Otherwise, the xenbus/xenstore >> connection should be re-set. >> >> The idea is that normal Start/Stop should manage the refcount as >> expected. At ExitBootServices(), the XenBus level handler should only >> clear the connection to the hypervisor if no RemoveReference() call has >> done, or will do, it. (If the counter is positive, then a later >> RemoveReference() call will do it; if it's zero but HandOffToOs is TRUE, >> then it's been done already. If the counter is zero and the BOOLEAN is >> FALSE, then all devices have been disconnected normally with Stop() -- >> or none have been connected at all --, before ExitBootServices(), so the >> XenBus driver itself has to ask for being forgotten.) >> >> Admittedly, this is more complicated (due to the unspecified ordering >> between EBS notifications). I just feel it's more idiomatic to go >> through normal protocol member functions in EBS notification functions, >> rather than special callbacks. >> >> (Side comment: the reference counting could normally be replaced by >> gBS->OpenProtocolInformation(); however, that service itself allocates >> memory, so we can't use it in EBS notification functions.) >> >> Thanks >> Laszlo >> >> >> >