From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by mx.groups.io with SMTP id smtpd.web10.14362.1683856008485139925 for ; Thu, 11 May 2023 18:46:48 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="signature has expired" header.i=@bsdio.com header.s=fm1 header.b=lNdCKGK1; spf=pass (domain: bsdio.com, ip: 66.111.4.25, mailfrom: rebecca@bsdio.com) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id B1D1B5C14D3; Thu, 11 May 2023 21:46:47 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Thu, 11 May 2023 21:46:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdio.com; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1683856007; x=1683942407; bh=IGFQRT990xkojxqs4eMyQmP4V7DCHeNmzIU DRmbKVzE=; b=lNdCKGK1Z6iyXDcyl1PyZwcKM6AhObKCm8pURBSwA7g2S1EPQHz sOh0Ca/81C/7HnZ9r1E8cdbO+ljz0JTi1nvBcaV3VrXEFyHTC/CUfSetfxHCAnpy QhSiKI5ysJMMpFuzI7eXpMRBoFBk/Hh765aNpXA9lS8RzXENRVPUJH0qY6eeIcZd t4ecWBL4UOLCPBC3CMdWfBVc8OXm9TFshM2LC33dNRhn86/XqRSKfJ4/hMkbGwqf zPGUYMouW9H+JeNJwvc9C9WgU6qYJxMTt8dfGRV5iFindfspakfFCW9czSgwJ8x1 lC8epv11Bl46vwyucmooLHTVwFXMV2nYOaQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1683856007; x=1683942407; bh=IGFQRT990xkojxqs4eMyQmP4V7DCHeNmzIU DRmbKVzE=; b=J/Prb8sDFTcZhFJLYidG+j0xcYlW8tRekwUfRzMsG6Y/UjKivDE 37YdIW87UwN9QCRwCEiGyyB9eKpVlkT7cC/PHDswXl5vMFK7MFhw0byFuh321M6C zj+5qHTKpG+gq3DqA4+SakXNs88BCwVVBo2+MQhTki8U8iUgLwg6Kf0TYRZL2KrD B8Mp1LDi8oaC97y51jrAvD509qCuzxahE/uDRySX+Xv3TyTzqDxvRLUMMtzNxVLY ZtQxB3uUXggg0/hDRPa76V87Lu8nQy6LWnoyVT1seAVj2tHYfbrLKs4og2e2ytbm t1C+j8CYtxDc3PpuyOSRCvnA3cJz7zWoMeQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfeegledggeejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtfeejnecuhfhrohhmpeftvggs vggttggrucevrhgrnhcuoehrvggsvggttggrsegsshguihhordgtohhmqeenucggtffrrg htthgvrhhnpeehleekgfdutedugeehgeffgffhteefhffhteetfeevhefgvdejhedthfff ieffleenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hrvggsvggttggrsegsshguihhordgtohhm X-ME-Proxy: Feedback-ID: i5b994698:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 11 May 2023 21:46:46 -0400 (EDT) Message-ID: <5e8aeb3f-6e06-3786-ae47-f0b9dfb69f29@bsdio.com> Date: Thu, 11 May 2023 19:46:45 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH] BaseTools/tools_def: Drop ref to undefined CLANGDWARF_ARM_PREFIX To: Ard Biesheuvel , devel@edk2.groups.io Cc: Liming Gao References: <20230511065940.3178891-1-ardb@kernel.org> From: "Rebecca Cran" In-Reply-To: <20230511065940.3178891-1-ardb@kernel.org> Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Reviewed-by: Rebecca Cran Thanks! On 5/11/23 12:59 AM, Ard Biesheuvel wrote: > When using CLANGDWARF to build for the ARM architecture, objcopy is > references via the wrong environment variable, resulting in the wrong > llvm-objcopy to be used (if one exists), or the build to fail (if > CLANGDWARF_BIN points to the only available instance) > > So use CLANGDWARF_BIN instead, which was what was intended. > > Cc: Rebecca Cran > Cc: Liming Gao > Fixes: ecbc394365f50f3c ("BaseTools: Set CLANGDWARF RC path ...") > Signed-off-by: Ard Biesheuvel > --- > BaseTools/Conf/tools_def.template | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def.template > index 4ae21b85a8571f93..503a6687c1f03f56 100755 > --- a/BaseTools/Conf/tools_def.template > +++ b/BaseTools/Conf/tools_def.template > @@ -1957,7 +1957,7 @@ DEFINE CLANGDWARF_ARM_DLINK_FLAGS = DEF(CLANGDWARF_ARM_TARGET) DEF(GCC_ARM_DLI > *_CLANGDWARF_ARM_ASLDLINK_PATH = ENV(CLANGDWARF_BIN)clang > > > > *_CLANGDWARF_ARM_SLINK_PATH = ENV(CLANGDWARF_BIN)llvm-ar > > -*_CLANGDWARF_ARM_RC_PATH = ENV(CLANGDWARF_ARM_PREFIX)llvm-objcopy > > +*_CLANGDWARF_ARM_RC_PATH = ENV(CLANGDWARF_BIN)llvm-objcopy > > > > *_CLANGDWARF_ARM_ASLCC_FLAGS = DEF(GCC_ASLCC_FLAGS) -fno-lto > > *_CLANGDWARF_ARM_ASLDLINK_FLAGS = DEF(CLANGDWARF_ARM_TARGET) DEF(GCC_ARM_ASLDLINK_FLAGS) >