From: rebecca@bsdio.com
To: devel@edk2.groups.io, lersek@redhat.com
Cc: "Liming Gao" <liming.gao@intel.com>,
"Michael D Kinney" <michael.d.kinney@intel.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Zhichao Gao" <zhichao.gao@intel.com>
Subject: Re: [edk2-devel] [PATCH] MdePkg/BaseLib: Base64Decode(): don't declare variables in nested blocks
Date: Tue, 16 Jul 2019 17:03:09 -0600 [thread overview]
Message-ID: <5e8f317a-d2ab-ea3f-c052-47b787110680@bsdio.com> (raw)
In-Reply-To: <20190716225926.19732-1-lersek@redhat.com>
On 2019-07-16 16:59, Laszlo Ersek wrote:
>
> Hoist such variable declarations in Base64Decode() to the outermost
> function scope.
>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
> Cc: Zhichao Gao <zhichao.gao@intel.com>
> Fixes: 35e242b698cdc6205e99a6d6a188bf27fecf9fb4
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1980
> Reported-by: Zhichao Gao <zhichao.gao@intel.com>
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Rebecca Cran <rebecca@bsdio.com>
next prev parent reply other threads:[~2019-07-16 23:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-16 22:59 [PATCH] MdePkg/BaseLib: Base64Decode(): don't declare variables in nested blocks Laszlo Ersek
2019-07-16 23:03 ` rebecca [this message]
2019-07-17 1:00 ` Liming Gao
2019-07-17 7:03 ` Philippe Mathieu-Daudé
2019-07-17 14:42 ` [edk2-devel] " Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e8f317a-d2ab-ea3f-c052-47b787110680@bsdio.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox