From: Jaben Carsey <jaben.carsey@intel.com>
To: edk2-devel@lists.01.org
Cc: Liming Gao <liming.gao@intel.com>, Yonghong Zhu <yonghong.zhu@intel.com>
Subject: [PATCH v1 4/4] BaseTools: remove uncalled functions
Date: Thu, 29 Mar 2018 17:19:33 -0700 [thread overview]
Message-ID: <5ea46e6e61bf7ec83f9a85c8f2392807abf0d015.1522369073.git.jaben.carsey@intel.com> (raw)
In-Reply-To: <cover.1522369072.git.jaben.carsey@intel.com>
In-Reply-To: <cover.1522369072.git.jaben.carsey@intel.com>
this same function in 2 classes is never called.
Cc: Liming Gao <liming.gao@intel.com>
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
---
BaseTools/Source/Python/Ecc/CodeFragmentCollector.py | 19 -------------------
BaseTools/Source/Python/Eot/CodeFragmentCollector.py | 19 -------------------
2 files changed, 38 deletions(-)
diff --git a/BaseTools/Source/Python/Ecc/CodeFragmentCollector.py b/BaseTools/Source/Python/Ecc/CodeFragmentCollector.py
index fc50eb27a78d..f8b0a9ecf4c0 100644
--- a/BaseTools/Source/Python/Ecc/CodeFragmentCollector.py
+++ b/BaseTools/Source/Python/Ecc/CodeFragmentCollector.py
@@ -75,25 +75,6 @@ class CodeFragmentCollector:
self.__Token = ""
self.__SkippedChars = ""
- ## __SkipWhiteSpace() method
- #
- # Skip white spaces from current char, return number of chars skipped
- #
- # @param self The object pointer
- # @retval Count The number of chars skipped
- #
- def __SkipWhiteSpace(self):
- Count = 0
- while not self.__EndOfFile():
- Count += 1
- if self.__CurrentChar() in (T_CHAR_NULL, T_CHAR_CR, T_CHAR_LF, T_CHAR_SPACE, T_CHAR_TAB):
- self.__SkippedChars += str(self.__CurrentChar())
- self.__GetOneChar()
-
- else:
- Count = Count - 1
- return Count
-
## __EndOfFile() method
#
# Judge current buffer pos is at file end
diff --git a/BaseTools/Source/Python/Eot/CodeFragmentCollector.py b/BaseTools/Source/Python/Eot/CodeFragmentCollector.py
index 00668eca3421..c7218439b7ea 100644
--- a/BaseTools/Source/Python/Eot/CodeFragmentCollector.py
+++ b/BaseTools/Source/Python/Eot/CodeFragmentCollector.py
@@ -73,25 +73,6 @@ class CodeFragmentCollector:
self.__Token = ""
self.__SkippedChars = ""
- ## __SkipWhiteSpace() method
- #
- # Skip white spaces from current char, return number of chars skipped
- #
- # @param self The object pointer
- # @retval Count The number of chars skipped
- #
- def __SkipWhiteSpace(self):
- Count = 0
- while not self.__EndOfFile():
- Count += 1
- if self.__CurrentChar() in (T_CHAR_NULL, T_CHAR_CR, T_CHAR_LF, T_CHAR_SPACE, T_CHAR_TAB):
- self.__SkippedChars += str(self.__CurrentChar())
- self.__GetOneChar()
-
- else:
- Count = Count - 1
- return Count
-
## __EndOfFile() method
#
# Judge current buffer pos is at file end
--
2.16.2.windows.1
next prev parent reply other threads:[~2018-03-30 0:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-30 0:19 [PATCH v1 0/4] BaseTools: remove un-needed code Jaben Carsey
2018-03-30 0:19 ` [PATCH v1 1/4] BaseTools: change hex parsing to use built in Jaben Carsey
2018-03-30 0:19 ` [PATCH v1 2/4] BaseTools: remove uncalled function Jaben Carsey
2018-03-30 0:19 ` [PATCH v1 3/4] BaseTools: make static functions when self is not needed Jaben Carsey
2018-03-30 0:19 ` Jaben Carsey [this message]
2018-04-03 9:26 ` [PATCH v1 0/4] BaseTools: remove un-needed code Zhu, Yonghong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ea46e6e61bf7ec83f9a85c8f2392807abf0d015.1522369073.git.jaben.carsey@intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox