From: "Huangming (Mark)" <huangming23@huawei.com>
To: "Zeng, Star" <star.zeng@intel.com>,
Heyi Guo <heyi.guo@linaro.org>,
"leif.lindholm@linaro.org" <leif.lindholm@linaro.org>,
"linaro-uefi@lists.linaro.org" <linaro-uefi@lists.linaro.org>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
"graeme.gregory@linaro.org" <graeme.gregory@linaro.org>
Cc: "ard.biesheuvel@linaro.org" <ard.biesheuvel@linaro.org>,
"Gao, Liming" <liming.gao@intel.com>,
"mengfanrong@huawei.com" <mengfanrong@huawei.com>,
"guoheyi@huawei.com" <guoheyi@huawei.com>,
"zhangjinsong2@huawei.com" <zhangjinsong2@huawei.com>,
"Kinney, Michael D" <michael.d.kinney@intel.com>,
"waip23@126.com" <waip23@126.com>,
"wanghuiqiang@huawei.com" <wanghuiqiang@huawei.com>,
"huangdaode@hisilicon.com" <huangdaode@hisilicon.com>,
"Yao, Jiewen" <jiewen.yao@intel.com>
Subject: Re: [PATCH edk2/MdePkg v1] MdePkg ACPI: Correct processor flags struct of PPTT
Date: Tue, 30 Jan 2018 13:44:39 +0800 [thread overview]
Message-ID: <5eabc2f2-324d-37e3-09c5-5c01d62fcfea@huawei.com> (raw)
In-Reply-To: <0C09AFA07DD0434D9E2A0C6AEB0483103BA19B4D@shsmsx102.ccr.corp.intel.com>
OK, I will refine the title soon.
Thanks.
On 2018/1/30 11:34, Zeng, Star wrote:
> The change looks good to me, Reviewed-by: Star Zeng <star.zeng@intel.com>.
>
> But the title seems not so correct.
> It is about EFI_ACPI_6_2_PPTT_STRUCTURE_PROCESSOR, but not EFI_ACPI_6_2_PPTT_STRUCTURE_PROCESSOR_FLAGS.
> How about to refine the title?
>
>
> Thanks,
> Star
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Heyi Guo
> Sent: Tuesday, January 30, 2018 10:54 AM
> To: leif.lindholm@linaro.org; linaro-uefi@lists.linaro.org; edk2-devel@lists.01.org; graeme.gregory@linaro.org
> Cc: huangming23@huawei.com; ard.biesheuvel@linaro.org; Gao, Liming <liming.gao@intel.com>; mengfanrong@huawei.com; guoheyi@huawei.com; Heyi Guo <heyi.guo@linaro.org>; zhangjinsong2@huawei.com; Kinney, Michael D <michael.d.kinney@intel.com>; waip23@126.com; wanghuiqiang@huawei.com; huangdaode@hisilicon.com
> Subject: [edk2] [PATCH edk2/MdePkg v1] MdePkg ACPI: Correct processor flags struct of PPTT
>
> From: Ming Huang <huangming23@huawei.com>
>
> The Type field of EFI_ACPI_6_2_PPTT_STRUCTURE_PROCESSOR should be UINT8 as ACPI version 6.2 specification.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ming Huang <huangming23@huawei.com>
> Signed-off-by: Heyi Guo <heyi.guo@linaro.org>
> ---
> MdePkg/Include/IndustryStandard/Acpi62.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/MdePkg/Include/IndustryStandard/Acpi62.h b/MdePkg/Include/IndustryStandard/Acpi62.h
> index 82d1425..2904d34 100644
> --- a/MdePkg/Include/IndustryStandard/Acpi62.h
> +++ b/MdePkg/Include/IndustryStandard/Acpi62.h
> @@ -2569,7 +2569,7 @@ typedef struct {
> /// Processor hierarchy node structure
> ///
> typedef struct {
> - UINT32 Type;
> + UINT8 Type;
> UINT8 Length;
> UINT8 Reserved[2];
> EFI_ACPI_6_2_PPTT_STRUCTURE_PROCESSOR_FLAGS Flags;
> --
> 1.9.1
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
>
> .
>
--
Best Regards,
Ming
prev parent reply other threads:[~2018-01-30 5:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-30 2:54 [PATCH edk2/MdePkg v1] Fix definiton bug of Acpi62.h Heyi Guo
2018-01-30 2:54 ` [PATCH edk2/MdePkg v1] MdePkg ACPI: Correct processor flags struct of PPTT Heyi Guo
2018-01-30 3:34 ` Zeng, Star
2018-01-30 5:44 ` Huangming (Mark) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5eabc2f2-324d-37e3-09c5-5c01d62fcfea@huawei.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox