From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=45.249.212.191; helo=huawei.com; envelope-from=huangming23@huawei.com; receiver=edk2-devel@lists.01.org Received: from huawei.com (szxga05-in.huawei.com [45.249.212.191]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 9C3BD21E48F20 for ; Mon, 29 Jan 2018 21:39:25 -0800 (PST) Received: from DGGEMS404-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 3160C23899BDC; Tue, 30 Jan 2018 13:44:45 +0800 (CST) Received: from [127.0.0.1] (10.61.17.224) by DGGEMS404-HUB.china.huawei.com (10.3.19.204) with Microsoft SMTP Server id 14.3.361.1; Tue, 30 Jan 2018 13:44:39 +0800 To: "Zeng, Star" , Heyi Guo , "leif.lindholm@linaro.org" , "linaro-uefi@lists.linaro.org" , "edk2-devel@lists.01.org" , "graeme.gregory@linaro.org" References: <1517280842-48914-1-git-send-email-heyi.guo@linaro.org> <1517280842-48914-2-git-send-email-heyi.guo@linaro.org> <0C09AFA07DD0434D9E2A0C6AEB0483103BA19B4D@shsmsx102.ccr.corp.intel.com> CC: "ard.biesheuvel@linaro.org" , "Gao, Liming" , "mengfanrong@huawei.com" , "guoheyi@huawei.com" , "zhangjinsong2@huawei.com" , "Kinney, Michael D" , "waip23@126.com" , "wanghuiqiang@huawei.com" , "huangdaode@hisilicon.com" , "Yao, Jiewen" From: "Huangming (Mark)" Message-ID: <5eabc2f2-324d-37e3-09c5-5c01d62fcfea@huawei.com> Date: Tue, 30 Jan 2018 13:44:39 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <0C09AFA07DD0434D9E2A0C6AEB0483103BA19B4D@shsmsx102.ccr.corp.intel.com> X-Originating-IP: [10.61.17.224] X-CFilter-Loop: Reflected Subject: Re: [PATCH edk2/MdePkg v1] MdePkg ACPI: Correct processor flags struct of PPTT X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Jan 2018 05:39:27 -0000 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit OK, I will refine the title soon. Thanks. On 2018/1/30 11:34, Zeng, Star wrote: > The change looks good to me, Reviewed-by: Star Zeng . > > But the title seems not so correct. > It is about EFI_ACPI_6_2_PPTT_STRUCTURE_PROCESSOR, but not EFI_ACPI_6_2_PPTT_STRUCTURE_PROCESSOR_FLAGS. > How about to refine the title? > > > Thanks, > Star > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Heyi Guo > Sent: Tuesday, January 30, 2018 10:54 AM > To: leif.lindholm@linaro.org; linaro-uefi@lists.linaro.org; edk2-devel@lists.01.org; graeme.gregory@linaro.org > Cc: huangming23@huawei.com; ard.biesheuvel@linaro.org; Gao, Liming ; mengfanrong@huawei.com; guoheyi@huawei.com; Heyi Guo ; zhangjinsong2@huawei.com; Kinney, Michael D ; waip23@126.com; wanghuiqiang@huawei.com; huangdaode@hisilicon.com > Subject: [edk2] [PATCH edk2/MdePkg v1] MdePkg ACPI: Correct processor flags struct of PPTT > > From: Ming Huang > > The Type field of EFI_ACPI_6_2_PPTT_STRUCTURE_PROCESSOR should be UINT8 as ACPI version 6.2 specification. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ming Huang > Signed-off-by: Heyi Guo > --- > MdePkg/Include/IndustryStandard/Acpi62.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/MdePkg/Include/IndustryStandard/Acpi62.h b/MdePkg/Include/IndustryStandard/Acpi62.h > index 82d1425..2904d34 100644 > --- a/MdePkg/Include/IndustryStandard/Acpi62.h > +++ b/MdePkg/Include/IndustryStandard/Acpi62.h > @@ -2569,7 +2569,7 @@ typedef struct { > /// Processor hierarchy node structure > /// > typedef struct { > - UINT32 Type; > + UINT8 Type; > UINT8 Length; > UINT8 Reserved[2]; > EFI_ACPI_6_2_PPTT_STRUCTURE_PROCESSOR_FLAGS Flags; > -- > 1.9.1 > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel > > . > -- Best Regards, Ming