From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (EUR05-DB8-obe.outbound.protection.outlook.com [40.107.20.70]) by mx.groups.io with SMTP id smtpd.web10.18851.1665572807182684019 for ; Wed, 12 Oct 2022 04:06:47 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=vzF6ga+D; spf=pass (domain: arm.com, ip: 40.107.20.70, mailfrom: sami.mujawar@arm.com) ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=PF5AwgDdjf6QB5W6CvQZ9HO5ib20fqdKnPUe+pgAB1Ori44X94RdMCyYsFKERTDP2tYWMNs6wHc81XaelxtS/oyFQI2FFA0j5fuP4Abj6BHUlc7pJyIVA036QG6AF3MbRBifTQ0fpAnJjGz5ntO+TJkJox+nx0wX1chqUtpOBjaW2nmhdcWN71sAxdcuhDWF97oMod1v6VUeT6Ia5J7mZac2IerW3aQ+a8VfWk4lHnq/77O0oHrOAEEAVeJy7LK+51rhM8NOIjQ6WnnPHISrQWLHo0qZzArc1ZBhnq8wUZN/scahLLyQ0H6ZDBaEtZXX7H0kpyMMkda0a76BynvBdg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=w2LHJ56rn0W4/IGr5rFyrfRHb7VboWR2i1p3MUw3Kpw=; b=CvpVMT8RlVavxZoRPaVlxf8TCH5qfrEAKK01g4Hutm1V0WOXiSpYxHFeKDcN/MkdTy6+d3opgro8pfToq1Dke4/4SxDk3yZF1zTCacHXEyaVmpBxWE8vYjy9aPSEUZngJThKwRw+Xfz4itnlSoi8kpXveo0cnM+mPu5roXiE4ieSbUHVWEn2iqn2hgSoCP9LYFOi/lS/M9WqDck1Wet23d4bvc/rJCqn03M5if4fYZjDNnaEzjHikNcfhjAHCBYbwSGGz0q1coVwhFiPzT/qeUZhieBnCSr0lVtL8lpkPCZKT56DtUuIg9ldsIb+8o0c6F2SWy0of+4WxipqN/mPVg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=w2LHJ56rn0W4/IGr5rFyrfRHb7VboWR2i1p3MUw3Kpw=; b=vzF6ga+DoLSVHqjeUk/hWC6oR8Jh2fxcHOPV9KY8IQ4nEMxsqEm1M1VZY/rbrH1DLUwG0GG9ECTWKf3a2mFjYWZjx0L7kowdj6MY3gEk9boGOmVbtPpBoPvqS1df2wuarbhv3G+C/iC2Am6603j7/FUAcbUUcY+vOLQcQxDibco= Received: from FR0P281CA0095.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a9::12) by DU0PR08MB7487.eurprd08.prod.outlook.com (2603:10a6:10:357::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15; Wed, 12 Oct 2022 11:06:43 +0000 Received: from VE1EUR03FT044.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:a9:cafe::b8) by FR0P281CA0095.outlook.office365.com (2603:10a6:d10:a9::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.21 via Frontend Transport; Wed, 12 Oct 2022 11:06:43 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT044.mail.protection.outlook.com (10.152.19.106) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.10 via Frontend Transport; Wed, 12 Oct 2022 11:06:42 +0000 Received: ("Tessian outbound 7761be2ecf00:v128"); Wed, 12 Oct 2022 11:06:42 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: f5562d7827ad730e X-CR-MTA-TID: 64aa7808 Received: from 6f292ad00e19.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id E88E13DD-48A7-43D0-9399-A0617989D764.1; Wed, 12 Oct 2022 11:06:35 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 6f292ad00e19.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 12 Oct 2022 11:06:35 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jnRdmW+ny+g6728X+wWVpu0PPDEQZeudWT71qJ93UFPRlwPEbNWqL4u/Gej77PlMUKOLFzY6K9DeE5bcCDG6cyIkdCeocxvbfYk8tQs6vopZdPhWuBQ5pJWBArGgRZzlxVP3lnmUQpT4q7lWHOt14xPYLvXovLKPMmacVvoGxxDJCNFKKnhu99WL2LMdQN/R7rd81jWSd/mL5EAy2WlBBQ8PVhbRrHHLJ7tUTIYUjiWUyD97SW9erd+WazE8HY0NoGGOILm+uFS3MN6AoIJw7dVTOar9UNbNExJxqYyO/qTbd3K69wLijigzC3blKsLmllqiL0MJlA8B98iG4nbrcQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=w2LHJ56rn0W4/IGr5rFyrfRHb7VboWR2i1p3MUw3Kpw=; b=HxSn0eylkWAUgb8NLevovQm/QlklMDqZPnP2GOCHYwKq8b4jC9cH8pVYFUnvIMf6F8LjCBAf7oQ+olYQRpkJh2C/6rpRAGzJ9QxixXqAxxBHNAfnopNtdpSJ8miHcSZVAFeCo6JEicjFwjLMyGNay82th9ydrgGhwc6vLc00uHLzpNn/UukHam6jrd5heckuCkk/oLTWaz1HolJuN5f+XMp2zlPmF5F6c8eGBoh9y1fHvFITdRdMnsA3T48nMRxoSdyxnd9ERAfwse2OPell0bKDAhhNFG+y79iGOP0n92kuiOAysLOVN4OBjeMa0IK1ZugG0+fFg+Nl52JHmEW6Mg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=w2LHJ56rn0W4/IGr5rFyrfRHb7VboWR2i1p3MUw3Kpw=; b=vzF6ga+DoLSVHqjeUk/hWC6oR8Jh2fxcHOPV9KY8IQ4nEMxsqEm1M1VZY/rbrH1DLUwG0GG9ECTWKf3a2mFjYWZjx0L7kowdj6MY3gEk9boGOmVbtPpBoPvqS1df2wuarbhv3G+C/iC2Am6603j7/FUAcbUUcY+vOLQcQxDibco= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by DB9PR08MB9609.eurprd08.prod.outlook.com (2603:10a6:10:456::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15; Wed, 12 Oct 2022 11:06:32 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::283c:fe2e:699d:2bf]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::283c:fe2e:699d:2bf%4]) with mapi id 15.20.5709.015; Wed, 12 Oct 2022 11:06:32 +0000 Message-ID: <5eb550a4-a0de-9dac-d013-f55ca15a5a8f@arm.com> Date: Wed, 12 Oct 2022 12:06:30 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.2 Subject: Re: [PATCH 2/2] ArmVirtPkg: allow setting Firmware Version from build command line To: Gerd Hoffmann , Oliver Steffen CC: devel@edk2.groups.io, Anthony Perard , Ard Biesheuvel , Jian J Wang , Jiewen Yao , Jordan Justen , Julien Grall , Leif Lindholm , Liming Gao , Ray Ni , Zhichao Gao , Pawel Polawski , "nd@arm.com" References: <20221012073504.511854-1-osteffen@redhat.com> <20221012103930.imhnaniw2ug2fkey@sirius.home.kraxel.org> From: "Sami Mujawar" In-Reply-To: <20221012103930.imhnaniw2ug2fkey@sirius.home.kraxel.org> X-ClientProxiedBy: LO6P265CA0014.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:339::12) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: AS8PR08MB6806:EE_|DB9PR08MB9609:EE_|VE1EUR03FT044:EE_|DU0PR08MB7487:EE_ X-MS-Office365-Filtering-Correlation-Id: 0845ff9a-1bb3-496a-887f-08daac41d848 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 8+JupRD2UJEbhNF1K7a4VODF1RE7LzC9rDnrntVTFu5s6aldzfkblcglyW3Hteg/b9DINx0VIUTSKq01t4XUSHJAL3eaR2VRR9dGjdGr3OMaByo7/xs10utXOMuHXOfk5WaD7P0IzFvd1XHH8XvWaeKR7Ovmc3gpJgVAZl2PPZERhPhQISqC6eyElnscsbleOuQOXSF3g0hv2yrv8hGoxbsTokrgq9rFXfrZkMMKKMFkadCmv4i0zN6b5NMSUjNxdonY6eAJF/ckGKJG0aMCxO0HTHWxrYrn8eOsBUmDwRYFMAfD95kIJ+zZiQPl0b4A7TIX8UabOOkWkSZX09WedN/I3RIdv/D9jMGE8VFOSLoALv5/3VXpMN3ySqSE1ppoqYtKwFYGew/rl2Upk9PlROBQ2WIUQhvXaf6OKN7vT5375sfC5/SwO58gQ7PGKS6aPUkghJuXF9tLz5NQCKi32c5utfYhdmwRxQearOwg5DjlqQC3+WlvDrfLPIHEOPlTgELL63sa/Za1/O6rUvK9nNBZgJMUxx3bA6+bOQtms4GvrXrMAMIuCut1chTMrOAotByMXtZI5YKC+VKOKGygToVrLOjRHceUYWCLrv77eYA7+fpMHF/UZoMgYPgiXOSW8xRrvSaNj8u02gP/Wq+gISgIbd2HyUuikwIR/Vj4C+UL+oKii/i4iil4ZHkg4pGLUMGdnr3Z79RreumWAvIWmfwz8QPmnebr/cQuEELPs8tDlvhzrEDJHSztlR+Rois9ooL/lvbRBXTe+Wv648Q7r1QDJC9HE+bRV+C4zdGI35Q9ewho/6Xdnm5qPoB4vodK X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(376002)(396003)(346002)(39860400002)(136003)(451199015)(6512007)(31686004)(110136005)(316002)(54906003)(478600001)(8676002)(6486002)(38100700002)(53546011)(36756003)(86362001)(31696002)(4326008)(66476007)(6506007)(83380400001)(186003)(2616005)(7416002)(44832011)(66556008)(8936002)(5660300002)(2906002)(66946007)(26005)(41300700001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB9609 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT044.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 174d5190-c448-4c8e-df84-08daac41d1ca X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: NuB3ITzTNNxw1KOmnB53lbWUvsD9W9OTDbbv0F7e/oFTPqTlHLzvfp3MCLn2wEDFFbXHhRsYKVNQtUSSeAwPMFD6OdViLmprw3vp1ywq7la4/pmSQzwc8OpLQHfZwHxxVHd0vq+wNzL4TlYEY1VrOebqBQVGnTzcTtwovCziji9IaeYVXDL6qBCixrt9LGWYIxmufnDW/aTjFdeuP8p7EJgBPyxHkxRiWBqrxk/Rd6T6ziyi3ykK8qaLErIqwrBoUa9MG8Lr/A5mGPXPu8xA6xCQiDHRX7GVk9+vmmssPS7CVRrWStJzoiQF4GWDO293O8Zvgje4jWQMglWdNUJOJZ7wyX1z6tJhASZrPaS1ZbuBrqjkj5D/lR0bGharnBdMZzg3F4uKuzfECyUCalhVmTAtjVLw0k3yIkS/Pjm1sHgmcJ6ebOKb7Rb1/a3+Smzjqhl9zcaKA18rPE0a+f8F3qILzMwd+xINQxqXDuR7OPcl7aJkSvw1FasQ3iQRC1humBpIUFMxkzMjpt3wikYoOUnBVSEoE+pg1z5uWyuazpelwzknk3jBsOTU2keW+0wA9PVdxZSWoJj3idiFmeNFZyQO8E1ZKxfbEcyfs0A8IoMPrsorqsTbu1gy5MJOQZDYxTCCyTxpB2D2DSuUVvwoA9DDNg2kdB4CdgKyc+qZYXUnL07kQAUQ6e6WJKoawJpNEoxHGYzMoGNglQqvw8y0H0cgtzVYguzGJHgBEpyOn5Z4FuQS2GcBKCIlPVtT+CCusF3qzpIlmbWDn/aEddBjc68VkhGYEF7FS7D2wg5ein/bO+3G7PYQclVYK4byS/2A2G9IgKmVvezuoEG4QCkuGQ== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(376002)(346002)(396003)(136003)(451199015)(36840700001)(40470700004)(46966006)(31686004)(53546011)(8936002)(40460700003)(86362001)(316002)(356005)(8676002)(31696002)(70206006)(82310400005)(40480700001)(2616005)(26005)(82740400003)(36756003)(4326008)(81166007)(54906003)(478600001)(6506007)(83380400001)(70586007)(336012)(6486002)(110136005)(41300700001)(186003)(2906002)(44832011)(36860700001)(6512007)(47076005)(5660300002)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2022 11:06:42.5955 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0845ff9a-1bb3-496a-887f-08daac41d848 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT044.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB7487 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Hi Gerd, Please find my response inline marked [SAMI]. Regards, Sami Mujawar On 12/10/2022 11:39 am, Gerd Hoffmann wrote: > On Wed, Oct 12, 2022 at 07:35:23AM +0000, Oliver Steffen wrote: >> Initialize >> gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString >> with with the value of the variable "FIRMWARE_VER" >> in all flavors of ArmVirtPkg. >> >> This behavior is already implemented in ArmVirtXen.dsc. >> It allows specifying the firmware version string on the >> build command line with -D FIRMARE_VER=3D... > I think we need to decide which approach we want support for > setting PcdFirmwareVersionString (and write it down in armvirt/ovmf > readme). > > The options we have are: > > (1) -D "FIRMARE_VER=3D${version}" (needs this patch), or > (2) --pcd "PcdFirmwareVersionString=3DL'${version}\\0'" > > Advantage of (1) is that the build command line is a bit simpler. > > Disadvantage of (1) is that it overrides PcdFirmwareVersionString > even in case FIRMARE_VER is not set on the command line. Which doesn't > make much of a difference today because the default value defined in > MdeModulePkg is just the empty string. In case we set the default > to something more useful (https://edk2.groups.io/g/devel/message/94985) > overriding it is not so nice though ... [SAMI] Thank you for pointing me to the MdeModulePkg patch. I think we could do the following in ArmVirtPkg: ----- diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc index c39e2506a3ea..49e96c9fb91c 100644 --- a/ArmVirtPkg/ArmVirt.dsc.inc +++ b/ArmVirtPkg/ArmVirt.dsc.inc @@ -289,6 +289,10 @@ [PcdsFeatureFlag.AARCH64] =C2=A0=C2=A0 gEfiMdeModulePkgTokenSpaceGuid.PcdInstallAcpiSdtProtocol|TRUE =C2=A0[PcdsFixedAtBuild.common] +!ifdef $(FIRMWARE_VER) + gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"$(FIRMWARE_VER)= " +!endif + =C2=A0=C2=A0 gEfiMdePkgTokenSpaceGuid.PcdMaximumUnicodeStringLength|100000= 0 =C2=A0=C2=A0 gEfiMdePkgTokenSpaceGuid.PcdMaximumAsciiStringLength|1000000 =C2=A0=C2=A0 gEfiMdePkgTokenSpaceGuid.PcdMaximumLinkedListLength|0 ---- With this if -D "FIRMARE_VER=3D${version}" is not provided, the default=20 string definition from MdeModulePkg would be used. Also, since ArmVirt.dsc.inc is included all the platforms in ArmVirtPkg,=20 this change is required only in one place (ArmVirtXen.dsc would need=20 updating though). [/SAMI] > > take care, > Gerd >