From: "Ard Biesheuvel" <ard.biesheuvel@arm.com>
To: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>,
Samer El-Haj-Mahmoud <samer@elhajmahmoud.com>
Cc: Leif Lindholm <leif@nuviainc.com>, Pete Batard <pete@akeo.ie>,
"Andrei Warkentin (awarkentin@vmware.com)"
<awarkentin@vmware.com>, nd <nd@arm.com>
Subject: Re: [edk2-devel] [edk2-platform][PATCH v1 0/4] Platform/RaspberryPi : Enable TFTP shell command
Date: Sun, 19 Apr 2020 16:04:12 +0200 [thread overview]
Message-ID: <5ec33d11-04f9-f1ea-7575-3f646d2653d1@arm.com> (raw)
In-Reply-To: <DB7PR08MB3260BC6535C4DF1D53366E5C90D70@DB7PR08MB3260.eurprd08.prod.outlook.com>
On 4/19/20 4:00 PM, Samer El-Haj-Mahmoud wrote:
>> -----Original Message-----
>> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Ard
>> Biesheuvel via groups.io
>> Sent: Sunday, April 19, 2020 9:34 AM
>> To: Samer El-Haj-Mahmoud <samer@elhajmahmoud.com>;
>> devel@edk2.groups.io
>> Cc: Leif Lindholm <leif@nuviainc.com>; Pete Batard <pete@akeo.ie>; Andrei
>> Warkentin (awarkentin@vmware.com) <awarkentin@vmware.com>
>> Subject: Re: [edk2-devel] [edk2-platform][PATCH v1 0/4] Platform/RaspberryPi
>> : Enable TFTP shell command
>>
>> On 4/19/20 3:04 PM, Samer El-Haj-Mahmoud wrote:
>>> Fix an ASSERT with the TFTP dynamic Shell command on the
>>> RPi3 and RPi4 when running DEBUG builds. Also, enable the command by
>>> default for all builds.
>>>
>>
>> Fixing the ASSERT is fine but I am reluctant to enable this by default.
>> It is a non-standard hack that ARM contributed in the past, and is not covered
>> by the EFI of Shell specifications. If RPi4 is intended to be a showcase for UEFI
>> on ARM done right, we should not enable this at all.
>>
>
> That is OK.
>
> Are you fine just reviewing/pushing the PCD patches (and dropping the enable ones), or want me to send a new series without the enable patches ?
>
No that's fine, I'll just take the first two patches.
next prev parent reply other threads:[~2020-04-19 14:04 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-19 13:04 [edk2-platform][PATCH v1 0/4] Platform/RaspberryPi : Enable TFTP shell command Samer El-Haj-Mahmoud
2020-04-19 13:04 ` [edk2-platform][PATCH v1 1/4] Platform/RaspberryPi/RPi3: Fix TFTP dynamic command initialization Samer El-Haj-Mahmoud
2020-04-19 13:04 ` [edk2-platform][PATCH v1 2/4] Platform/RaspberryPi/RPi4: " Samer El-Haj-Mahmoud
2020-04-19 13:04 ` [edk2-platform][PATCH v1 3/4] Platform/RaspberryPi/RPi3: Enable TFTP command by default Samer El-Haj-Mahmoud
2020-04-19 13:04 ` [edk2-platform][PATCH v1 4/4] Platform/RaspberryPi/RPi4: " Samer El-Haj-Mahmoud
2020-04-19 13:33 ` [edk2-platform][PATCH v1 0/4] Platform/RaspberryPi : Enable TFTP shell command Ard Biesheuvel
2020-04-19 14:00 ` [edk2-devel] " Samer El-Haj-Mahmoud
2020-04-19 14:04 ` Ard Biesheuvel [this message]
2020-04-19 14:19 ` Pete Batard
2020-04-19 19:56 ` Andrei Warkentin
2020-04-19 20:06 ` [edk2-devel] " Pete Batard
2020-04-19 20:21 ` Andrei Warkentin
2020-04-19 20:24 ` Pete Batard
2020-04-19 20:42 ` Andrei Warkentin
[not found] ` <160753416257B0CA.29096@groups.io>
2020-04-19 23:50 ` Andrei Warkentin
2020-04-20 1:03 ` Andrew Fish
2020-04-20 2:41 ` Andrei Warkentin
2020-04-20 6:45 ` Ard Biesheuvel
2020-04-20 11:55 ` Pete Batard
2020-04-20 12:43 ` Ard Biesheuvel
2020-04-20 14:18 ` Pete Batard
2020-04-20 11:23 ` Leif Lindholm
2020-04-20 13:17 ` [edk2-devel] " Samer El-Haj-Mahmoud
2020-04-20 13:24 ` Ard Biesheuvel
2020-04-20 13:30 ` [edk2-devel] " Samer El-Haj-Mahmoud
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ec33d11-04f9-f1ea-7575-3f646d2653d1@arm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox