From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by mx.groups.io with SMTP id smtpd.web11.16831.1587305055062834035
 for <devel@edk2.groups.io>;
 Sun, 19 Apr 2020 07:04:15 -0700
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: ard.biesheuvel@arm.com)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
	by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7D9CE30E;
	Sun, 19 Apr 2020 07:04:14 -0700 (PDT)
Received: from [192.168.1.81] (unknown [172.31.20.19])
	by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6B1423F6CF;
	Sun, 19 Apr 2020 07:04:13 -0700 (PDT)
Subject: Re: [edk2-devel] [edk2-platform][PATCH v1 0/4] Platform/RaspberryPi : Enable TFTP shell command
To: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>,
 "devel@edk2.groups.io" <devel@edk2.groups.io>,
 Samer El-Haj-Mahmoud <samer@elhajmahmoud.com>
Cc: Leif Lindholm <leif@nuviainc.com>, Pete Batard <pete@akeo.ie>,
 "Andrei Warkentin (awarkentin@vmware.com)" <awarkentin@vmware.com>,
 nd <nd@arm.com>
References: <20200419130417.3298-1-samer@elhajmahmoud.com>
 <8d59e616-9910-4935-2e1f-5da75fc1d34a@arm.com>
 <DB7PR08MB3260BC6535C4DF1D53366E5C90D70@DB7PR08MB3260.eurprd08.prod.outlook.com>
From: "Ard Biesheuvel" <ard.biesheuvel@arm.com>
Message-ID: <5ec33d11-04f9-f1ea-7575-3f646d2653d1@arm.com>
Date: Sun, 19 Apr 2020 16:04:12 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.7.0
MIME-Version: 1.0
In-Reply-To: <DB7PR08MB3260BC6535C4DF1D53366E5C90D70@DB7PR08MB3260.eurprd08.prod.outlook.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 4/19/20 4:00 PM, Samer El-Haj-Mahmoud wrote:
>> -----Original Message-----
>> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Ard
>> Biesheuvel via groups.io
>> Sent: Sunday, April 19, 2020 9:34 AM
>> To: Samer El-Haj-Mahmoud <samer@elhajmahmoud.com>;
>> devel@edk2.groups.io
>> Cc: Leif Lindholm <leif@nuviainc.com>; Pete Batard <pete@akeo.ie>; Andrei
>> Warkentin (awarkentin@vmware.com) <awarkentin@vmware.com>
>> Subject: Re: [edk2-devel] [edk2-platform][PATCH v1 0/4] Platform/RaspberryPi
>> : Enable TFTP shell command
>>
>> On 4/19/20 3:04 PM, Samer El-Haj-Mahmoud wrote:
>>> Fix an ASSERT with the TFTP dynamic Shell command on the
>>> RPi3 and RPi4 when running DEBUG builds. Also, enable the command by
>>> default for all builds.
>>>
>>
>> Fixing the ASSERT is fine but I am reluctant to enable this by default.
>> It is a non-standard hack that ARM contributed in the past, and is not covered
>> by the EFI of Shell specifications. If RPi4 is intended to be a showcase for UEFI
>> on ARM done right, we should not enable this at all.
>>
> 
> That is OK.
> 
> Are you fine just reviewing/pushing the PCD patches (and dropping the enable ones), or want me to send a new series without the enable patches ?
> 

No that's fine, I'll just take the first two patches.