[PATCH v1 1/1] BaseTools/GenFds: Verify binaries all the time

[PATCH v1 1/1] BaseTools/GenFds: Verify binaries all the time

[Jaben Carsey]

Currently, Basetools only verifies Binary file list existance for default ARCH,
but it should verify for a specified ARCH the same.
Also, dont save the list to a unused variable.

Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
---
 BaseTools/Source/Python/GenFds/AprioriSection.py | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/BaseTools/Source/Python/GenFds/AprioriSection.py b/BaseTools/Source/Python/GenFds/AprioriSection.py
index 7196f7f2c753..70aa150799a7 100644
--- a/BaseTools/Source/Python/GenFds/AprioriSection.py
+++ b/BaseTools/Source/Python/GenFds/AprioriSection.py
@@ -89,12 +89,10 @@ class AprioriSection (AprioriSectionClassObject):
                     Inf = GenFdsGlobalVariable.WorkSpace.BuildObject[PathClass(InfFileName, GenFdsGlobalVariable.WorkSpaceDir), TAB_COMMON, GenFdsGlobalVariable.TargetName, GenFdsGlobalVariable.ToolChainTag]
                     Guid = Inf.Guid
 
-                    self.BinFileList = Inf.Module.Binaries
-                    if self.BinFileList == []:
-                        EdkLogger.error("GenFds", RESOURCE_NOT_AVAILABLE,
-                                        "INF %s not found in build ARCH %s!" \
-                                        % (InfFileName, GenFdsGlobalVariable.ArchList))
-
+                if not Inf.Module.Binaries:
+                    EdkLoggerError("GenFds", RESOURCE_NOT_AVAILABLE,
+                                    "INF %s not found in build ARCH %s!" \
+                                    % (InfFileName, GenFdsGlobalVariable.ArchList))
 
             GuidPart = Guid.split('-')
             Buffer.write(pack('I', long(GuidPart[0], 16)))
-- 
2.16.2.windows.1

Re: [PATCH v1 1/1] BaseTools/GenFds: Verify binaries all the time

[Carsey, Jaben]

I have found a related issue.  Please ignore this patch.

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Jaben Carsey
> Sent: Thursday, September 06, 2018 11:31 AM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming <liming.gao@intel.com>
> Subject: [edk2] [PATCH v1 1/1] BaseTools/GenFds: Verify binaries all the time
> 
> Currently, Basetools only verifies Binary file list existance for default ARCH,
> but it should verify for a specified ARCH the same.
> Also, dont save the list to a unused variable.
> 
> Cc: Yonghong Zhu <yonghong.zhu@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
> ---
>  BaseTools/Source/Python/GenFds/AprioriSection.py | 10 ++++------
>  1 file changed, 4 insertions(+), 6 deletions(-)
> 
> diff --git a/BaseTools/Source/Python/GenFds/AprioriSection.py
> b/BaseTools/Source/Python/GenFds/AprioriSection.py
> index 7196f7f2c753..70aa150799a7 100644
> --- a/BaseTools/Source/Python/GenFds/AprioriSection.py
> +++ b/BaseTools/Source/Python/GenFds/AprioriSection.py
> @@ -89,12 +89,10 @@ class AprioriSection (AprioriSectionClassObject):
>                      Inf =
> GenFdsGlobalVariable.WorkSpace.BuildObject[PathClass(InfFileName,
> GenFdsGlobalVariable.WorkSpaceDir), TAB_COMMON,
> GenFdsGlobalVariable.TargetName, GenFdsGlobalVariable.ToolChainTag]
>                      Guid = Inf.Guid
> 
> -                    self.BinFileList = Inf.Module.Binaries
> -                    if self.BinFileList == []:
> -                        EdkLogger.error("GenFds", RESOURCE_NOT_AVAILABLE,
> -                                        "INF %s not found in build ARCH %s!" \
> -                                        % (InfFileName, GenFdsGlobalVariable.ArchList))
> -
> +                if not Inf.Module.Binaries:
> +                    EdkLoggerError("GenFds", RESOURCE_NOT_AVAILABLE,
> +                                    "INF %s not found in build ARCH %s!" \
> +                                    % (InfFileName, GenFdsGlobalVariable.ArchList))
> 
>              GuidPart = Guid.split('-')
>              Buffer.write(pack('I', long(GuidPart[0], 16)))
> --
> 2.16.2.windows.1
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel