From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web09.4492.1663832184050949725 for ; Thu, 22 Sep 2022 00:36:24 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=W51KsX2z; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: rodrigo.gonzalez.del.cueto@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1663832184; x=1695368184; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=f2J7WtGoKGeaKd78gbtobgQcOa0Q3Qk2aCtvSIoa3Eo=; b=W51KsX2z/+ZSYMb4lxy+ZYMOIaHXfq0oo91zrrxSr7SgtegzG2YcKDPp fvC+RaVkEx4+/OK3E8JlI7I92RSDnWDh0xA6k0+oMaIPhoWiJZF2/GZz7 HpnmeSFgPerPljTCfKJ9bJ2hKaWpeXGCoP0B8H8eA4IK/R+5f7zvVZjBK 2WeN00WwRY3Zekq43M1rgOdh6xy3kHc1poqHP6gSqPDSASrFCd5nJ65Pe b1nEbbPHFBOHWfnL8lVOWBwbTXdjMFW1ygyx1tZcHlT5uAKeaAxBOVLXt nsDkjV+WGUl3QYIJpGGTKyBub803yyq/v9wbXquriBiW8s3+N/uoGNQ/V w==; X-IronPort-AV: E=McAfee;i="6500,9779,10477"; a="283275811" X-IronPort-AV: E=Sophos;i="5.93,335,1654585200"; d="scan'208";a="283275811" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Sep 2022 00:36:21 -0700 X-IronPort-AV: E=Sophos;i="5.93,335,1654585200"; d="scan'208";a="621993658" Received: from rodrigog-mobl.amr.corp.intel.com ([10.254.12.189]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Sep 2022 00:36:21 -0700 From: "Rodrigo Gonzalez del Cueto" To: devel@edk2.groups.io Cc: "Gonzalez Del Cueto, Rodrigo" , Jiewen Yao , Jian J Wang Subject: [PATCH] SecurityPkg: Remove enforcement of final GoIdle transition for CRB commands Date: Thu, 22 Sep 2022 00:35:36 -0700 Message-Id: <5f134d299f44f162f7ae7537a0f8c6783210fbea.1663832124.git.rodrigo.gonzalez.del.cueto@intel.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4077 Following the design described in the TCG specification, the driver implementation of the CRB protocol does not require enforcing completing the transition to goIdle at the end of a command sequence. Signed-off-by: "Gonzalez Del Cueto, Rodrigo" Cc: Jiewen Yao Cc: Jian J Wang --- SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Ptp.c | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Ptp.c b/SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Ptp.c index 840265292a..1f9ac5ab5a 100644 --- a/SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Ptp.c +++ b/SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Ptp.c @@ -381,19 +381,6 @@ GoIdle_Exit: // MmioWrite32 ((UINTN)&CrbReg->CrbControlRequest, PTP_CRB_CONTROL_AREA_REQUEST_GO_IDLE); - // - // Only enforce Idle state transition if execution fails when CRBIdleBypass==1 - // Leave regular Idle delay at the beginning of next command execution - // - if (GetCachedIdleByPass () == 1) { - Status = PtpCrbWaitRegisterBits ( - &CrbReg->CrbControlStatus, - PTP_CRB_CONTROL_AREA_STATUS_TPM_IDLE, - 0, - PTP_TIMEOUT_C - ); - } - return Status; } -- 2.25.1