From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (NAM12-DM6-obe.outbound.protection.outlook.com [40.107.243.45]) by mx.groups.io with SMTP id smtpd.web08.31202.1660754382670296910 for ; Wed, 17 Aug 2022 09:39:42 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nvidia.com header.s=selector2 header.b=l+Z+pfZg; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: nvidia.com, ip: 40.107.243.45, mailfrom: jbrasen@nvidia.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aVMETyuc+F2IabVxd3gG6Vz+3bqHD5jsLRNG8kF6CgDi5mAgVmtlZgtcxogn0OIU0JV61iT4Vn41qjmSG9ZTVg5vPU3tib+FcstHgv1ZT+m7X56OKYzAab0f0E0vYP4AJoAAMAiQQ0+vddfLY1TVxqG0sdUfVfpK8SaezAt4gkOaEUwngRDAHaFezivqktdqOj3e1AnzycHdJpeTIjHywjXex881Fb0Q6Sam4NWjzeq7yWGvD6a+Yck/1nCqUutPiehnPBhfe3ZNJwqm9vtdQVwejKK6M0oGeWzlCOeX6grJ+BkESkTQB1/Euc1qI2tyaoz75mUtQKCisRqWp3zdcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=n3Ooswmo5oIRQ8HJOQRM7I6nfBcHbLyTeG02/6rmePs=; b=EpWdP9zqlZZOGNMPn7R4TBNXvpXvpzUSUlQRhAtFrjz0e0xbT4/AENGG4ultFS1h/O/1492iBm/e0YIQ7ZVz7ollvp++uI6rE49/p2BGIwgQ1Y9cOnCJwWGYxI56WlW8dh+fvPE4yjjCQbIewj5aKPWc+ItYnvPJt8eWOp7nrc79DqpnqKxIcGacz0TiTZIM9TQmZ2yLSfmgPbDCljSCFCEWGEKJIhMNtmiUhcdMvlo7I2ueTM+dV2JjtYjx66nPqWv1NGOsvKcO7m/naLt2OrNFGamB4sSGPIBYJRalNGjQ0i9xBx2sla0nQnJ6QAWKSaIKAMj5IV+yUazld6AxGA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 12.22.5.238) smtp.rcpttodomain=arm.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=n3Ooswmo5oIRQ8HJOQRM7I6nfBcHbLyTeG02/6rmePs=; b=l+Z+pfZgEor47BDJ+q/Hau9S/ouQYpWC5l1ivGy4Nm8ssXGKqcNIf7IFIjm7U1UKNGNGajuwATZYIn0ebQ2RvbDCM38tMCoV4k2jIzeBbY2gfYMB0tPi7NJWDqShSZhAsshhi20C+FhRLFvLd6SzKgqX5WFYxeqNjoHU2xy2efmDJjjEqCGXgkMBK95lGK9SRRxCO1jGwcPvfjzS2dEy0rk6K5KV39j5Z2+7ToWzK+EkUFRUA/1gVEcM4sCQFUTdWDRAve1UQrZRXbVUBZUBpHnkXLBJAJox9OikFxIZqOgT6Aqayb3sbGlzoVlZgFL3xpKRAxQPg0lxrswxYnnPtA== Received: from DM6PR02CA0150.namprd02.prod.outlook.com (2603:10b6:5:332::17) by DS0PR12MB6655.namprd12.prod.outlook.com (2603:10b6:8:d0::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5525.10; Wed, 17 Aug 2022 16:39:40 +0000 Received: from DM6NAM11FT054.eop-nam11.prod.protection.outlook.com (2603:10b6:5:332:cafe::92) by DM6PR02CA0150.outlook.office365.com (2603:10b6:5:332::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5525.16 via Frontend Transport; Wed, 17 Aug 2022 16:39:40 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 12.22.5.238) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 12.22.5.238 as permitted sender) receiver=protection.outlook.com; client-ip=12.22.5.238; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (12.22.5.238) by DM6NAM11FT054.mail.protection.outlook.com (10.13.173.95) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.5546.15 via Frontend Transport; Wed, 17 Aug 2022 16:39:40 +0000 Received: from rnnvmail202.nvidia.com (10.129.68.7) by DRHQMAIL105.nvidia.com (10.27.9.14) with Microsoft SMTP Server (TLS) id 15.0.1497.38; Wed, 17 Aug 2022 16:39:40 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by rnnvmail202.nvidia.com (10.129.68.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.29; Wed, 17 Aug 2022 09:39:39 -0700 Received: from ed7fa55790ac.nvidia.com (10.127.8.9) by mail.nvidia.com (10.129.68.8) with Microsoft SMTP Server id 15.2.986.29 via Frontend Transport; Wed, 17 Aug 2022 09:39:38 -0700 From: "Jeff Brasen" To: CC: , , , , Jeff Brasen Subject: [PATCH v3] DynamicTablesPkg: Add support to build _DSD Date: Wed, 17 Aug 2022 10:39:39 -0600 Message-ID: <5f525aa26bd4fcd82ed5498569830f0882e06a4e.1660754335.git.jbrasen@nvidia.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-NVConfidentiality: public Return-Path: jbrasen@nvidia.com X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 16def8bb-fac6-4b5d-152e-08da806f14fb X-MS-TrafficTypeDiagnostic: DS0PR12MB6655:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qK6fZOerwlohES3X4Wvsen49wdIxouM7yO8TBWlKJpplHienw4IrSrC71xuGy2mXivS8VcWoQvlL7C00lrBUbhwDN1m/I2LGe0a8zz1BRxxWql5QvVflaFiUWtTTUTMrlYPM8fcbw9E0+SS+02gaQum8hhePSa6r2pzca8FD7k9ORt1iGJyTA8S15bsLN8JgSBoeY+C1o5lwKCUeV5XT0Gx559Iu3Oa6MhQeWWwaGtmU+hfJRGnjNk/UojzOgan6kU6K3NS0XAbs5hxO1LXoieSJC3yPRHvp86ss24PiS0nBIjrNiF/QRPwpv0Lx30GqV4yAkJN5hRblvh72UpyPcVp5+rRXeIQl+Ib+qEYjxZv9i9tzmwdOt9mxy9s7VwTroTUsc2UNJrI4tglnBn1QdputQkj2jkppWtY6SLVIUylEooGKoESNDo5q+bw/ysUwLYZL+RdOytTjbiiziCxKScrvIFXuVoa81D1X4hY5YNUC9YiqYw+y83zqhIgcbX3oJZav1HKPlLL4bSfsYrSxN7VmAoqKC7k/NvP6oFZo6EKUGumWEbE+EiUc6sTUMAlhlZrjz+Bp1tGTM94Eh24K0FJyJGa6fx2J9H7Zmfk69dEyPT0QyBpfxL/p7qBeuJqdqpEB/LglFVi4BLshc8rBU6NegtrvZBK57RBpCa69acMm4aBoxUVK5rB6mnGesT0al2slvgvybzCdLH1u05HirbtU+K5Rm6mPAvGNzLohTsSvUHk7lHf5GKgz6Bzw023rGTVoeQTn8JRvUcYk9gViCMgfTWF65Tz6CDMLncXck30wB11tC97S4QbzMzZ5abByN4xF/gi74kEghmo37D/abDZx7WwAKLN+RUmXbhxC3Y7vA/ZgtQlcs1W5qzHFLZyr2AXkF+KQu+CjKiw9+ANHABXqB/dYpU0rFHGpPhflgSg= X-Forefront-Antispam-Report: CIP:12.22.5.238;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:InfoNoRecords;CAT:NONE;SFS:(13230016)(4636009)(136003)(39860400002)(376002)(396003)(346002)(40470700004)(46966006)(36840700001)(336012)(186003)(107886003)(81166007)(426003)(356005)(2616005)(82740400003)(47076005)(36860700001)(70206006)(5660300002)(8936002)(4326008)(70586007)(8676002)(478600001)(83380400001)(7696005)(40480700001)(40460700003)(966005)(26005)(41300700001)(2906002)(82310400005)(86362001)(54906003)(6916009)(316002)(19627235002)(36756003)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Aug 2022 16:39:40.6508 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 16def8bb-fac6-4b5d-152e-08da806f14fb X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[12.22.5.238];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT054.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB6655 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain Add APIs needed to build _DSD with different UUIDs.=0D This is per ACPI specification 6.4 s6.2.5.=0D =0D Adds support for building data packages with format=0D Package {"Name", Integer}=0D =0D Signed-off-by: Jeff Brasen =0D ---=0D .../Include/Library/AmlLib/AmlLib.h | 60 +++++=0D .../Common/AmlLib/CodeGen/AmlCodeGen.c | 254 ++++++++++++++++++=0D 2 files changed, 314 insertions(+)=0D =0D diff --git a/DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h b/DynamicTabl= esPkg/Include/Library/AmlLib/AmlLib.h=0D index 6f214c0dfa..18013f3c0c 100644=0D --- a/DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h=0D +++ b/DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h=0D @@ -1280,6 +1280,66 @@ AmlAddLpiState (=0D IN AML_OBJECT_NODE_HANDLE LpiNode=0D );=0D =0D +/** AML code generation for a _DSD device data object.=0D +=0D + AmlAddDeviceDataDescriptorPackage (Uuid, DsdNode, PackageNode) is=0D + equivalent of the following ASL code:=0D + ToUUID(Uuid),=0D + Package () {}=0D +=0D + Cf ACPI 6.4 specification, s6.2.5 "_DSD (Device Specific Data)".=0D +=0D + _DSD (Device Specific Data) Implementation Guide=0D + https://github.com/UEFI/DSD-Guide=0D + Per s3. "'Well-Known _DSD UUIDs and Data Structure Formats'"=0D + If creating a Device Properties data then UUID daffd814-6eba-4d8c-8a91-b= c9bbf4aa301 should be used.=0D +=0D + @ingroup CodeGenApis=0D +=0D + @param [in] Uuid The Uuid of the descriptor to be created=0D + @param [in] DsdNode Node of the DSD Package.=0D + @param [out] PackageNode If success, contains the created package nod= e.=0D +=0D + @retval EFI_SUCCESS Success.=0D + @retval EFI_INVALID_PARAMETER Invalid parameter.=0D + @retval EFI_OUT_OF_RESOURCES Failed to allocate memory.=0D +**/=0D +EFI_STATUS=0D +EFIAPI=0D +AmlAddDeviceDataDescriptorPackage (=0D + IN CONST EFI_GUID *Uuid,=0D + IN AML_OBJECT_NODE_HANDLE DsdNode,=0D + OUT AML_OBJECT_NODE_HANDLE *PackageNode=0D + );=0D +=0D +/** AML code generation to add a package with a name and value,=0D + to a parent package.=0D + This is useful for build the _DSD package but can be used in other cas= es.=0D +=0D + AmlAddNameValuePackage ("Name", Value, PackageNode) is=0D + equivalent of the following ASL code:=0D + Package (2) {"Name", Value}=0D +=0D + Cf ACPI 6.4 specification, s6.2.5 "_DSD (Device Specific Data)".=0D +=0D + @ingroup CodeGenApis=0D +=0D + @param [in] Name String to place in first entry of package=0D + @param [in] Value Integer to place in second entry of package= =0D + @param [in] PackageNode Package to add new sub package to.=0D +=0D + @retval EFI_SUCCESS Success.=0D + @retval EFI_INVALID_PARAMETER Invalid parameter.=0D + @retval EFI_OUT_OF_RESOURCES Failed to allocate memory.=0D +**/=0D +EFI_STATUS=0D +EFIAPI=0D +AmlAddNameIntegerPackage (=0D + IN CHAR8 *Name,=0D + IN UINT64 Value,=0D + IN AML_OBJECT_NODE_HANDLE PackageNode=0D + );=0D +=0D // DEPRECATED APIS=0D #ifndef DISABLE_NEW_DEPRECATED_INTERFACES=0D =0D diff --git a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c b/= DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c=0D index e51d2dd7f0..cf92e7aee7 100644=0D --- a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c=0D +++ b/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c=0D @@ -2600,3 +2600,257 @@ error_handler:=0D =0D return Status;=0D }=0D +=0D +/** AML code generation for a _DSD device data object.=0D +=0D + AmlAddDeviceDataDescriptorPackage (Uuid, DsdNode, PackageNode) is=0D + equivalent of the following ASL code:=0D + ToUUID(Uuid),=0D + Package () {}=0D +=0D + Cf ACPI 6.4 specification, s6.2.5 "_DSD (Device Specific Data)".=0D +=0D + _DSD (Device Specific Data) Implementation Guide=0D + https://github.com/UEFI/DSD-Guide=0D + Per s3. "'Well-Known _DSD UUIDs and Data Structure Formats'"=0D + If creating a Device Properties data then UUID daffd814-6eba-4d8c-8a91-b= c9bbf4aa301 should be used.=0D +=0D + @ingroup CodeGenApis=0D +=0D + @param [in] Uuid The Uuid of the descriptor to be created=0D + @param [in] DsdNode Node of the DSD Package.=0D + @param [out] PackageNode If success, contains the created package nod= e.=0D +=0D + @retval EFI_SUCCESS Success.=0D + @retval EFI_INVALID_PARAMETER Invalid parameter.=0D + @retval EFI_OUT_OF_RESOURCES Failed to allocate memory.=0D +**/=0D +EFI_STATUS=0D +EFIAPI=0D +AmlAddDeviceDataDescriptorPackage (=0D + IN CONST EFI_GUID *Uuid,=0D + IN AML_OBJECT_NODE_HANDLE DsdNode,=0D + OUT AML_OBJECT_NODE_HANDLE *PackageNode=0D + )=0D +{=0D + EFI_STATUS Status;=0D + AML_OBJECT_NODE *UuidNode;=0D + AML_DATA_NODE *UuidDataNode;=0D + AML_OBJECT_NODE_HANDLE DsdEntryList;=0D +=0D + if ((Uuid =3D=3D NULL) ||=0D + (PackageNode =3D=3D NULL) ||=0D + (AmlGetNodeType ((AML_NODE_HANDLE)DsdNode) !=3D EAmlNodeObject) ||=0D + (!AmlNodeHasOpCode (DsdNode, AML_NAME_OP, 0)) ||=0D + !AmlNameOpCompareName (DsdNode, "_DSD"))=0D + {=0D + ASSERT_EFI_ERROR (EFI_INVALID_PARAMETER);=0D + return EFI_INVALID_PARAMETER;=0D + }=0D +=0D + // Get the Package object node of the _DSD node,=0D + // which is the 2nd fixed argument (i.e. index 1).=0D + DsdEntryList =3D (AML_OBJECT_NODE_HANDLE)AmlGetFixedArgument (=0D + DsdNode,=0D + EAmlParseIndexTerm1=0D + );=0D + if ((DsdEntryList =3D=3D NULL) = ||=0D + (AmlGetNodeType ((AML_NODE_HANDLE)DsdEntryList) !=3D EAmlNodeObject)= ||=0D + (!AmlNodeHasOpCode (DsdEntryList, AML_PACKAGE_OP, 0)))=0D + {=0D + ASSERT_EFI_ERROR (EFI_INVALID_PARAMETER);=0D + return EFI_INVALID_PARAMETER;=0D + }=0D +=0D + *PackageNode =3D NULL;=0D + UuidDataNode =3D NULL;=0D +=0D + Status =3D AmlCodeGenBuffer (NULL, 0, &UuidNode);=0D + if (EFI_ERROR (Status)) {=0D + ASSERT_EFI_ERROR (Status);=0D + return Status;=0D + }=0D +=0D + Status =3D AmlCreateDataNode (=0D + EAmlNodeDataTypeRaw,=0D + (CONST UINT8 *)Uuid,=0D + sizeof (EFI_GUID),=0D + &UuidDataNode=0D + );=0D + if (EFI_ERROR (Status)) {=0D + ASSERT_EFI_ERROR (Status);=0D + goto error_handler;=0D + }=0D +=0D + Status =3D AmlVarListAddTail (=0D + (AML_NODE_HEADER *)UuidNode,=0D + (AML_NODE_HEADER *)UuidDataNode=0D + );=0D + if (EFI_ERROR (Status)) {=0D + ASSERT_EFI_ERROR (Status);=0D + goto error_handler;=0D + }=0D +=0D + UuidDataNode =3D NULL;=0D +=0D + // Append to the list of _DSD entries.=0D + Status =3D AmlVarListAddTail (=0D + (AML_NODE_HANDLE)DsdEntryList,=0D + (AML_NODE_HANDLE)UuidNode=0D + );=0D + if (EFI_ERROR (Status)) {=0D + ASSERT_EFI_ERROR (Status);=0D + goto error_handler;=0D + }=0D +=0D + Status =3D AmlCodeGenPackage (PackageNode);=0D + if (EFI_ERROR (Status)) {=0D + ASSERT_EFI_ERROR (Status);=0D + goto error_handler_detach;=0D + }=0D +=0D + // Append to the list of _DSD entries.=0D + Status =3D AmlVarListAddTail (=0D + (AML_NODE_HANDLE)DsdEntryList,=0D + (AML_NODE_HANDLE)*PackageNode=0D + );=0D + if (EFI_ERROR (Status)) {=0D + ASSERT_EFI_ERROR (Status);=0D + goto error_handler_detach;=0D + }=0D +=0D + return Status;=0D +=0D +error_handler_detach:=0D + if (UuidNode !=3D NULL) {=0D + AmlDetachNode ((AML_NODE_HANDLE)UuidNode);=0D + }=0D +=0D +error_handler:=0D + if (UuidNode !=3D NULL) {=0D + AmlDeleteTree ((AML_NODE_HANDLE)UuidNode);=0D + }=0D +=0D + if (*PackageNode !=3D NULL) {=0D + AmlDeleteTree ((AML_NODE_HANDLE)*PackageNode);=0D + *PackageNode =3D NULL;=0D + }=0D +=0D + if (UuidDataNode !=3D NULL) {=0D + AmlDeleteTree ((AML_NODE_HANDLE)UuidDataNode);=0D + }=0D +=0D + return Status;=0D +}=0D +=0D +/** AML code generation to add a package with a name and value,=0D + to a parent package.=0D + This is useful for build the _DSD package but can be used in other cas= es.=0D +=0D + AmlAddNameValuePackage ("Name", Value, PackageNode) is=0D + equivalent of the following ASL code:=0D + Package (2) {"Name", Value}=0D +=0D + Cf ACPI 6.4 specification, s6.2.5 "_DSD (Device Specific Data)".=0D +=0D + @ingroup CodeGenApis=0D +=0D + @param [in] Name String to place in first entry of package=0D + @param [in] Value Integer to place in second entry of package= =0D + @param [in] PackageNode Package to add new sub package to.=0D +=0D + @retval EFI_SUCCESS Success.=0D + @retval EFI_INVALID_PARAMETER Invalid parameter.=0D + @retval EFI_OUT_OF_RESOURCES Failed to allocate memory.=0D +**/=0D +EFI_STATUS=0D +EFIAPI=0D +AmlAddNameIntegerPackage (=0D + IN CHAR8 *Name,=0D + IN UINT64 Value,=0D + IN AML_OBJECT_NODE_HANDLE PackageNode=0D + )=0D +{=0D + EFI_STATUS Status;=0D + AML_OBJECT_NODE *NameNode;=0D + AML_OBJECT_NODE *ValueNode;=0D + AML_OBJECT_NODE *NewPackageNode;=0D +=0D + if ((Name =3D=3D NULL) ||=0D + (AmlGetNodeType ((AML_NODE_HANDLE)PackageNode) !=3D EAmlNodeObject) = ||=0D + (!AmlNodeHasOpCode (PackageNode, AML_PACKAGE_OP, 0)))=0D + {=0D + ASSERT_EFI_ERROR (EFI_INVALID_PARAMETER);=0D + return EFI_INVALID_PARAMETER;=0D + }=0D +=0D + NameNode =3D NULL;=0D + ValueNode =3D NULL;=0D +=0D + // The new package entry.=0D + Status =3D AmlCodeGenPackage (&NewPackageNode);=0D + if (EFI_ERROR (Status)) {=0D + ASSERT_EFI_ERROR (Status);=0D + return Status;=0D + }=0D +=0D + Status =3D AmlCodeGenString (Name, &NameNode);=0D + if (EFI_ERROR (Status)) {=0D + ASSERT_EFI_ERROR (Status);=0D + goto error_handler;=0D + }=0D +=0D + Status =3D AmlVarListAddTail (=0D + (AML_NODE_HANDLE)NewPackageNode,=0D + (AML_NODE_HANDLE)NameNode=0D + );=0D + if (EFI_ERROR (Status)) {=0D + ASSERT_EFI_ERROR (Status);=0D + goto error_handler;=0D + }=0D +=0D + NameNode =3D NULL;=0D +=0D + Status =3D AmlCodeGenInteger (Value, &ValueNode);=0D + if (EFI_ERROR (Status)) {=0D + ASSERT_EFI_ERROR (Status);=0D + goto error_handler;=0D + }=0D +=0D + Status =3D AmlVarListAddTail (=0D + (AML_NODE_HANDLE)NewPackageNode,=0D + (AML_NODE_HANDLE)ValueNode=0D + );=0D + if (EFI_ERROR (Status)) {=0D + ASSERT_EFI_ERROR (Status);=0D + goto error_handler;=0D + }=0D +=0D + ValueNode =3D NULL;=0D +=0D + Status =3D AmlVarListAddTail (=0D + (AML_NODE_HANDLE)PackageNode,=0D + (AML_NODE_HANDLE)NewPackageNode=0D + );=0D + if (EFI_ERROR (Status)) {=0D + ASSERT_EFI_ERROR (Status);=0D + goto error_handler;=0D + }=0D +=0D + return Status;=0D +=0D +error_handler:=0D + if (NewPackageNode !=3D NULL) {=0D + AmlDeleteTree ((AML_NODE_HANDLE)NewPackageNode);=0D + }=0D +=0D + if (NameNode !=3D NULL) {=0D + AmlDeleteTree ((AML_NODE_HANDLE)NameNode);=0D + }=0D +=0D + if (ValueNode !=3D NULL) {=0D + AmlDeleteTree ((AML_NODE_HANDLE)ValueNode);=0D + }=0D +=0D + return Status;=0D +}=0D -- =0D 2.25.1=0D =0D