From: "Laszlo Ersek" <lersek@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>, devel@edk2.groups.io
Cc: Leif Lindholm <leif.lindholm@linaro.org>,
Michael D Kinney <michael.d.kinney@intel.com>,
Andrew Fish <afish@apple.com>
Subject: Re: [PATCH v3 00/32] .mailmap: Add mailmap file to have a cleaner git history
Date: Mon, 6 Jan 2020 11:41:49 +0100 [thread overview]
Message-ID: <5f6d5901-9c19-f5b2-08ec-f7482d868b6b@redhat.com> (raw)
In-Reply-To: <69a63257-d4b7-a715-2db2-457376dd45de@redhat.com>
On 01/03/20 14:56, Philippe Mathieu-Daudé wrote:
> On 1/3/20 2:48 PM, Laszlo Ersek wrote:
>> Apparently, there is a patch that
>> prevents the series from being merged? Which one?
>
> This comment was about patch 13/32, but Jiewen Yao already reviewed
> it,
OK, thanks.
> so this series is fully reviewed by each developer.
I've now tried applying this series locally (for a github.com pull
request). But git-am fails, on patch#6 ("corrupted patch").
I've checked the patch email (as saved from Thunderbird) and I can see
it uses quoted-printable transfer encoding. That has basically never
worked with edk2. Can you please send a v4, with 8-bit encoding?
Please see:
[edk2-devel] [PATCH]
BaseTools/Scripts: Add sendemail.transferEncoding to SetupGit.py
https://edk2.groups.io/g/devel/message/52323
http://mid.mail-archive.com/02A34F284D1DA44BB705E61F7180EF0AB5C64C6F@ORSMSX114.amr.corp.intel.com
>> Can you please monitor the remaining feedback for this series? If
>> everyone is happy with the v3 updates, and you determine that the
>> patch set is fully reviewed, I can help pick up the new tags, and
>> merge the series.
>
> Since the change is a one-line, I'd prefer avoid respining the whole
> series.
I think you mean the change is a one-liner *for a commit message*
(namely, Jiewen's R-b).
I would normally agree (I'd just pick up that R-b from the list), but
again, I can't apply the v3 patches in the first place.
> IMHO the series is ready for step #4 "stewards go through the backlog,
> and decide one by one whether, for person X, the proposed mappings are
> cross-domain or not, and ACK or NACK" which I don't really get.
> I suppose this will be resolved in the open on the mailing list, so
> individuals will get notified their patch got refused.
Let me quote the original suggestion in-line, from here:
https://edk2.groups.io/g/devel/message/51906
http://mid.mail-archive.com/9e212952-a114-57d0-9880-6686edc4d8ae@redhat.com
On 12/06/19 13:23, Laszlo Ersek wrote:
> - Collect feedback (from individual reviewers / contributors) for one
> or two weeks
>
> - Accept cross-domain mappings in any patch where the person subject
> to the patch is ACKing the patch from the mapped-to (i.e. "current")
> email address. This is now a *lot* easier to do, because the patch
> series is structured by person.
>
> - After one or two weeks, push all the patches that have been approved
> like explained above.
This is where we are now. We're about to push the patches with the
direct contributor approvals.
This covers 32 patches (v3) out of your original 105 (v2).
> - Repost the rest of the series, CC'd solely to the stewards. We will
> then have to go through the backlog, and decide one by one whether,
> for person X, the proposed mappings are cross-domain or not, and ACK
> or NACK accordingly.
This is "step 4", and for that, you should please post the *rest* of the
patches: approximately 105-32 = 73 patches.
That is the "backlog". The idea is that the stewards should review
those, because we should be permitted to add email mappings even for
such contributors that do not personally comment on the proposed
mappings, as long as those mappings are not cross-domain.
>
> - Push the second round, drop the rest for good.
And here the "rest" (to be dropped for good) stands for such patches
that even the stewards don't approve (because the mappings appear
cross-domain, which cannot be approved without direct contributor
feedback).
Thanks!
Laszlo
next prev parent reply other threads:[~2020-01-06 10:41 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-02 19:23 [PATCH v3 00/32] .mailmap: Add mailmap file to have a cleaner git history Philippe Mathieu-Daudé
2020-01-02 19:23 ` [PATCH v3 01/32] .mailmap: Add a stub with documentation Philippe Mathieu-Daudé
2020-01-02 19:23 ` [PATCH v3 02/32] .mailmap: Add an entry for Aaron Li Philippe Mathieu-Daudé
2020-01-02 19:23 ` [PATCH v3 03/32] .mailmap: Add an entry for Antoine Cœur Philippe Mathieu-Daudé
2020-01-02 19:23 ` [PATCH v3 04/32] .mailmap: Add an entry for Ard Biesheuvel Philippe Mathieu-Daudé
2020-01-02 19:23 ` [PATCH v3 05/32] .mailmap: Add an entry for Ashley DeSimone Philippe Mathieu-Daudé
2020-01-02 19:23 ` [PATCH v3 06/32] .mailmap: Add an entry for Baraneedharan Anbazhagan Philippe Mathieu-Daudé
2020-01-02 19:23 ` [PATCH v3 07/32] .mailmap: Add an entry for Chasel Chiu Philippe Mathieu-Daudé
2020-01-06 0:38 ` Chiu, Chasel
2020-01-02 19:23 ` [PATCH v3 08/32] .mailmap: Add an entry for Christopher J Zurcher Philippe Mathieu-Daudé
2020-01-02 19:23 ` [PATCH v3 09/32] .mailmap: Add an entry for Eric Dong Philippe Mathieu-Daudé
2020-01-02 19:23 ` [PATCH v3 10/32] .mailmap: Add an entry for Erik Bjorge Philippe Mathieu-Daudé
2020-01-02 19:23 ` [PATCH v3 11/32] .mailmap: Add an entry for Hao Wu Philippe Mathieu-Daudé
2020-01-02 19:23 ` [PATCH v3 12/32] .mailmap: Add an entry for Hot Tian Philippe Mathieu-Daudé
2020-01-02 19:23 ` [PATCH v3 13/32] .mailmap: Add an entry for Jiewen Yao Philippe Mathieu-Daudé
2020-01-03 0:49 ` Yao, Jiewen
2020-01-02 19:23 ` [PATCH v3 14/32] .mailmap: Add an entry for Jim Dailey Philippe Mathieu-Daudé
2020-01-02 19:23 ` [PATCH v3 15/32] .mailmap: Add an entry for Laszlo Ersek Philippe Mathieu-Daudé
2020-01-02 19:23 ` [PATCH v3 16/32] .mailmap: Add an entry for Liming Gao Philippe Mathieu-Daudé
2020-01-03 0:09 ` [edk2-devel] " Liming Gao
2020-01-02 19:23 ` [PATCH v3 17/32] .mailmap: Add an entry for Maciej Rabeda Philippe Mathieu-Daudé
2020-01-07 10:33 ` Rabeda, Maciej
2020-01-02 19:23 ` [PATCH v3 18/32] .mailmap: Add an entry for Marc-André Lureau Philippe Mathieu-Daudé
2020-01-02 19:23 ` [PATCH v3 19/32] .mailmap: Add an entry for Marvin Häuser Philippe Mathieu-Daudé
2020-01-02 19:23 ` [PATCH v3 20/32] .mailmap: Add an entry for Maurice Ma Philippe Mathieu-Daudé
2020-01-02 19:23 ` [PATCH v3 21/32] .mailmap: Add an entry for Michael Kubacki Philippe Mathieu-Daudé
2020-01-02 19:23 ` [PATCH v3 22/32] .mailmap: Add an entry for Ming Tan Philippe Mathieu-Daudé
2020-01-02 19:23 ` [PATCH v3 23/32] .mailmap: Add an entry for Nikolai Saoukh Philippe Mathieu-Daudé
2020-01-02 19:23 ` [PATCH v3 24/32] .mailmap: Add an entry for Philippe Mathieu-Daudé Philippe Mathieu-Daudé
2020-01-03 13:49 ` Laszlo Ersek
2020-01-02 19:23 ` [PATCH v3 25/32] .mailmap: Add an entry for Ray Ni Philippe Mathieu-Daudé
2020-01-02 19:23 ` [PATCH v3 26/32] .mailmap: Add an entry for Samer El-Haj-Mahmoud Philippe Mathieu-Daudé
2020-01-02 19:23 ` [PATCH v3 27/32] .mailmap: Add an entry for Shenglei Zhang Philippe Mathieu-Daudé
2020-01-02 19:23 ` [PATCH v3 28/32] .mailmap: Add an entry for Star Zeng Philippe Mathieu-Daudé
2020-01-02 19:23 ` [PATCH v3 29/32] .mailmap: Add an entry for Vitaly Cheptsov Philippe Mathieu-Daudé
2020-01-02 19:23 ` [PATCH v3 30/32] .mailmap: Add an entry for Vladimir Olovyannikov Philippe Mathieu-Daudé
2020-01-02 19:23 ` [PATCH v3 31/32] .mailmap: Add an entry for Yonghong Zhu Philippe Mathieu-Daudé
2020-01-02 19:23 ` [PATCH v3 32/32] .mailmap: Add an entry for Yu-Chen Lin Philippe Mathieu-Daudé
2020-01-03 13:48 ` [PATCH v3 00/32] .mailmap: Add mailmap file to have a cleaner git history Laszlo Ersek
2020-01-03 13:56 ` Philippe Mathieu-Daudé
2020-01-06 10:41 ` Laszlo Ersek [this message]
2020-01-06 11:00 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5f6d5901-9c19-f5b2-08ec-f7482d868b6b@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox