[PATCH] CorebootModulePkgPkg: Expose FindCbTag API from CbParseLib

[PATCH] CorebootModulePkgPkg: Expose FindCbTag API from CbParseLib

[gdong1]

CbPlatformSupportLib might use FindCbTag() API to parse
platform specific information.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Guo Dong <guo.dong@intel.com>
Reviewed-by: Maurice Ma <maurice.ma@intel.com>
---
 CorebootModulePkg/Include/Library/CbParseLib.h | 19 ++++++++++++++++++-
 1 file changed, 18 insertions(+), 1 deletion(-)

diff --git a/CorebootModulePkg/Include/Library/CbParseLib.h b/CorebootModulePkg/Include/Library/CbParseLib.h
index 064baf3..e1fda7e 100644
--- a/CorebootModulePkg/Include/Library/CbParseLib.h
+++ b/CorebootModulePkg/Include/Library/CbParseLib.h
@@ -2,7 +2,7 @@
   This library will parse the coreboot table in memory and extract those required
   information.
 
-  Copyright (c) 2014, Intel Corporation. All rights reserved.<BR>
+  Copyright (c) 2014 - 2016, Intel Corporation. All rights reserved.<BR>
   This program and the accompanying materials
   are licensed and made available under the terms and conditions of the BSD License
   which accompanies this distribution.  The full text of the license may be found at
@@ -18,6 +18,23 @@ typedef RETURN_STATUS \
         (*CB_MEM_INFO_CALLBACK) (UINT64 Base, UINT64 Size, UINT32 Type, VOID *Param);
 
 /**
+  Find coreboot record with given Tag from the memory Start in 4096
+  bytes range.
+
+  @param  Start              The start memory to be searched in
+  @param  Tag                The tag id to be found
+
+  @retval NULL              The Tag is not found.
+  @retval Others            The poiter to the record found.
+
+**/
+VOID *
+FindCbTag (
+  IN  VOID     *Start,
+  IN  UINT32   Tag
+  );
+
+/**
   Acquire the memory information from the coreboot table in memory.
 
   @param  MemInfoCallback     The callback routine
-- 
2.7.0.windows.1

Re: [PATCH] CorebootModulePkgPkg: Expose FindCbTag API from CbParseLib

[Ma, Maurice]

Guo,

I think it is better to add  "EFIAPI" to force the calling convention.

Thanks
Maurice

-----Original Message-----
From: Dong, Guo 
Sent: Wednesday, October 26, 2016 5:35 PM
To: edk2-devel@lists.01.org
Cc: Ma, Maurice; Agyeman, Prince; Dong, Guo
Subject: [edk2] [PATCH] CorebootModulePkgPkg: Expose FindCbTag API from CbParseLib

CbPlatformSupportLib might use FindCbTag() API to parse platform specific information.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Guo Dong <guo.dong@intel.com>
Reviewed-by: Maurice Ma <maurice.ma@intel.com>
---
 CorebootModulePkg/Include/Library/CbParseLib.h | 19 ++++++++++++++++++-
 1 file changed, 18 insertions(+), 1 deletion(-)

diff --git a/CorebootModulePkg/Include/Library/CbParseLib.h b/CorebootModulePkg/Include/Library/CbParseLib.h
index 064baf3..e1fda7e 100644
--- a/CorebootModulePkg/Include/Library/CbParseLib.h
+++ b/CorebootModulePkg/Include/Library/CbParseLib.h
@@ -2,7 +2,7 @@
   This library will parse the coreboot table in memory and extract those required
   information.
 
-  Copyright (c) 2014, Intel Corporation. All rights reserved.<BR>
+  Copyright (c) 2014 - 2016, Intel Corporation. All rights 
+ reserved.<BR>
   This program and the accompanying materials
   are licensed and made available under the terms and conditions of the BSD License
   which accompanies this distribution.  The full text of the license may be found at @@ -18,6 +18,23 @@ typedef RETURN_STATUS \
         (*CB_MEM_INFO_CALLBACK) (UINT64 Base, UINT64 Size, UINT32 Type, VOID *Param);
 
 /**
+  Find coreboot record with given Tag from the memory Start in 4096  
+ bytes range.
+
+  @param  Start              The start memory to be searched in
+  @param  Tag                The tag id to be found
+
+  @retval NULL              The Tag is not found.
+  @retval Others            The poiter to the record found.
+
+**/
+VOID *
+FindCbTag (
+  IN  VOID     *Start,
+  IN  UINT32   Tag
+  );
+
+/**
   Acquire the memory information from the coreboot table in memory.
 
   @param  MemInfoCallback     The callback routine
--
2.7.0.windows.1

Re: [PATCH] CorebootModulePkgPkg: Expose FindCbTag API from CbParseLib

[Dong, Guo]

Hi Maurice,

Thank you for the comments.
I have updated patch to add EFIAPI to all the APIs in CbParseLib.

Thanks,
Guo

-----Original Message-----
From: Ma, Maurice 
Sent: Wednesday, October 26, 2016 8:02 PM
To: Dong, Guo <guo.dong@intel.com>
Cc: Agyeman, Prince <prince.agyeman@intel.com>; edk2-devel@lists.01.org
Subject: RE: [edk2] [PATCH] CorebootModulePkgPkg: Expose FindCbTag API from CbParseLib

Guo,

I think it is better to add  "EFIAPI" to force the calling convention.

Thanks
Maurice

-----Original Message-----
From: Dong, Guo
Sent: Wednesday, October 26, 2016 5:35 PM
To: edk2-devel@lists.01.org
Cc: Ma, Maurice; Agyeman, Prince; Dong, Guo
Subject: [edk2] [PATCH] CorebootModulePkgPkg: Expose FindCbTag API from CbParseLib

CbPlatformSupportLib might use FindCbTag() API to parse platform specific information.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Guo Dong <guo.dong@intel.com>
Reviewed-by: Maurice Ma <maurice.ma@intel.com>
---
 CorebootModulePkg/Include/Library/CbParseLib.h | 19 ++++++++++++++++++-
 1 file changed, 18 insertions(+), 1 deletion(-)

diff --git a/CorebootModulePkg/Include/Library/CbParseLib.h b/CorebootModulePkg/Include/Library/CbParseLib.h
index 064baf3..e1fda7e 100644
--- a/CorebootModulePkg/Include/Library/CbParseLib.h
+++ b/CorebootModulePkg/Include/Library/CbParseLib.h
@@ -2,7 +2,7 @@
   This library will parse the coreboot table in memory and extract those required
   information.
 
-  Copyright (c) 2014, Intel Corporation. All rights reserved.<BR>
+  Copyright (c) 2014 - 2016, Intel Corporation. All rights 
+ reserved.<BR>
   This program and the accompanying materials
   are licensed and made available under the terms and conditions of the BSD License
   which accompanies this distribution.  The full text of the license may be found at @@ -18,6 +18,23 @@ typedef RETURN_STATUS \
         (*CB_MEM_INFO_CALLBACK) (UINT64 Base, UINT64 Size, UINT32 Type, VOID *Param);
 
 /**
+  Find coreboot record with given Tag from the memory Start in 4096 
+ bytes range.
+
+  @param  Start              The start memory to be searched in
+  @param  Tag                The tag id to be found
+
+  @retval NULL              The Tag is not found.
+  @retval Others            The poiter to the record found.
+
+**/
+VOID *
+FindCbTag (
+  IN  VOID     *Start,
+  IN  UINT32   Tag
+  );
+
+/**
   Acquire the memory information from the coreboot table in memory.
 
   @param  MemInfoCallback     The callback routine
--
2.7.0.windows.1