From: "Jeremy Soller" <jeremy@system76.com>
To: "Michael A Kubacki" <michael.a.kubacki@intel.com>, devel@edk2.groups.io
Cc: "Chasel Chiu" <chasel.chiu@intel.com>,
"Nathaniel L Desimone" <nathaniel.l.desimone@intel.com>,
"Ankit Sinha" <ankit.sinha@intel.com>
Subject: Re: [edk2-platforms][PATCH V1 03/12] ClevoOpenBoardPkg: Remove global files and references
Date: Mon, 23 Sep 2019 16:39:04 -0600 [thread overview]
Message-ID: <5fb4e26e-670d-46e2-b7ec-2e1412597db5@www.fastmail.com> (raw)
In-Reply-To: <20190920184030.6148-4-michael.a.kubacki@intel.com>
Reviewed-by: Jeremy Soller <jeremy@system76.com>
On Fri, Sep 20, 2019, at 12:40 PM, Michael Kubacki wrote:
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2207
>
> Remove references to ClevoOpenBoardPkg external to the package
> since the package is now removed.
>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Ankit Sinha <ankit.sinha@intel.com>
> Cc: Jeremy Soller <jeremy@system76.com>
> Signed-off-by: Michael Kubacki <michael.a.kubacki@intel.com>
> ---
> Maintainers.txt | 5 -----
> Platform/Intel/Readme.md | 18 ------------------
> Readme.md | 1 -
> 3 files changed, 24 deletions(-)
>
> diff --git a/Maintainers.txt b/Maintainers.txt
> index c04cc23680..a30ee2f602 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -82,11 +82,6 @@ Platform/Intel/UserInterfaceFeaturePkg
> M: Dandan Bi <dandan.bi@intel.com>
> R: Liming Gao <liming.gao@intel.com>
>
> -Platform/Intel/ClevoOpenBoardPkg
> -M: Michael Kubacki <michael.a.kubacki@intel.com>
> -M: Ankit Sinha <ankit.sinha@intel.com>
> -M: Nate DeSimone <nathaniel.l.desimone@intel.com>
> -
> Platform/Intel/KabylakeOpenBoardPkg
> M: Chasel Chiu <chasel.chiu@intel.com>
> M: Michael Kubacki <michael.a.kubacki@intel.com>
> diff --git a/Platform/Intel/Readme.md b/Platform/Intel/Readme.md
> index 2575d4ec52..6a9b1d2e00 100644
> --- a/Platform/Intel/Readme.md
> +++ b/Platform/Intel/Readme.md
> @@ -53,7 +53,6 @@ A UEFI firmware implementation using MinPlatformPkg
> is constructed using the fol
>
>
> ## Board Support
> -* The `ClevoOpenBoardPkg` contains board implementations for Clevo
> systems.
> * The `KabylakeOpenBoardPkg` contains board implementations for Kaby
> Lake systems.
> * The `PurleyOpenBoardPkg` contains board implementations for Purley
> systems.
> * The `SimicsOpenBoardPkg` contains board implementations for the
> Simics hardware simulator.
> @@ -84,15 +83,6 @@ A UEFI firmware implementation using MinPlatformPkg
> is constructed using the fol
>
> ----------------------------------------|--------------------------------------------|------------------------------|--------------------|
> | Simics Quick Start Package | Nehalem
> | SimicsOpenBoardPkg | BoardX58Ich10 |
>
> -#### System 76
> -
> -***Galago Pro Laptop***
> -
> -| Machine Name | Supported Chipsets
> | BoardPkg | Board Name |
> -----------------------------------------|--------------------------------------------|------------------------------|--------------------|
> -| galp2 (Clevo N130BU) | Kaby Lake
> | ClevoOpenBoardPkg | N1xxWU |
> -| galp3 & galp3-b (Clevo N1xxWU series) | Kaby Lake Refresh
> | ClevoOpenBoardPkg | N1xxWU |
> -
> ## Board Package Organization
> The board package follows the standard EDK II package structure with
> the following additional elements and guidelines:
> * Only code usable across more than one board at the root level.
> @@ -226,11 +216,6 @@ return back to the minimum platform caller.
> | | |------build_bios.py: Main build script.
> Generic pre-build, build,
> | | | post-build, and clean
> functions.
> | | |
> - | | |------ClevoOpenBoardPkg
> - | | | |------N1xxWU
> - | | | |---build_config.cfg:
> N1xxWU specific build
> - | | |
> settings environment variables.
> - | | |
> | | |------KabylakeOpenBoardPkg
> | | | |------KabylakeRvp3
> | | | |---build_config.cfg:
> KabylakeRvp3 specific
> @@ -277,9 +262,6 @@ errors.
>
> ### **Known limitations**
>
> -**ClevoOpenBoardPkg**
> -1. The firmware project has not been tested on the Galago Pro 3B.
> -
> **KabylakeOpenBoardPkg**
> 1. This firmware project has only been tested for Microsoft Windows 10
> x64 boot with AHCI mode and Integrated Graphic
> Device.
> diff --git a/Readme.md b/Readme.md
> index e4f211eee6..efdbe8523f 100644
> --- a/Readme.md
> +++ b/Readme.md
> @@ -225,7 +225,6 @@ they will be documented with the platform.
>
> ## Intel
> ### [Minimum Platforms](Platform/Intel/Readme.md)
> -* [Clevo](Platform/Intel/ClevoOpenBoardPkg)
> * [Kaby Lake](Platform/Intel/KabylakeOpenBoardPkg)
> * [Purley](Platform/Intel/PurleyOpenBoardPkg)
> * [Whiskey Lake](Platform/Intel/WhiskeylakeOpenBoardPkg)
> --
> 2.16.2.windows.1
>
>
next prev parent reply other threads:[~2019-09-23 22:39 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-20 18:40 [edk2-platforms][PATCH V1 00/12] Move ClevoOpenBoardPkg/N1xxWU Contents to KabylakeOpenBoardPkg Kubacki, Michael A
2019-09-20 18:40 ` [edk2-platforms][PATCH V1 01/12] Platform/Intel: Remove N1xxWU board build option Kubacki, Michael A
2019-09-23 7:45 ` [edk2-devel] " Nate DeSimone
2019-09-23 8:51 ` Chiu, Chasel
2019-09-23 20:28 ` Sinha, Ankit
2019-09-23 22:28 ` jeremy
2019-09-20 18:40 ` [edk2-platforms][PATCH V1 02/12] ClevoOpenBoardPkg: Remove package contents Kubacki, Michael A
2019-09-23 8:04 ` Nate DeSimone
2019-09-23 8:23 ` [edk2-devel] " Chiu, Chasel
2019-09-23 22:37 ` Jeremy Soller
2019-09-20 18:40 ` [edk2-platforms][PATCH V1 03/12] ClevoOpenBoardPkg: Remove global files and references Kubacki, Michael A
2019-09-23 0:49 ` [edk2-devel] " Chiu, Chasel
2019-09-23 8:05 ` Nate DeSimone
2019-09-23 22:39 ` Jeremy Soller [this message]
2019-09-20 18:40 ` [edk2-platforms][PATCH V1 04/12] KabylakeOpenBoardPkg: Move policy update libs to KabylakeRvp3 board Kubacki, Michael A
2019-09-23 8:07 ` [edk2-devel] " Nate DeSimone
2019-09-23 8:19 ` Chiu, Chasel
2019-09-23 22:38 ` Jeremy Soller
2019-09-20 18:40 ` [edk2-platforms][PATCH V1 05/12] KabylakeOpenBoardPkg: Move EcCommands.h " Kubacki, Michael A
2019-09-23 8:08 ` [edk2-devel] " Nate DeSimone
2019-09-23 8:25 ` Chiu, Chasel
2019-09-23 22:37 ` Jeremy Soller
2019-09-20 18:40 ` [edk2-platforms][PATCH V1 06/12] KabylakeOpenBoardPkg: Move flash map to board Kubacki, Michael A
2019-09-23 8:09 ` Nate DeSimone
2019-09-23 8:41 ` Chiu, Chasel
2019-09-23 22:36 ` Jeremy Soller
2019-09-20 18:40 ` [edk2-platforms][PATCH V1 07/12] KabylakeOpenBoardPkg: Add PeiSerialPortLibSpiFlash Kubacki, Michael A
2019-09-23 8:10 ` Nate DeSimone
2019-09-23 8:27 ` Chiu, Chasel
2019-09-23 22:37 ` Jeremy Soller
2019-09-20 18:40 ` [edk2-platforms][PATCH V1 08/12] KabylakeOpenBoardPkg/GalagoPro3: Add headers Kubacki, Michael A
2019-09-23 8:11 ` Nate DeSimone
2019-09-23 8:42 ` Chiu, Chasel
2019-09-23 22:35 ` [edk2-devel] " Jeremy Soller
2019-09-20 18:40 ` [edk2-platforms][PATCH V1 09/12] KabylakeOpenBoardPkg/GalagoPro3: Add library instances Kubacki, Michael A
2019-09-23 8:14 ` Nate DeSimone
2019-09-23 8:28 ` Chiu, Chasel
2019-09-23 22:36 ` Jeremy Soller
2019-09-23 22:36 ` Jeremy Soller
2019-09-20 18:40 ` [edk2-platforms][PATCH V1 10/12] KabylakeOpenBoardPkg/GalagoPro3: Add modules Kubacki, Michael A
2019-09-23 8:15 ` Nate DeSimone
2019-09-23 17:41 ` [edk2-devel] " Kubacki, Michael A
2019-09-23 8:45 ` Chiu, Chasel
2019-09-23 22:35 ` Jeremy Soller
2019-09-20 18:40 ` [edk2-platforms][PATCH V1 11/12] KabylakeOpenBoardPkg/GalagoPro3: Add build files Kubacki, Michael A
2019-09-23 8:16 ` Nate DeSimone
2019-09-23 8:36 ` [edk2-devel] " Chiu, Chasel
2019-09-23 22:36 ` Jeremy Soller
2019-09-20 18:40 ` [edk2-platforms][PATCH V1 12/12] Add GalagoPro3 board details to global build and documentation Kubacki, Michael A
2019-09-23 0:51 ` [edk2-devel] " Chiu, Chasel
2019-09-23 8:18 ` Nate DeSimone
2019-09-23 22:38 ` Jeremy Soller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5fb4e26e-670d-46e2-b7ec-2e1412597db5@www.fastmail.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox