From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 905661A1DF1 for ; Mon, 26 Sep 2016 03:06:24 -0700 (PDT) Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 289ADC05A2A1; Mon, 26 Sep 2016 10:06:24 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-12.phx2.redhat.com [10.3.116.12]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u8QA6MMb012584; Mon, 26 Sep 2016 06:06:23 -0400 To: Ruiyu Ni , edk2-devel@ml01.01.org References: <20160926093035.350612-1-ruiyu.ni@intel.com> <20160926093035.350612-19-ruiyu.ni@intel.com> Cc: Ard Biesheuvel From: Laszlo Ersek Message-ID: <5fc7f7a5-d000-c8c1-fb84-485bbea289fb@redhat.com> Date: Mon, 26 Sep 2016 12:06:22 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <20160926093035.350612-19-ruiyu.ni@intel.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.27 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Mon, 26 Sep 2016 10:06:24 +0000 (UTC) Subject: Re: [PATCH v2 18/19] ArmVirtPkg: Use the new LogoDxe driver X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Sep 2016 10:06:24 -0000 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit On 09/26/16 11:30, Ruiyu Ni wrote: > Contributed-under: TianoCore Contribution Agreement 1.0 > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Signed-off-by: Ruiyu Ni > --- > ArmVirtPkg/ArmVirtQemu.dsc | 7 ++----- > ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc | 4 +--- > ArmVirtPkg/ArmVirtQemuKernel.dsc | 7 ++----- > ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c | 8 +------- > 4 files changed, 6 insertions(+), 20 deletions(-) > > diff --git a/ArmVirtPkg/ArmVirtQemu.dsc b/ArmVirtPkg/ArmVirtQemu.dsc > index a3beb46..d4d9c0f 100644 > --- a/ArmVirtPkg/ArmVirtQemu.dsc > +++ b/ArmVirtPkg/ArmVirtQemu.dsc > @@ -62,7 +62,6 @@ [LibraryClasses.common] > CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf > UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf > BootLogoLib|MdeModulePkg/Library/BootLogoLib/BootLogoLib.inf > - ImageDecoderLib|MdeModulePkg/Library/ImageDecoderLib/ImageDecoderLib.inf > PlatformBootManagerLib|ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf > CustomizedDisplayLib|MdeModulePkg/Library/CustomizedDisplayLib/CustomizedDisplayLib.inf > QemuBootOrderLib|OvmfPkg/Library/QemuBootOrderLib/QemuBootOrderLib.inf > @@ -331,10 +330,8 @@ [Components.common] > MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf > MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf > MdeModulePkg/Universal/DriverHealthManagerDxe/DriverHealthManagerDxe.inf > - MdeModulePkg/Universal/BdsDxe/BdsDxe.inf { > - > - NULL|MdeModulePkg/Library/BmpImageDecoderLib/BmpImageDecoderLib.inf > - } > + MdeModulePkg/Universal/BdsDxe/BdsDxe.inf > + MdeModulePkg/Logo/LogoDxe.inf > MdeModulePkg/Application/UiApp/UiApp.inf { > > NULL|MdeModulePkg/Library/DeviceManagerUiLib/DeviceManagerUiLib.inf > diff --git a/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc b/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc > index 2571884..a2e82b3 100644 > --- a/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc > +++ b/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc > @@ -181,9 +181,7 @@ [FV.FvMain] > # > # TianoCore logo (splash screen) > # > - FILE FREEFORM = PCD(gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdLogoFile) { > - SECTION RAW = MdeModulePkg/Logo/Logo.bmp > - } > + INF MdeModulePkg/Logo/LogoDxe.inf > > # > # Ramdisk support > diff --git a/ArmVirtPkg/ArmVirtQemuKernel.dsc b/ArmVirtPkg/ArmVirtQemuKernel.dsc > index e0dcf43..e483a27 100644 > --- a/ArmVirtPkg/ArmVirtQemuKernel.dsc > +++ b/ArmVirtPkg/ArmVirtQemuKernel.dsc > @@ -61,7 +61,6 @@ [LibraryClasses.common] > CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf > UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf > BootLogoLib|MdeModulePkg/Library/BootLogoLib/BootLogoLib.inf > - ImageDecoderLib|MdeModulePkg/Library/ImageDecoderLib/ImageDecoderLib.inf > PlatformBootManagerLib|ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf > CustomizedDisplayLib|MdeModulePkg/Library/CustomizedDisplayLib/CustomizedDisplayLib.inf > QemuBootOrderLib|OvmfPkg/Library/QemuBootOrderLib/QemuBootOrderLib.inf > @@ -320,10 +319,8 @@ [Components.common] > MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf > MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf > MdeModulePkg/Universal/DriverHealthManagerDxe/DriverHealthManagerDxe.inf > - MdeModulePkg/Universal/BdsDxe/BdsDxe.inf { > - > - NULL|MdeModulePkg/Library/BmpImageDecoderLib/BmpImageDecoderLib.inf > - } > + MdeModulePkg/Universal/BdsDxe/BdsDxe.inf > + MdeModulePkg/Logo/LogoDxe.inf > MdeModulePkg/Application/UiApp/UiApp.inf { > > NULL|MdeModulePkg/Library/DeviceManagerUiLib/DeviceManagerUiLib.inf > diff --git a/ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c b/ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c > index 5d7c2a4..aecad57 100644 > --- a/ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c > +++ b/ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c > @@ -657,13 +657,7 @@ PlatformBootManagerAfterConsole ( > // > // Show the splash screen. > // > - // BootLogoEnableLogo ( > - // ImageFormatBmp, // ImageFormat > - // PcdGetPtr (PcdLogoFile), // Logo > - // EdkiiPlatformLogoDisplayAttributeCenter, // Attribute > - // 0, // OffsetX > - // 0 // OffsetY > - // ); > + BootLogoEnableLogo (); > > // > // Connect the rest of the devices. > Reviewed-by: Laszlo Ersek