From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=66.187.233.73; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2B69D2235228A for ; Fri, 2 Mar 2018 02:01:55 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id F2956402314E; Fri, 2 Mar 2018 10:08:03 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-104.rdu2.redhat.com [10.10.120.104]) by smtp.corp.redhat.com (Postfix) with ESMTP id 97F1B94562; Fri, 2 Mar 2018 10:08:02 +0000 (UTC) To: "Ni, Ruiyu" , Heyi Guo , edk2-devel@lists.01.org Cc: Jordan Justen , Anthony Perard , Julien Grall , Ard Biesheuvel References: <1519887444-75510-1-git-send-email-heyi.guo@linaro.org> <1519887444-75510-3-git-send-email-heyi.guo@linaro.org> <001017d1-42ae-8376-6410-3f6f34f6c3f5@Intel.com> From: Laszlo Ersek Message-ID: <5fdaa2e0-442c-04cd-e362-659abce87438@redhat.com> Date: Fri, 2 Mar 2018 11:08:01 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <001017d1-42ae-8376-6410-3f6f34f6c3f5@Intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Fri, 02 Mar 2018 10:08:04 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Fri, 02 Mar 2018 10:08:04 +0000 (UTC) for IP:'10.11.54.5' DOMAIN:'int-mx05.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'lersek@redhat.com' RCPT:'' Subject: Re: [PATCH v5 2/6] OvmfPkg/PciHostBridgeLib: Init PCI aperture to 0 X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Mar 2018 10:01:56 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 03/01/18 13:03, Ni, Ruiyu wrote: > On 3/1/2018 6:20 PM, Laszlo Ersek wrote: >> On 03/01/18 07:57, Heyi Guo wrote: >>> Use ZeroMem to initialize all fields in temporary >>> PCI_ROOT_BRIDGE_APERTURE variables to zero. This is not mandatory but >>> is helpful for future extension: when we add new fields to >>> PCI_ROOT_BRIDGE_APERTURE and the default value of these fields can >>> safely be zero, this code will not suffer from an additional >>> change. >>> >>> Contributed-under: TianoCore Contribution Agreement 1.1 >>> Signed-off-by: Heyi Guo >>> >>> Cc: Jordan Justen >>> Cc: Anthony Perard >>> Cc: Julien Grall >>> Cc: Ruiyu Ni >>> Cc: Laszlo Ersek >>> Cc: Ard Biesheuvel >>> --- >>>   OvmfPkg/Library/PciHostBridgeLib/PciHostBridgeLib.c | 4 ++++ >>>   OvmfPkg/Library/PciHostBridgeLib/XenSupport.c       | 5 +++++ >>>   2 files changed, 9 insertions(+) >> >> I also suggest a different subject line: >> >> OvmfPkg/PciHostBridgeLib: clear PCI_ROOT_BRIDGE_APERTURE vars for >> (re)init >> >> (74 chars) > > I sometimes tries very hard to make the subject line be <= 70 chars. > 74 is acceptable? To my knowledge, the Linux kernel development guidelines suggest wrapping the commit message body at 74 characters, and IIRC the same limit applies to the subject line. I tend to follow these ideas for edk2 development too. I think anything under 74 chars (for the subject) is an unreasonable expectation for edk2. First, we start with a prefix of the form XxxPkg/Module: ... Sometimes this prefix is incredibly long alread :/ So what I do (and I guess most others do as well) is that I first write an "honest" subject line (which frequently reaches 90-100 chars), and then work on compressing it down to 74 characters. Sometimes it becomes a real struggle, with strange abbreviations etc. I might make an exception and go up to 75-76, and hope that nobody notices :) So, in that range, limiting ourselves to 70 chars would be catastrophic. Thanks! Laszlo