From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=66.187.233.73; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 0FCEE210E38D8 for ; Thu, 9 Aug 2018 08:09:13 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4707E7B2B1; Thu, 9 Aug 2018 15:09:12 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-121-52.rdu2.redhat.com [10.10.121.52]) by smtp.corp.redhat.com (Postfix) with ESMTP id 60A802026D66; Thu, 9 Aug 2018 15:09:11 +0000 (UTC) To: marcandre.lureau@redhat.com, edk2-devel@lists.01.org Cc: Zhang Chao B , Long Qin , Jiewen Yao References: <20180809143319.12294-1-marcandre.lureau@redhat.com> From: Laszlo Ersek Message-ID: <5fe0961e-e2c2-9930-10d6-3e366e98e737@redhat.com> Date: Thu, 9 Aug 2018 17:09:10 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180809143319.12294-1-marcandre.lureau@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]); Thu, 09 Aug 2018 15:09:12 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]); Thu, 09 Aug 2018 15:09:12 +0000 (UTC) for IP:'10.11.54.4' DOMAIN:'int-mx04.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'lersek@redhat.com' RCPT:'' Subject: Re: [PATCH 1/1] SecurityPkg/Library/Tpm2DeviceLibDTpm: fix s/Constructor/CONSTRUCTOR X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Aug 2018 15:09:13 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 08/09/18 16:33, marcandre.lureau@redhat.com wrote: > From: Marc-André Lureau > > The library constructor is not being called because of the typo, > causing TPM2 detection/initialization to fail. > > This fixes OVMF TPM2 regression since commit f15cb995bb38. > https://bugzilla.tianocore.org/show_bug.cgi?id=1075 > > Cc: Laszlo Ersek > Cc: Zhang Chao B > Cc: Long Qin > Fixes: f15cb995bb3880b77e15afe6facd3da05e599a17 > Contributed-under: TianoCore Contribution Agreement 1.1 > Reported-by: Ricardo Araújo > Signed-off-by: Marc-André Lureau > --- > SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2DeviceLibDTpm.inf | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2DeviceLibDTpm.inf b/SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2DeviceLibDTpm.inf > index b6867bc4fff4..c6d23c93fe93 100644 > --- a/SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2DeviceLibDTpm.inf > +++ b/SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2DeviceLibDTpm.inf > @@ -28,7 +28,7 @@ > MODULE_TYPE = BASE > VERSION_STRING = 1.0 > LIBRARY_CLASS = Tpm2DeviceLib|PEIM DXE_DRIVER DXE_RUNTIME_DRIVER DXE_SMM_DRIVER UEFI_APPLICATION UEFI_DRIVER > - Constructor = Tpm2DeviceLibConstructor > + CONSTRUCTOR = Tpm2DeviceLibConstructor > # > # The following information is for reference only and not required by the build tools. > # > + Jiewen (see "SecurityPkg" in "Maintainers.txt"). Reviewed-by: Laszlo Ersek I will wait one day so that Chao, Jiewen and/or Qin can ACK the patch as well. I will push the patch tomorrow (definitely before the upcoming stable tag). Note: I would like to push this patch myself because of the non-ASCII characters in the metadata. Previously, similar patches have been messed up, regarding the "Author" field (see 4cc2b63bd829 and 73ee3abab1a1). I should be able to handle the git-am / git-push cleanly on my side though (see a39e72267034 and ab9e11da6651). Thanks! Laszlo