From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail04.groups.io (mail04.groups.io [45.79.224.9]) by spool.mail.gandi.net (Postfix) with ESMTPS id 84D48D80520 for ; Wed, 17 Apr 2024 06:59:43 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=qqmNYrTUeA0k1hdDb4hlqEUNO/HHb7BzNJQzEZasRRY=; c=relaxed/simple; d=groups.io; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition:Content-Transfer-Encoding; s=20240206; t=1713337182; v=1; b=ncguXdx3qoTfj9fukAjoTCgctzZCeBXjoadYQhT26Cq0MuwrL2oMzlbGK728RpE9QZAF1TYC 26cME9Y35MIJTCG7cowOeZJ+3nOv1W/7FFNqkQRdxnmte527r7C9jQf2kHIuhpFguRcC3Drg3l/ rz7/xzQxOXQ/NcebCTBbulnd6smLgKEEA76lr7N9r75ED3YWHWb4TGOwfoRq7CB+k4hP6jcJTpI n4D6iY1ksKiiIAT5AL+mLUMxU1PUx88wF9r1bcK7TVNzWhn1v5qUNbhh3li9XTHKfyb5maSReJQ NHnrihsLjgF1i48n7u/f9h9vdfgO1n3R4yWtQuZAjV/oQ== X-Received: by 127.0.0.2 with SMTP id YBLaYY7687511xp28nd1dYuW; Tue, 16 Apr 2024 23:59:42 -0700 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web10.6849.1713337181296758990 for ; Tue, 16 Apr 2024 23:59:41 -0700 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-672-h2SQ9CvmNHyzgZ-ByMb10w-1; Wed, 17 Apr 2024 02:59:36 -0400 X-MC-Unique: h2SQ9CvmNHyzgZ-ByMb10w-1 X-Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A21AB1887314; Wed, 17 Apr 2024 06:59:35 +0000 (UTC) X-Received: from dobby.home.kraxel.org (unknown [10.39.192.214]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5B8C5490DD; Wed, 17 Apr 2024 06:59:35 +0000 (UTC) X-Received: by dobby.home.kraxel.org (Postfix, from userid 1000) id 00FB9EE000; Wed, 17 Apr 2024 08:59:13 +0200 (CEST) Date: Wed, 17 Apr 2024 08:59:13 +0200 From: "Gerd Hoffmann" To: devel@edk2.groups.io, lichao@loongson.cn Cc: lixianglai , Ard Biesheuvel , Jiewen Yao , Jordan Justen , Bibo Mao , Dongyan Qian Subject: Re: [edk2-devel] [PATCH v1 21/26] OvmfPkg/LoongArchVirt: Add FdtQemuFwCfgLib Message-ID: <5fjrgywtmvboqdi43n7brrzms67skc3zejzvnekz2v62znhzpk@wjidta4b7rae> References: <20240311093631.1251466-1-lichao@loongson.cn> <20240311093924.1254576-1-lichao@loongson.cn> <01d94c67-de3d-7709-84d4-ec97dc7a01ec@loongson.cn> <2teja7rxfli7fxvxlii54tbdaj2y6jz2qlvprf7pfpzzjyycrz@gp5axpziekwh> <949717bb-5dbd-4298-9482-a3b12ded650a@loongson.cn> <17BEC74BB37915EC.2828@groups.io> <323033d0-8749-4885-a4b1-7f6f854b6487@loongson.cn> MIME-Version: 1.0 In-Reply-To: <323033d0-8749-4885-a4b1-7f6f854b6487@loongson.cn> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Tue, 16 Apr 2024 23:59:41 -0700 Resent-From: kraxel@redhat.com Reply-To: devel@edk2.groups.io,kraxel@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: iINuVJ1QrcVVOh2EQnvACMyBx7686176AA= Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=ncguXdx3; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.9 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none) On Wed, Apr 17, 2024 at 10:53:21AM +0800, Chao Li wrote: > Hi Gerd, > > Part 2 has been be merged, I'm separating  this Lib into two serve the PEI > stage and DXE stage. > > Currently, This DXE library uses three global variables, and when I simulate > the no-mmio version: MmioLib.c + Dxe.c + Pei.c, I can abstract some helper > functions as the public functions in Mmio version. > > Do you mind if I replace these three vaiables with three dynamically typed > PCDs? If so, the PEI and DXE stage libraries can using  some of the same > APIs. What is your idea? Let PEI discover fw_cfg, store results in PCDs, and DXE will read the PCDs instead of using FdtClientProtocol to find the fw_cfg? Note that risc-v and arm don't need access to fw_cfg in PEI, so this approach would not work for them. take care, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117896): https://edk2.groups.io/g/devel/message/117896 Mute This Topic: https://groups.io/mt/104859897/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-