From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id AC125AC16AD for ; Wed, 29 Nov 2023 14:25:22 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=RLt8EDKffKMOhden8Cxo/ZuhXYm98TTtCJUIp2Hr2sM=; c=relaxed/simple; d=groups.io; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20140610; t=1701267921; v=1; b=B/pZ+aliCRxUqgWkSlu7xdjLa0qAhvXL/7zoa+M/Zrm/pOOYEeL9j+m9SvfuDmX0V5PuDpd8 icgqtATZERpzFsqp5vvkk8e9nonBoArNYhSZb+EJB7VNZqnq6fYu87bfnSff8k26ozE1Znm6owN Kr5aZWY18Sx1/qd6CZQIjR0g= X-Received: by 127.0.0.2 with SMTP id IazxYY7687511xqahAWsifil; Wed, 29 Nov 2023 06:25:21 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web11.34139.1701267920640486294 for ; Wed, 29 Nov 2023 06:25:20 -0800 X-Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-423-1wRzCl5CODO-dHAWq4C5Eg-1; Wed, 29 Nov 2023 09:25:15 -0500 X-MC-Unique: 1wRzCl5CODO-dHAWq4C5Eg-1 X-Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 7FC4F382254A; Wed, 29 Nov 2023 14:25:15 +0000 (UTC) X-Received: from sirius.home.kraxel.org (unknown [10.39.193.218]) by smtp.corp.redhat.com (Postfix) with ESMTPS id F2AC41121308; Wed, 29 Nov 2023 14:25:14 +0000 (UTC) X-Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 0A1801800605; Wed, 29 Nov 2023 15:25:11 +0100 (CET) Date: Wed, 29 Nov 2023 15:25:10 +0100 From: "Gerd Hoffmann" To: Pedro Falcato Cc: devel@edk2.groups.io, dhaval@rivosinc.com, Liming Gao , Zhiguang Liu , Dandan Bi Subject: Re: [edk2-devel] [PATCH v3 1/1] MdeModulePkg: Fix issue with ACPI table creation Message-ID: <5mh5duyt2hm656w6okvpmnzdrh25a5rx5qvr4um7ceqjj75nrb@as7d6cayrvbp> References: <20231120042429.860029-1-dhaval@rivosinc.com> <20231120042429.860029-2-dhaval@rivosinc.com> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,kraxel@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: KignaJBZHUHqUIn7mHCPioeDx7686176AA= Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b="B/pZ+ali"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hi, > > + // ACPI Spec 6.5+ Table 5-9 X_DSDT definition > > + // > > + if (((EFI_ACPI_3_0_FIXED_ACPI_DESCRIPTION_TABLE *)ChildTable)->XDsdt != 0) { > > + TableToInstall = (VOID *)(UINTN)((EFI_ACPI_3_0_FIXED_ACPI_DESCRIPTION_TABLE *)ChildTable)->XDsdt; > > (+CC Gerd for qemu) > Is it possible that XDsdt may come filled out with a > 32-bit address > on 32-bit platforms/builds? In other words, is truncation of the > address a problem here? I don't think this is possible. qemu provides a script together with the acpi tables, which contains instructions for pointer fixups, so the firmware is free to choose where it places the tables in memory. 32bit ovmf builds will surely place the tables below 4G. take care, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111845): https://edk2.groups.io/g/devel/message/111845 Mute This Topic: https://groups.io/mt/102702109/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-