From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <bounce+27952+116015+7686176+12367111@groups.io>
Received: from mail02.groups.io (mail02.groups.io [66.175.222.108])
by spool.mail.gandi.net (Postfix) with ESMTPS id C6D35AC0E3F
for <rebecca@openfw.io>; Tue, 27 Feb 2024 10:02:28 +0000 (UTC)
DKIM-Signature: a=rsa-sha256; bh=XJ1QFxogepfmCIYIMA5/NZ2MJXm2eCDHde0TjjrAE8Q=;
c=relaxed/simple; d=groups.io;
h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition;
s=20140610; t=1709028147; v=1;
b=SgX24lPkdt0TT+cBQdbelBqOzsdZV7tV2Hz4lzYOEHJXkznUEkBY8Lke4qrHjBYPRiQ6sFuY
rd1AW8ZHJdH/z+YgNUHu5qiPqsPJcy1+vfisTmEqsVd6RO8vEvxW9TZwtLJk+LHaVXiGDgHYyUN
GPkK7zrqBDkqlez018ETnD3Y=
X-Received: by 127.0.0.2 with SMTP id rk8EYY7687511xlfIPR0qBKk; Tue, 27 Feb 2024 02:02:27 -0800
X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124])
by mx.groups.io with SMTP id smtpd.web11.8892.1709028146851669095
for <devel@edk2.groups.io>;
Tue, 27 Feb 2024 02:02:27 -0800
X-Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73])
by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,
cipher=TLS_AES_256_GCM_SHA384) id us-mta-197-7jsIl7tHPpCssQNC-EgY4w-1; Tue,
27 Feb 2024 05:02:21 -0500
X-MC-Unique: 7jsIl7tHPpCssQNC-EgY4w-1
X-Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
(No client certificate requested)
by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 23EA529ABA0B;
Tue, 27 Feb 2024 10:02:21 +0000 (UTC)
X-Received: from sirius.home.kraxel.org (unknown [10.39.192.249])
by smtp.corp.redhat.com (Postfix) with ESMTPS id 62EA240C1430;
Tue, 27 Feb 2024 10:02:20 +0000 (UTC)
X-Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
id 588B018009BA; Tue, 27 Feb 2024 11:02:19 +0100 (CET)
Date: Tue, 27 Feb 2024 11:02:19 +0100
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: "Ni, Ray" <ray.ni@intel.com>
Cc: Tom Lendacky <thomas.lendacky@amd.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>, "Yao, Jiewen" <jiewen.yao@intel.com>,
"Xu, Min M" <min.m.xu@intel.com>, Ard Biesheuvel <ardb+tianocore@kernel.org>,
"Aktas, Erdem" <erdemaktas@google.com>, Laszlo Ersek <lersek@redhat.com>,
Liming Gao <gaoliming@byosoft.com.cn>, "Kinney, Michael D" <michael.d.kinney@intel.com>,
"Liu, Zhiguang" <zhiguang.liu@intel.com>, "Kumar, Rahul R" <rahul.r.kumar@intel.com>,
Michael Roth <michael.roth@amd.com>
Subject: Re: [edk2-devel] [PATCH v2 02/23] MdePkg: GHCB APIC ID retrieval support definitions
Message-ID: <5pct37rwexnbs3u5nmfmkwfvlopaenzme5xnv4yptjjv6lpk36@qgxluzz5ps6d>
References: <cover.1708623001.git.thomas.lendacky@amd.com>
<a0df1dbb6a37c23e9d446eb6b2a5cd8a06b271ce.1708623001.git.thomas.lendacky@amd.com>
<MN6PR11MB82441B85D948F531C8ACA3278C552@MN6PR11MB8244.namprd11.prod.outlook.com>
MIME-Version: 1.0
In-Reply-To: <MN6PR11MB82441B85D948F531C8ACA3278C552@MN6PR11MB8244.namprd11.prod.outlook.com>
X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.2
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Precedence: Bulk
List-Subscribe: <mailto:devel+subscribe@edk2.groups.io>
List-Help: <mailto:devel+help@edk2.groups.io>
Sender: devel@edk2.groups.io
List-Id: <devel.edk2.groups.io>
Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io
Reply-To: devel@edk2.groups.io,kraxel@redhat.com
List-Unsubscribe-Post: List-Unsubscribe=One-Click
List-Unsubscribe: <https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/plugh>
X-Gm-Message-State: YD023paxwj7EUjKkLW9kqIpBx7686176AA=
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
X-GND-Status: LEGIT
Authentication-Results: spool.mail.gandi.net;
dkim=pass header.d=groups.io header.s=20140610 header.b=SgX24lPk;
dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none);
spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io
On Fri, Feb 23, 2024 at 12:16:54AM +0000, Ni, Ray wrote:
>
> > +//
> > +// Get APIC IDs
> > +//
> > +#define EFI_APIC_IDS_GUID \
> > + { 0xbc964338, 0xee39, 0x4fc8, { 0xa2, 0x24, 0x10, 0x10, 0x8b, 0x17, 0x80,
> > 0x1b }}
> > +extern EFI_GUID gEfiApicIdsGuid;
>
> Since the above GUID is associated with the structure below, how about
> rename the GUID from "gEfiApicIdsGuid" which is very general to a specific
> name "gGhcbApicIdsGuid"?
Same comment goes for EFI_APIC_IDS_GUID.
take care,
Gerd
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116015): https://edk2.groups.io/g/devel/message/116015
Mute This Topic: https://groups.io/mt/104512930/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-