From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 124E8D80A38 for ; Fri, 24 May 2024 11:48:52 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=h+vmeO5QJ+zCcNu1tCy58TjMTtbjaKzxg4yJaSHfzz8=; c=relaxed/simple; d=groups.io; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20240206; t=1716551331; v=1; b=rt8OCj6OwZ6rB6sw3OyIokYRhjyXqEueDbs+oGVqh1TOhkB02VsqbrHECSvQaadMwobT+Wr9 Ao6R4TBBp49htGqdQt/tq+oYFr+X6MnZ6AsDEm28ZWgcy3subRHhwqnIN3X3s9oK60MGDaT+CwL K6CUPqz4+iQTAMPZ87d1r1hjKpukiV33nz5+KYhMgML3/MGwrrh6EpXHLCsYoEvEZK2n9WEXxhp O8aV0GXlGIONymfdrM4KyyXxZJTIczvmnp0dE08LHM/I4ejelfQ7Us13B8kQLJhytlr8RLRDcxZ dOKAqD0yRN76olqzrc/e9a70TIvc3QITg1hPDvmTcK74w== X-Received: by 127.0.0.2 with SMTP id S3jMYY7687511xs74hItaEZ8; Fri, 24 May 2024 04:48:51 -0700 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web10.13833.1716551325655448363 for ; Fri, 24 May 2024 04:48:45 -0700 X-Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-592-7TTctcvsPuq54qowH3gHMg-1; Fri, 24 May 2024 07:48:39 -0400 X-MC-Unique: 7TTctcvsPuq54qowH3gHMg-1 X-Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 162C129AA381; Fri, 24 May 2024 11:48:39 +0000 (UTC) X-Received: from dobby.home.kraxel.org (unknown [10.39.192.97]) by smtp.corp.redhat.com (Postfix) with ESMTPS id F2EE110004F7; Fri, 24 May 2024 11:48:37 +0000 (UTC) X-Received: by dobby.home.kraxel.org (Postfix, from userid 1000) id 90AA418EF1F; Fri, 24 May 2024 13:48:35 +0200 (CEST) Date: Fri, 24 May 2024 13:48:35 +0200 From: "Gerd Hoffmann" To: Ard Biesheuvel Cc: devel@edk2.groups.io, gaoliming@byosoft.com.cn, dougflick@microsoft.com, Michael D Kinney , Andrew Fish , quic_llindhol@quicinc.com Subject: Re: [edk2-devel] [PATCH v3 00/20] NetworkPkg: CVE-2023-45236 and CVE-2023-45237 Message-ID: <5sjxcwodwg3esdvarhmgt4gfg5f77mrp5el4datcuuja3gxoce@jpuxyfjui2tx> References: <20240524054512.523329-1-douglas.flick@microsoft.com> <001001daada8$358301a0$a08904e0$@byosoft.com.cn> <003a01daadba$7013d080$503b7180$@byosoft.com.cn> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Fri, 24 May 2024 04:48:45 -0700 Resent-From: kraxel@redhat.com Reply-To: devel@edk2.groups.io,kraxel@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: EYYOARyl93CdUnS8VlAMr6xWx7686176AA= Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=rt8OCj6O; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none) On Fri, May 24, 2024 at 11:41:04AM GMT, Ard Biesheuvel wrote: > On Fri, 24 May 2024 at 11:12, gaoliming via groups.io > wrote: > > > > Ard: > > Here is Doug PR https://github.com/tianocore/edk2/pull/5582 that includes 20 commits. You can check them. > > > > This looks fine to me in principle. > > Reviewed-by: Ard Biesheuvel > > However, IIUC, the impact of this series is that all out-of-tree > platforms that lack the right implementation of the EFI_RNG_PROTOCOL > (i.e., using a GUID that appears in the allowlist) will lose the > ability to do network boot. If that is a tolerable result, I am fine > with that too, but I think it needs to be made very clear in the > stable tag release notes. Tested the v3 series with OVMF, results are as expected: Without virtio-rng-pci network boot does not work. With virtio-rng-pci everything is fine. Tested-by: Gerd Hoffmann Acked-by: Gerd Hoffmann Agree that this must be noted in the release notes. Related: I'm working on patch series adding RngDxe to OVMF with runtime rdrand detection: https://github.com/kraxel/edk2/commits/devel/ovmf-rdrand/ take care, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119254): https://edk2.groups.io/g/devel/message/119254 Mute This Topic: https://groups.io/mt/106278600/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-