From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=66.187.233.73; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 43C9422546B99 for ; Fri, 2 Mar 2018 02:44:43 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0A0678D6EF; Fri, 2 Mar 2018 10:50:51 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-104.rdu2.redhat.com [10.10.120.104]) by smtp.corp.redhat.com (Postfix) with ESMTP id D78942156601; Fri, 2 Mar 2018 10:50:45 +0000 (UTC) To: =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= Cc: edk2-devel@lists.01.org, Peter Jones , Jiewen Yao , QEMU , Javier Martinez Canillas References: <20180223132311.26555-1-marcandre.lureau@redhat.com> <20180223132311.26555-3-marcandre.lureau@redhat.com> <080742f0-0f3c-bf8e-83d7-e473417cc172@redhat.com> From: Laszlo Ersek Message-ID: <600f47ce-751a-4dcb-fee0-2b05b953e5cb@redhat.com> Date: Fri, 2 Mar 2018 11:50:45 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Fri, 02 Mar 2018 10:50:51 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Fri, 02 Mar 2018 10:50:51 +0000 (UTC) for IP:'10.11.54.6' DOMAIN:'int-mx06.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'lersek@redhat.com' RCPT:'' Subject: Re: [PATCH 2/7] ovmf: link with Tcg2ConfigPei module X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Mar 2018 10:44:43 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 03/01/18 15:59, Marc-André Lureau wrote: > Hi > > On Fri, Feb 23, 2018 at 6:31 PM, Laszlo Ersek wrote: >> (6) Now, I realize Tcg2Pei *apparently* depends on >> gEfiPeiReadOnlyVariable2PpiGuid (i.e., read-only variable access in the >> PEI phase) as well. That's a bug in the INF file (the [depex] section). >> If you grep the Tcg2Pei module source for the GUID, the [depex] section >> is the only hit. Can you please submit a separate patch that removes it >> from the depex? > > I don't get how you came to that conclusion, both > SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigPeim.c and > SecurityPkg/Tcg/Tcg2Config/TpmDetection.c match. Apparently, the > variable is used in s3 mode, in DetectTpmDevice(). In my point (6) above, I was talking about Tcg2Pei, not Tcg2ConfigPei. If you grep "SecurityPkg/Tcg/Tcg2Pei" for "gEfiPeiReadOnlyVariable2PpiGuid", the only hit is the depex section in the INF file. I think that's a bug in "SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.inf", and the PPI GUID should removed from there, as a separate patch. >>> --- >>> OvmfPkg/OvmfPkgX64.dsc | 20 ++++++++++++++++++++ >>> OvmfPkg/OvmfPkgX64.fdf | 3 +++ >>> 2 files changed, 23 insertions(+) >> >> Is there any particular reason to exclude the Ia32 and Ia32X64 builds? >> >> If not, then please modify all three sets of dsc/fdf files identically. > > I'd rather keep this as a TODO item for now, since we are not close to > a final version, and it's annoying to have to fix each files etc.. OK. Thanks! Laszlo