From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by mx.groups.io with SMTP id smtpd.web10.16194.1679049808093332744 for ; Fri, 17 Mar 2023 03:43:28 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="signature has expired" header.i=@bsdio.com header.s=fm3 header.b=LPSBEBQz; spf=pass (domain: bsdio.com, ip: 64.147.123.20, mailfrom: rebecca@bsdio.com) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id C14C03200912; Fri, 17 Mar 2023 06:43:26 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Fri, 17 Mar 2023 06:43:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdio.com; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1679049806; x=1679136206; bh=XPzKx5qH1iZWLLwhKK0rUWRFqx84qiZ/QST IHc8yf9U=; b=LPSBEBQzwuP/4/jeeTShyOmpQFfNv/39QuSaSRAP4mHF7qMPiOy lsVp4m6OLvGi/z+ng2xkc5tYm0jyi2xOtPphWJXG/uwJk97obQTo5R6JuBobyaxn oOTUwkkopYfmM+SupvzsTG/Ir0/vmlDSbILJCCWu8vB8fHO5l3fyBtUTst/gRLRk w+8ulsXyU07hmwzZWSTXiMpW3CzmtlM82o895qCcDj7JCrSRsFosXMUIJVVa9d+P h9AUE3I0Ctk1ALm7eXILDu3JOyg6HKaI4+rorOeMFpKrG4jh9nWQetn30CvnXwSm t+R4R8YVJKUwpVP52H9OAJZeNruhT6S4QpA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1679049806; x=1679136206; bh=XPzKx5qH1iZWLLwhKK0rUWRFqx84qiZ/QST IHc8yf9U=; b=FoygY+KIEw2FQcxRUTokc5RSJqT7NpleMVTag03DL0dHKR45kC3 6kOay5F7awxWxi7fbX4Z+SRiouonFZM/Rx1BLjScuu9QMjULmxsLDol1F+n2yH0p s9ip53Q7eixS8SBLnBxAB+OTq8HOq5SIdilu4oOKoBG+D5pVU6QWCy7bseOsUO+A F4D28wXCqkqr3CDpYoA2HSrSVyAZxyczf3khXJF3wLZ+wRu3RHGLiltwUMEof7Yy FJKTqVBDr8VdrJICQGfR6EUp9mTa061zjW8pJWeCy+BhomjDIQ0YBM1ZEDi0o3P7 0myP0i25Cm8Pgn/8Viui3UvrXzN8MVF4zEA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdefvddgudelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtkeertddtfeejnecuhfhrohhmpeftvggs vggttggrucevrhgrnhcuoehrvggsvggttggrsegsshguihhordgtohhmqeenucggtffrrg htthgvrhhnpeegfeegveduheejgfduffefhfehleehiefghfetvdejvdelhfeukefhhfdv geehveenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hrvggsvggttggrsegsshguihhordgtohhm X-ME-Proxy: Feedback-ID: i5b994698:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 17 Mar 2023 06:43:24 -0400 (EDT) Message-ID: <602780c3-7915-2fb0-177c-9d6dacad22a3@bsdio.com> Date: Fri, 17 Mar 2023 04:43:24 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [edk2-devel] [PATCH 1/3] BaseTools: Allow users to specify compiler to use with make CC= CXX= To: devel@edk2.groups.io, kraxel@redhat.com, quic_rcran@quicinc.com Cc: Andrew Fish , Leif Lindholm , Michael D Kinney , Bob Feng , Liming Gao , Yuwei Chen , Rebecca Cran References: <20230217035101.880854-1-rebecca@quicinc.com> <20230217035101.880854-2-rebecca@quicinc.com> <20230315100742.umho6xek26kv5t6i@sirius.home.kraxel.org> From: "Rebecca Cran" In-Reply-To: <20230315100742.umho6xek26kv5t6i@sirius.home.kraxel.org> Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 3/15/23 4:07 AM, Gerd Hoffmann wrote: >> Rework the BaseTools Makefiles removing the 'BUILD_' prefix (BUILD_CC >> and BUILD_CXX) and using the standard name 'LDFLAGS' instead of >> 'LFLAGS'. This allows clang to be used by running >> 'make -C BaseTools CC=clang CXX=clang++'. > Hmm, not sure this is a good idea. I suspect there was some reason to > use BUILD_CC instead of CC in the first place ... It looks like the change to use BUILD_CC was introduced by Liming in:     BaseTools GnuMakefile: Update GCC Flags to the specific one with BUILD_ prefix     To avoid the conflict with the default GCC flag name, BUILD_ prefix is added.     Cc: Giri P Mudusuru     Cc: Yonghong Zhu     Contributed-under: TianoCore Contribution Agreement 1.0     Signed-off-by: Liming Gao     Reviewed-by: Yonghong Zhu     Reviewed-by: Giri P Mudusuru I don't understand how that would help, and I'm wondering if it was perhaps the result of a misunderstanding. -- Rebecca Cran