From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.groups.io with SMTP id smtpd.web12.4293.1622104906402830358 for ; Thu, 27 May 2021 01:41:46 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=OypTmSyc; spf=pass (domain: redhat.com, ip: 216.205.24.124, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1622104905; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+QGKxlsTjKsc42Ltcc19u4Y39HM899ro5lNpwsjFM8U=; b=OypTmSycZetaqc0L60wF/7zbi3HUPSuTpFiD9cJK3zTXzFxS25TXGvB5Gf83eCNb66wFeI VmMDs9Xhu7uJbvrjPIp7sKmCSC7s10PAQdkqTdWviipj81rND9c08o4y7S3F7QfIO38/Iw eMTfDoKkn/2LnJI8rKXLlXUV3OuloTE= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-595-4fBbFWtHOCOvLQz-4yFrAw-1; Thu, 27 May 2021 04:41:43 -0400 X-MC-Unique: 4fBbFWtHOCOvLQz-4yFrAw-1 Received: by mail-wr1-f72.google.com with SMTP id n2-20020adfb7420000b029010e47b59f31so1458907wre.9 for ; Thu, 27 May 2021 01:41:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=+QGKxlsTjKsc42Ltcc19u4Y39HM899ro5lNpwsjFM8U=; b=mVeiLMUpSOmzdOnU2iF4pTcLDNFiD6Ty4zIwp29oSo2LZmBuOIREk7VN7Y+sn0446H hFgtaQBPy6ez4t40tKo+3d9hMfQf4/HU9N1dhUzJE9uj7uOxCdukmOXrwB9J4IlEZSjz 3IrHA0+WZhM+8DX5zK9rMV3Kl4LUz854+wQZn55k/hdMSQTcu1zGXVKY8hTQUltuahV7 ZPIns3wC7l/Fyt3wtG2ZVEEfUtF6rK7tMUcATPsTw5jvOaznJZLhNrYBr9HPC4/qZb++ uvCyg68IBsYA20JIqDr+/J6Osi3oPeXUFpxJ4+4+ra/reScD//o6+kUh8fEC0o52gfUM 0LRA== X-Gm-Message-State: AOAM5330HLoRhYqpcqsIHRqLnPRzBg3NwDseZ/nI5zJZH342o+4OCMZU 62kqK6opmC4/lGUhdJYzbj5M3if1okaKPLvgIRjV4LnxOjuKUNicHSsz7KPp/zzQvzcN3O1UH+D Pphj/wUhu3M0dPw== X-Received: by 2002:a1c:acc5:: with SMTP id v188mr1191971wme.60.1622104902535; Thu, 27 May 2021 01:41:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxg3A67adGRY7/RYd84cDkYJUU+ZbSr14losKB2TTk9FcyzOKk9N5gft1uP6ebKKPXFTQsA1g== X-Received: by 2002:a1c:acc5:: with SMTP id v188mr1191955wme.60.1622104902350; Thu, 27 May 2021 01:41:42 -0700 (PDT) Return-Path: Received: from [192.168.1.36] (235.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.235]) by smtp.gmail.com with ESMTPSA id a11sm2159192wra.96.2021.05.27.01.41.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 May 2021 01:41:42 -0700 (PDT) Subject: Re: [PATCH 10/43] OvmfPkg/AcpiPlatformDxe: consolidate #includes and [LibraryClasses] To: Laszlo Ersek , devel@edk2.groups.io Cc: Ard Biesheuvel , Jordan Justen References: <20210526201446.12554-1-lersek@redhat.com> <20210526201446.12554-11-lersek@redhat.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Message-ID: <602abd61-ceec-4761-eedb-0b8436e16b90@redhat.com> Date: Thu, 27 May 2021 10:41:41 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20210526201446.12554-11-lersek@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 5/26/21 10:14 PM, Laszlo Ersek wrote: > - #include only such public headers in "AcpiPlatform.h" that are required > by the function declarations and type definitions introduced in > "AcpiPlatform.h". Don't use "AcpiPlatform.h" as a convenience #include > file. > > - In every file, list every necessary public #include individually, with > an example identifier that's actually consumed. > > - Remove unnecessary lib classes, add unlisted lib classes. > > - Remove unnecessary #include directives, add unlisted #include > directives. > > Cc: Ard Biesheuvel > Cc: Jordan Justen > Cc: Philippe Mathieu-Daudé > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2122 > Signed-off-by: Laszlo Ersek > --- > OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf | 1 - > OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpiPlatformDxe.inf | 2 ++ > OvmfPkg/AcpiPlatformDxe/AcpiPlatform.h | 12 ++---------- > OvmfPkg/AcpiPlatformDxe/AcpiPlatform.c | 5 +++++ > OvmfPkg/AcpiPlatformDxe/BootScript.c | 7 ++++--- > OvmfPkg/AcpiPlatformDxe/EntryPoint.c | 6 +++++- > OvmfPkg/AcpiPlatformDxe/PciDecoding.c | 4 +++- > OvmfPkg/AcpiPlatformDxe/Qemu.c | 14 +++++++------- > OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpi.c | 19 ++++++++++--------- > OvmfPkg/AcpiPlatformDxe/Xen.c | 4 +++- > 10 files changed, 41 insertions(+), 33 deletions(-) Reviewed-by: Philippe Mathieu-Daude