From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mx.groups.io with SMTP id smtpd.web11.5887.1589427356867896640 for ; Wed, 13 May 2020 20:35:57 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: kaix.yau@intel.com) IronPort-SDR: 3S8HjpVDKbRWiVDtMVtHN8f0py39EXcDPIXcD1jKBjxymA0AOeUlwgcRqQ8iaAA0wGlHud4/M7 pDzB1/rintrQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 May 2020 20:35:56 -0700 IronPort-SDR: xMIRpBpypl4PX+bSXR2mFtcjDJQSLFrHX/7JX4X/jO/AXbvDHhI4EOSkp++4Mmo6lSKfxdclSp qTXPVkf7wZtQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,390,1583222400"; d="scan'208";a="266098921" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga006.jf.intel.com with ESMTP; 13 May 2020 20:35:55 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 13 May 2020 20:35:55 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 13 May 2020 20:35:54 -0700 Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmsx601.amr.corp.intel.com ([10.18.126.81]) with mapi id 15.01.1713.004; Wed, 13 May 2020 20:35:54 -0700 From: "Yau, KaiX" To: "Ni, Ray" , "devel@edk2.groups.io" , "kaiyau@gmail.com" CC: "Jiang, Guomin" , "Gao, Liming" , "Archield, Ralphal" , "Zhao, Lijian" Subject: Re: [edk2-devel] [PATCH] PcAtChipsetPkg: Wrong System YEAR displayed in SETUP Thread-Topic: [edk2-devel] [PATCH] PcAtChipsetPkg: Wrong System YEAR displayed in SETUP Thread-Index: AQHV/mhcwW9QFsxhHkms/DTjASpqC6iNGC0A//+XApCAF8k1AP//i0oQgAC0wYD//4t0kAA8LaEAAA6L/TD//6GZgIAAaPkg///e1YD///HiIIABOZ+AgABz4fA= Date: Thu, 14 May 2020 03:35:54 +0000 Message-ID: <60626824a24d48e69db0b3745b216921@intel.com> References: <50102ef8b38c0e5287ab4d1cb8fc636213f67299.1584672719.git.kaix.yau@intel.com> <734D49CCEBEEF84792F5B80ED585239D5C51152B@SHSMSX104.ccr.corp.intel.com> <3f6385f623054e24b44a375765246d2f@intel.com> <734D49CCEBEEF84792F5B80ED585239D5C53809A@SHSMSX104.ccr.corp.intel.com> <734D49CCEBEEF84792F5B80ED585239D5C53887A@SHSMSX104.ccr.corp.intel.com> <734D49CCEBEEF84792F5B80ED585239D5C53A7C4@SHSMSX104.ccr.corp.intel.com> <213de571cb0b4471852cb3b8c616a8da@intel.com> <734D49CCEBEEF84792F5B80ED585239D5C53A9CE@SHSMSX104.ccr.corp.intel.com> <734D49CCEBEEF84792F5B80ED585239D5C53B2D9@SHSMSX104.ccr.corp.intel.com> <734D49CCEBEEF84792F5B80ED585239D5C54B533@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <734D49CCEBEEF84792F5B80ED585239D5C54B533@SHSMSX104.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.2.0.6 dlp-product: dlpe-windows x-originating-ip: [10.22.254.132] MIME-Version: 1.0 Return-Path: kaix.yau@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Ray, I read your comment from gitk. I understand why you changed them to 1998 and 2097. May I know why we don't read the Century value from CMOS in the beginning?= =20 Some boards does not support? Or the RTC address may be different for d= ifferent boards? Regards Kai Yau -----Original Message----- From: Ni, Ray =20 Sent: Wednesday, May 13, 2020 10:55 PM To: Yau, KaiX ; devel@edk2.groups.io; kaiyau@gmail.com Cc: Jiang, Guomin ; Gao, Liming ; Archield, Ralphal ; Zhao, Lijian Subject: RE: [edk2-devel] [PATCH] PcAtChipsetPkg: Wrong System YEAR display= ed in SETUP Kai, I created the initial design and made the initial change: using the two PCD= to help code decide the correct century value. More comments below. > -----Original Message----- > From: Yau, KaiX > Sent: Thursday, May 14, 2020 1:14 AM > To: Ni, Ray ; devel@edk2.groups.io; kaiyau@gmail.com > Cc: Jiang, Guomin ; Gao, Liming=20 > ; Archield, Ralphal=20 > ; Zhao, Lijian > Subject: RE: [edk2-devel] [PATCH] PcAtChipsetPkg: Wrong System YEAR=20 > displayed in SETUP >=20 > Hi, >=20 > The current logic has two limitations: > 1. it has to be 100 years apart (already mentioned in DEC file) I agree it's a limitation. I don't want to solve this limitation with curre= nt RTC HW. > 2. the century numbers have to be same in order to work. (19XX, 20XX=20 > will not work) (20xx, 21xx will not work) Since now is 2020, the value ha= s to be 2000, 2099. But BIOS developers does not know this limitation. I don't agree. Let's forget other argue points and just focus on this point= . Can you please explain why with the PCD value (1998,2097) cannot support th= is year 2020?