public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Haojian Zhuang <haojian.zhuang@linaro.org>
To: Jun Nie <jun.nie@linaro.org>,
	olivier.martin@arm.com, edk2-devel@lists.01.org
Cc: shawn.guo@linaro.org, jason.liu@linaro.org
Subject: Re: [PATCH] EmbeddedPkg/MmcDxe: Add alignment for ECSD data
Date: Thu, 8 Jun 2017 17:54:07 +0800	[thread overview]
Message-ID: <608c15e9-95f4-873b-00a0-4e1bf7341ead@linaro.org> (raw)
In-Reply-To: <1496909927-16812-1-git-send-email-jun.nie@linaro.org>

On 2017/6/8 16:18, Jun Nie wrote:
> Add alignment for ECSD data for DMA access. Otherwise
> the data is corrupted on Sanechips platform.
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Jun Nie <jun.nie@linaro.org>
> ---
>   EmbeddedPkg/Universal/MmcDxe/Mmc.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/EmbeddedPkg/Universal/MmcDxe/Mmc.h b/EmbeddedPkg/Universal/MmcDxe/Mmc.h
> index 8a7d5a3..ca1a9d5 100644
> --- a/EmbeddedPkg/Universal/MmcDxe/Mmc.h
> +++ b/EmbeddedPkg/Universal/MmcDxe/Mmc.h
> @@ -319,7 +319,7 @@ typedef struct  {
>     OCR       OCRData;
>     CID       CIDData;
>     CSD       CSDData;
> -  ECSD      ECSDData;                         // MMC V4 extended card specific
> +  ECSD      ECSDData __attribute__((aligned(8)));  // MMC V4 extended card specific
>   } CARD_INFO;
>   
>   typedef struct _MMC_HOST_INSTANCE {
> 

Acked-by: Haojian Zhuang <haojian.zhuang@linaro.org>


  reply	other threads:[~2017-06-08 10:50 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-08  8:18 [PATCH] EmbeddedPkg/MmcDxe: Add alignment for ECSD data Jun Nie
2017-06-08  9:54 ` Haojian Zhuang [this message]
2017-06-08 14:55 ` Andrew Fish
2017-06-08 16:35   ` Leif Lindholm
2017-06-09  3:55   ` Jun Nie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=608c15e9-95f4-873b-00a0-4e1bf7341ead@linaro.org \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox