From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 0EFC97803D7 for ; Thu, 1 Aug 2024 14:52:04 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=UiTr7ADI3i4KWCFel1iagq7LwDiJdp1X3pAm+595jrk=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:CC:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1722523924; v=1; b=h18gZ3ipspwDz0CkVDUkqwJkGqLiR/dlujsYfCzS4tKEx2GGkxY4EyDtXA/Wid1wl904UULz WF4+7Yk8WkDl9epX3/PG0v4iSVCNRDHaWOq+JVLh441QwpeQoxe/FDEY9zo13VpmSXB1XT5TeIT 3YoNjtLUeDdx+rcQLSdV83irsqBoK5wr3TocwVBKmLXA+Se/LjkJfRlXicM33sjMMlyGcvZy+gG EXfbFLp2/oPxNPQx0QNRdrDA7kzuSwslgLYOAmSnocokG2RG9Yz1l/ipSHuD954jw7T6D9ZiS1b bbAzJlmYKFjbyHN0xhHPFj7JVr84iUQIne5UD+6EZzv7w== X-Received: by 127.0.0.2 with SMTP id fpE0YY7687511xQymiR5Zomm; Thu, 01 Aug 2024 07:52:03 -0700 X-Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by mx.groups.io with SMTP id smtpd.web11.70225.1722523922513351688 for ; Thu, 01 Aug 2024 07:52:02 -0700 X-Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 471DaXS3028637; Thu, 1 Aug 2024 14:52:00 GMT X-Received: from nasanppmta01.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 40qkv0vhpk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 01 Aug 2024 14:51:59 +0000 (GMT) X-Received: from nasanex01c.na.qualcomm.com (nasanex01c.na.qualcomm.com [10.45.79.139]) by NASANPPMTA01.qualcomm.com (8.17.1.19/8.17.1.19) with ESMTPS id 471EpxvX029466 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 1 Aug 2024 14:51:59 GMT X-Received: from [10.251.40.131] (10.80.80.8) by nasanex01c.na.qualcomm.com (10.45.79.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Thu, 1 Aug 2024 07:51:58 -0700 Message-ID: <60936941-62b3-4ed8-b1b2-4175ff70165f@quicinc.com> Date: Thu, 1 Aug 2024 15:51:55 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH edk2-platforms v2 1/1] Move to the GitHub Pull Request workflow To: Rebecca Cran CC: , Michael D Kinney References: <20240727203158.56002-1-rebecca@bsdio.com> <20240727203158.56002-2-rebecca@bsdio.com> From: "Leif Lindholm" In-Reply-To: X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nasanex01c.na.qualcomm.com (10.45.79.139) X-QCInternal: smtphost X-Proofpoint-ORIG-GUID: EwGKPOMQkUd7ZvTnamYCblEGaiJFfL9w X-Proofpoint-GUID: EwGKPOMQkUd7ZvTnamYCblEGaiJFfL9w X-MIME-Autoconverted: from 8bit to quoted-printable by mx0a-0031df01.pphosted.com id 471DaXS3028637 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Thu, 01 Aug 2024 07:52:02 -0700 Resent-From: quic_llindhol@quicinc.com Reply-To: devel@edk2.groups.io,quic_llindhol@quicinc.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: k0ChmpHcRIaaF9gvqU7LkxkTx7686176AA= Content-Language: en-GB Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=h18gZ3ip; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=quicinc.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io On 2024-08-01 13:49, Rebecca Cran wrote: > Replies inline. >=20 > On 8/1/24 3:45 AM, Leif Lindholm wrote: >> On Sat, Jul 27, 2024 at 14:31:56 -0600, Rebecca Cran wrote: >>> Migrate data from Maintainers.txt to the GitHub standard CODEOWNERS >>> files plus REVIEWERS and CONTRIBUTORS.md. The latter file contains >>> mappings from name to email address and GitHub usernames, which will >>> help people who want to email maintainers instead of using GitHub. >>> >>> Add .github/workflows/AssignReviewers.yml which adds reviewers to a >>> Pull Request based on the content of the REVIEWERS file. >>> >>> Signed-off-by: Rebecca Cran >>> --- >>> =C2=A0 .github/workflows/AssignReviewers.yml |=C2=A0 28 ++ >>> =C2=A0 CODEOWNERS=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | 146 +++++++ >>> =C2=A0 CONTRIBUTORS.md=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0 |=C2=A0 68 +++ >>> =C2=A0 Maintainers.txt=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0 | 445 -------------------- >>> =C2=A0 REVIEWERS=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0 92 ++++ >>> =C2=A0 Readme.md=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0 32 +- >>> =C2=A0 6 files changed, 361 insertions(+), 450 deletions(-) >>> >>> diff --git a/.github/workflows/AssignReviewers.yml=20 >>> b/.github/workflows/AssignReviewers.yml >>> new file mode 100644 >>> index 000000000000..8ee95edbb2c1 >>> --- /dev/null >>> +++ b/.github/workflows/AssignReviewers.yml >>> @@ -0,0 +1,28 @@ >>> +## @file >>> +# Assign reviewers from a REVIEWERS file using CODEOWNERS syntax >> If we're starting to do manual copying around of files between >> repositories, can we add a manual audit trail? >> >> I.e., full URL of repository, path inside repository, and commit hash? >> >> I think my preference would be in this file header. >=20 > I'm not sure I understand. This file came from=20 > https://github.com/mdkinney/github-action-assign-reviewers/blob/main/.git= hub/workflows/AssignReviewers.yml. >=20 > Would you like me to add a note to .github/workflows/AssignReviewers.yml= =20 > to say that's where it came from? I'd like to see it added *somewhere*. Where it came from and the (short)=20 commit hash at the version you picked. If we add it here, then it becomes immediately visible as something to=20 update if someone later on copies a newer version on top of it. Ultimately we might want to add things like this to a common repository=20 either directly referenced by CI/codeforge or imported as submodules, so=20 that we aren't needing to copy code arounbd between repositories. But that's not for this patch to resolve. >>> diff --git a/CODEOWNERS b/CODEOWNERS >>> new file mode 100644 >>> index 000000000000..bc86dd113398 >>> --- /dev/null >>> +++ b/CODEOWNERS >>> @@ -0,0 +1,146 @@ >>> ... >>> +# Sophgo platforms and silicon >>> +/Platform/Sophgo/** @vlsunil >>> +/Silicon/Sophgo/SG2042Pkg/** @vlsunil >> Not super important, but if we're doing this change it would be an >> opportunity to re-sort the areas alphabetically, since that broke >> somewhere along the way. >=20 > Fixed. Thanks! >>> diff --git a/CONTRIBUTORS.md b/CONTRIBUTORS.md >>> new file mode 100644 >>> index 000000000000..84882bcab2fa >>> --- /dev/null >>> +++ b/CONTRIBUTORS.md >>> @@ -0,0 +1,68 @@ >>> +EDK II Platforms Maintainers and Reviewers >>> +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D >>> + >>> +This file provides information about the people who maintain and revie= w >>> +code for EDK II Platforms. For information about who from this file >>> +maintains (i.e. owns and can commit changes) and who reviews changes i= n >>> +various parts of the repo, see the CODEOWNERS and REVIEWERS files. >>> + >>> +| Name=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | e-mail address=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0 | Github=20 >>> username=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0 | >>> +|------------------------|----------------------------------|---------= ---------------------------------------------| >>> +| Leif Lindholm=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 = | quic_llindhol@quicinc.com=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=20 >>> [@leiflindholm](https://github.com/leiflindholm)=C2=A0=C2=A0=C2=A0=C2= =A0 | ... >>> +| Marvin H??user=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= | mhaeuser@posteo.de=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=20 >>> [@mhaeuser](https://github.com/mhaeuser)=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | >> Is this charset corruption only in the email? > > Yes. See=20 > https://github.com/bcran/edk2-platforms/blob/github-pr/CONTRIBUTORS.md . Cool, no issue then. >>> +| Sai Chaganty=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 | rangasai.v.chaganty@intel.com=C2=A0=C2=A0=C2=A0 |=20 ... >>> +| USER0FISH=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0 | libing1202@outlook.com=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=20 >>> [@USER0FISH](https://github.com/USER0FISH)=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | >> Likewise, could we sort this alphabetically by name string? >> (If that's annoying, can you push it to a branch where I could pull it >> down and sort it?) >=20 > Done. Took about 30 seconds (column select mode, copy lines to a file,=20 > run through `sort`) :) Excellent, thanks! >>> diff --git a/Maintainers.txt b/Maintainers.txt >>> deleted file mode 100644 >>> index 824838486072..000000000000 >>> --- a/Maintainers.txt >>> +++ /dev/null >>> @@ -1,445 +0,0 @@ >>> ,,, >>> -Any contributions to this branch should be submitted via email to the >>> -edk2-devel mailing list with a subject prefix of `[platforms]`. See >>> -[Laszlo's excellent=20 >>> guide](https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-u= nkempt-git-guide-for-edk2-contributors-and-maintainers) for details >>> -on how to do this successfully. >>> +Any contributions to this branch should be submitted via GitHub Pull= =20 >>> Request, >>> +or email to the edk2-devel mailing list with a subject prefix of=20 >>> `[platforms]`. See >>> +[Laszlo's excellent=20 >>> guide](https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-u= nkempt-git-guide-for-edk2-contributors-and-maintainers) for details on how = to do this successfully. >> Can you put back this line break? > Fixed. >=20 >>> + >>> +For details of who owns code in certain parts of the repo, see the=20 >>> CODEOWNERS and >>> +REVIEWERS files. Look in CONTRIBUTORS.md to find out people's names=20 >>> and their >>> +email addresses. >>> + >>> +In general, you should not privately email the maintainer. You should >>> +email the edk2-devel list, and Cc the package maintainers and >>> +reviewers. >>> + >>> +If the package maintainer wants to hand over the role to other people, >> Strictly speaking, the maintainership areas aren't broken up on a >> package granularity here. >=20 > I've dropped the 'package' wording in favor of "area". That works. / Leif -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#120178): https://edk2.groups.io/g/devel/message/120178 Mute This Topic: https://groups.io/mt/107583542/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-