From: "Sami Mujawar" <sami.mujawar@arm.com>
To: Joey Gouly <Joey.Gouly@arm.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "ray.ni@intel.com" <ray.ni@intel.com>, nd <nd@arm.com>,
"zhichao.gao@intel.com" <zhichao.gao@intel.com>,
Alexei Fedorov <Alexei.Fedorov@arm.com>
Subject: Re: [PATCH v1 2/4] DynamicTablesPkg: Add access size to CM_ARM_SERIAL_PORT_INFO
Date: Fri, 16 Apr 2021 11:51:09 +0000 [thread overview]
Message-ID: <60F11D25-ED0A-4469-BB92-E4FB75014F7F@arm.com> (raw)
In-Reply-To: <20210415121720.11553-3-joey.gouly@arm.com>
Hi Joey,
This patch looks good to me.
Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
Regards,
Sami Mujawar
On 15/04/2021, 13:19, "Joey Gouly" <joey.gouly@arm.com> wrote:
Add access size to CM_ARM_SERIAL_PORT_INFO so that this can be
passed down to the Generic Address Structure.
Signed-off-by: Joey Gouly <joey.gouly@arm.com>
---
DynamicTablesPkg/Include/ArmNameSpaceObjects.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/DynamicTablesPkg/Include/ArmNameSpaceObjects.h b/DynamicTablesPkg/Include/ArmNameSpaceObjects.h
index afcfe3704cb908afb1e6b17e6771b2ebe3f67f76..19dcae13b2191e5f0b03ea85edec1191d2a406bf 100644
--- a/DynamicTablesPkg/Include/ArmNameSpaceObjects.h
+++ b/DynamicTablesPkg/Include/ArmNameSpaceObjects.h
@@ -293,6 +293,9 @@ typedef struct CmArmSerialPortInfo {
/// The Base address length
UINT64 BaseAddressLength;
+
+ /// The access size
+ UINT8 AccessSize;
} CM_ARM_SERIAL_PORT_INFO;
/** A structure that describes the
--
Guid("CE165669-3EF3-493F-B85D-6190EE5B9759")
next prev parent reply other threads:[~2021-04-16 11:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-15 12:17 [PATCH v1 0/4] DynamicTablesPkg: Add access size parameter for serial ports Joey Gouly
2021-04-15 12:17 ` [PATCH v1 1/4] ShellPkg: Rename Address Size to Access size Joey Gouly
2021-04-15 12:28 ` Sami Mujawar
[not found] ` <167607D852D7D23D.10637@groups.io>
2021-04-16 11:43 ` [edk2-devel] " Sami Mujawar
2021-04-19 3:17 ` Gao, Zhichao
2021-04-15 12:17 ` [PATCH v1 2/4] DynamicTablesPkg: Add access size to CM_ARM_SERIAL_PORT_INFO Joey Gouly
2021-04-16 11:51 ` Sami Mujawar [this message]
2021-04-15 12:17 ` [PATCH v1 3/4] DynamicTablesPkg: Set the Access size for the SPCR table Joey Gouly
2021-04-16 11:51 ` Sami Mujawar
2021-04-15 12:17 ` [PATCH v1 4/4] DynamicTablesPkg: Set the Access size for the DBG2 table Joey Gouly
2021-04-16 11:52 ` Sami Mujawar
2021-04-19 14:37 ` [PATCH v1 0/4] DynamicTablesPkg: Add access size parameter for serial ports Sami Mujawar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60F11D25-ED0A-4469-BB92-E4FB75014F7F@arm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox