From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by mx.groups.io with SMTP id smtpd.web12.50979.1643734513430602023
 for <devel@edk2.groups.io>;
 Tue, 01 Feb 2022 08:55:13 -0800
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: pierre.gondois@arm.com)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
	by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 17A046D;
	Tue,  1 Feb 2022 08:55:13 -0800 (PST)
Received: from [192.168.1.11] (unknown [172.31.20.19])
	by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B52963F40C;
	Tue,  1 Feb 2022 08:55:11 -0800 (PST)
Subject: Re: [edk2-devel] [PATCH v3 5/8] ArmVirtPkg/Kvmtool: Add DSDT ACPI table
To: Sami Mujawar <Sami.Mujawar@arm.com>, Rebecca Cran
 <quic_rcran@quicinc.com>, "devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>, nd <nd@arm.com>
References: <20220128154103.20752-1-Pierre.Gondois@arm.com>
 <20220128154103.20752-6-Pierre.Gondois@arm.com>
 <52503b9c-c820-15b3-65c5-f2cc110f5027@quicinc.com>
 <AS8PR08MB68061AC2D3F8B0717B17166984259@AS8PR08MB6806.eurprd08.prod.outlook.com>
From: "PierreGondois" <pierre.gondois@arm.com>
Message-ID: <60a12a54-1860-f7b8-f4f1-144cf19f347f@arm.com>
Date: Tue, 1 Feb 2022 17:55:26 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <AS8PR08MB68061AC2D3F8B0717B17166984259@AS8PR08MB6806.eurprd08.prod.outlook.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit

Hi Rebecca,

On 1/31/22 4:21 PM, Sami Mujawar wrote:
> Hi Rebecca,
> 
> Thanks for catching this.
> 
> I think we also need to adda check in Acpiview to report this issue. However,
> that would be another patch series.
> 
> Regards,
> 
> Sami Mujawar
> 
> *From: *Rebecca Cran <quic_rcran@quicinc.com>
> *Date: *Monday, 31 January 2022 at 15:17
> *To: *devel@edk2.groups.io <devel@edk2.groups.io>, Pierre Gondois
> <Pierre.Gondois@arm.com>
> *Cc: *Ard Biesheuvel <ardb+tianocore@kernel.org>, Sami Mujawar
> <Sami.Mujawar@arm.com>
> *Subject: *Re: [edk2-devel] [PATCH v3 5/8] ArmVirtPkg/Kvmtool: Add DSDT ACPI table
> 
> On 1/28/22 08:41, PierreGondois wrote:
> 
>> +  Differentiated System Description Table Fields (DSDT)
>> +
>> +  Copyright (c) 2021 - 2022, ARM Ltd. All rights reserved.<BR>
>> +    SPDX-License-Identifier: BSD-2-Clause-Patent
>> +
>> +**/
>> +
>> +DefinitionBlock ("DsdtTable.aml", "DSDT", 1, "ARMLTD", "ARM-KVMT", 1) {
> 
> The Revision field should probably be 2, not 1. ACPI 6.4 says:
> 
> 
> 2. This field also sets the global integer width for the AML
> interpreter. Values less than two will cause the inter-
> preter to use 32-bit integers and math. Values of two
> and greater will cause the interpreter to use full 64-bit
> integers and math.
> 
> -- 
> Rebecca Cran
> 

Yes indeed. I forgot to add it in the v4... I will send a v5.
Regards,
Pierre