public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Rebecca Cran" <quic_rcran@quicinc.com>
To: <devel@edk2.groups.io>, <isaac.w.oram@intel.com>
Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>,
	Nate DeSimone <nathaniel.l.desimone@intel.com>,
	Liming Gao <gaoliming@byosoft.com.cn>,
	Eric Dong <eric.dong@intel.com>, Dandan Bi <dandan.bi@intel.com>
Subject: Re: [edk2-devel][edk2-platforms][PATCH V1 1/1] Features/Intel: Prepare for edk2-platforms CI
Date: Fri, 13 Jan 2023 07:46:01 -0700	[thread overview]
Message-ID: <60a35774-1af6-b4cc-ed24-e74b6da643c5@quicinc.com> (raw)
In-Reply-To: <113a2e2caf5f3d6ae2f223478b7440c834a6cdc5.1673309073.git.isaac.w.oram@intel.com>

On 1/9/23 17:05, Isaac Oram wrote:

> --- /dev/null
> +++ b/Features/Intel/AdvancedFeaturePkg/Readme.md

...

> +## Windows Example:
> +With current working directory at O:\
> +
> +git clone https://github.com/tianocore/edk2.git
> +
> +git clone https://github.com/tianocore/edk2-platforms.git
> +
> +set workspace=O:\
> +
> +set EDK_TOOLS_PATH=O:\Edk2\BaseTools

Would "set workspace=%cd%" work better? That would avoid hard-coding the 
assumption that the workspace is on the O: drive.

Then, subsequent paths should be 
%workspace%\edk2;%workspace%\edk2-non-osi etc.

> +
> +set packages_path=O:\edk2;O:\edk2-non-osi;O:\edk2-platforms\Platform\Intel;O:\edk2-platforms\Silicon\Intel;O:\edk2-platforms\Platform\Qemu;O:\edk2-platforms\Silicon\Qemu;O:\edk2-platforms\Features\Intel;O:\edk2-platforms\Features\Intel\Debugging;O:\edk2-platforms\Features\Intel\Network;O:\edk2-platforms\Features\Intel\OutOfBandManagement;O:\edk2-platforms\Features\Intel\PowerManagement;O:\edk2-platforms\Features\Intel\SystemInformation;O:\edk2-platforms\Features\Intel\UserInterface
> +
> +cd \edk2

Either here or earlier you probably want to add a step of running "git 
submodule update --init" otherwise the Rebuild step below will fail.

-- 
Rebecca Cran

  parent reply	other threads:[~2023-01-13 14:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1673309073.git.isaac.w.oram@intel.com>
2023-01-10  0:05 ` [edk2-devel][edk2-platforms][PATCH V1 1/1] Features/Intel: Prepare for edk2-platforms CI Isaac Oram
2023-01-11 22:10   ` Chaganty, Rangasai V
2023-01-13  0:45     ` Isaac Oram
2023-01-13 14:46   ` Rebecca Cran [this message]
2023-01-18 23:20     ` Isaac Oram

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=60a35774-1af6-b4cc-ed24-e74b6da643c5@quicinc.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox