From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from alexa-out-sd-02.qualcomm.com (alexa-out-sd-02.qualcomm.com [199.106.114.39]) by mx.groups.io with SMTP id smtpd.web11.88558.1673621163123707029 for ; Fri, 13 Jan 2023 06:46:03 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@quicinc.com header.s=qcdkim header.b=VTH8St4p; spf=permerror, err=parse error for token &{10 18 %{ir}.%{v}.%{d}.spf.has.pphosted.com}: invalid domain name (domain: quicinc.com, ip: 199.106.114.39, mailfrom: quic_rcran@quicinc.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1673621163; x=1705157163; h=from:message-id:date:mime-version:subject:to:cc: references:in-reply-to:content-transfer-encoding; bh=lxvxfW5AQO8Y5X+YBUGPPT4zF086xhuhtKIjAt31OYQ=; b=VTH8St4pE0B0xVVPduP/3Qu6qVc9v83kLOgFVQsxeIftcNvt8iyTTYFB HncYl1Rx1Rv/uI81KSFK6P3/3LvIpjDh2EfTIk8cfEvNsjA50+cR7bWo/ DhLF0u1LBuRG4GwmCG0Kcti6s0dmvBwhS77olyYFEQsEe0KmUHbnuXBXB 0=; Received: from unknown (HELO ironmsg-SD-alpha.qualcomm.com) ([10.53.140.30]) by alexa-out-sd-02.qualcomm.com with ESMTP; 13 Jan 2023 06:46:02 -0800 From: "Rebecca Cran" X-QCInternal: smtphost Received: from nasanex01b.na.qualcomm.com ([10.46.141.250]) by ironmsg-SD-alpha.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jan 2023 06:46:02 -0800 Received: from [10.110.125.126] (10.80.80.8) by nasanex01b.na.qualcomm.com (10.46.141.250) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Fri, 13 Jan 2023 06:46:01 -0800 Message-ID: <60a35774-1af6-b4cc-ed24-e74b6da643c5@quicinc.com> Date: Fri, 13 Jan 2023 07:46:01 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [edk2-devel][edk2-platforms][PATCH V1 1/1] Features/Intel: Prepare for edk2-platforms CI To: , CC: Sai Chaganty , Nate DeSimone , Liming Gao , Eric Dong , Dandan Bi References: <113a2e2caf5f3d6ae2f223478b7440c834a6cdc5.1673309073.git.isaac.w.oram@intel.com> In-Reply-To: <113a2e2caf5f3d6ae2f223478b7440c834a6cdc5.1673309073.git.isaac.w.oram@intel.com> Return-Path: rebecca@quicinc.com X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nasanex01b.na.qualcomm.com (10.46.141.250) Content-Language: en-US Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit On 1/9/23 17:05, Isaac Oram wrote: > --- /dev/null > +++ b/Features/Intel/AdvancedFeaturePkg/Readme.md ... > +## Windows Example: > +With current working directory at O:\ > + > +git clone https://github.com/tianocore/edk2.git > + > +git clone https://github.com/tianocore/edk2-platforms.git > + > +set workspace=O:\ > + > +set EDK_TOOLS_PATH=O:\Edk2\BaseTools Would "set workspace=%cd%" work better? That would avoid hard-coding the assumption that the workspace is on the O: drive. Then, subsequent paths should be %workspace%\edk2;%workspace%\edk2-non-osi etc. > + > +set packages_path=O:\edk2;O:\edk2-non-osi;O:\edk2-platforms\Platform\Intel;O:\edk2-platforms\Silicon\Intel;O:\edk2-platforms\Platform\Qemu;O:\edk2-platforms\Silicon\Qemu;O:\edk2-platforms\Features\Intel;O:\edk2-platforms\Features\Intel\Debugging;O:\edk2-platforms\Features\Intel\Network;O:\edk2-platforms\Features\Intel\OutOfBandManagement;O:\edk2-platforms\Features\Intel\PowerManagement;O:\edk2-platforms\Features\Intel\SystemInformation;O:\edk2-platforms\Features\Intel\UserInterface > + > +cd \edk2 Either here or earlier you probably want to add a step of running "git submodule update --init" otherwise the Rebuild step below will fail. -- Rebecca Cran