From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f193.google.com (mail-qk1-f193.google.com [209.85.222.193]) by mx.groups.io with SMTP id smtpd.web11.3396.1608066896799366561 for ; Tue, 15 Dec 2020 13:14:57 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=kT9+5s8T; spf=pass (domain: nuviainc.com, ip: 209.85.222.193, mailfrom: rebecca@nuviainc.com) Received: by mail-qk1-f193.google.com with SMTP id d14so19959839qkc.13 for ; Tue, 15 Dec 2020 13:14:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=qWj1e7e1HPbiNMH0o6LfCAaSZM1JJ3GsvQI84cfugDU=; b=kT9+5s8TdtIDkOh3D6aBTR980rFFu5Xz6CRgKGjaZw9wuX60gjzKorwvbPFVPTAbSx nepuKgB8Hf8REaf3xYqtOHv0r92L3x/lLl4P3lxJHO6b6M/fxLTUjU3HnDtfCF+bupgH 5g4ZgmXHIjd8MBHwiIUKMhXzf4pN3qlZNjzcg3tJz3Tq6ls4Iv2Y4xDyic/tOHe2jsxy 2IEFti7JqSyWRWuGOMM6jOArgOYVDM8E4zpHtWiw1NYg1T/ffUKBjIznNgt0qj5jWopp XfEHi14tNBhsF3ErwfMk1MPQ/NWtxRQwbY/O6PYeXLnardm0/r+PY+OCZjmxCVt0nGq3 ASlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=qWj1e7e1HPbiNMH0o6LfCAaSZM1JJ3GsvQI84cfugDU=; b=eNDcG1atkU8RWj+QjsAch7EGMSnjC4oyPmK+KCZznHWlsITOERiDxRu2D6mDWxgDFK rO64LawZKjeFdnVBGfbu/wqiO+PardXeOwDe8M6G+sLhRIgI7b5x06jHjZxSTsglSKVK cdcz5ITPYiJ8L5gLcKNN2AuyJpniFwxTGus/+PN9/erBO46AoKlA1/GBaH3d5gQe8R/8 LA5WxguRDkJRScaqe3Yl87RuJi7/rEvpgl2JRVzpFdVnFndUc9eBD++PKrMSAB65Dux4 T7NgdBK08k2DqmBoEZkMW8nxlTYrsbmCTuTpfcqyuaE1cS/9gFuJyFEPp+Oeh7OsoAZD Gbzw== X-Gm-Message-State: AOAM532YVNboPNZRleRORZalng9n9YfMcpORiDtJTVZFxcXF5HfXk8Dd WA8k6K6BodCFB6XgZP9Zh96z7A== X-Google-Smtp-Source: ABdhPJyJeLYcxdBc2bRKFEfxBrJT0L6PrYCzwbpaRY7/vMEE/SidThT6Rcmkiny+LON7hoI7uUfP3w== X-Received: by 2002:a37:e504:: with SMTP id e4mr34559184qkg.191.1608066896043; Tue, 15 Dec 2020 13:14:56 -0800 (PST) Return-Path: Received: from [10.0.10.142] (c-174-52-16-57.hsd1.ut.comcast.net. [174.52.16.57]) by smtp.gmail.com with ESMTPSA id l20sm18200455qkj.19.2020.12.15.13.14.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 15 Dec 2020 13:14:55 -0800 (PST) Subject: Re: [PATCH v4 10/10] ArmPkg: Add Universal/Smbios, a generic SMBIOS library for ARM To: Leif Lindholm Cc: devel@edk2.groups.io, Michael D Kinney , Liming Gao , Zhiguang Liu , Ard Biesheuvel References: <20201207175427.28712-1-rebecca@nuviainc.com> <20201207175427.28712-11-rebecca@nuviainc.com> <20201215192947.GH1664@vanye> From: "Rebecca Cran" Message-ID: <60a6465f-202a-d60b-bea3-73001aeb7ca2@nuviainc.com> Date: Tue, 15 Dec 2020 14:14:37 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20201215192947.GH1664@vanye> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 12/15/20 12:29 PM, Leif Lindholm wrote: > On Mon, Dec 07, 2020 at 10:54:27 -0700, Rebecca Cran wrote: >> Much of the data for the SMBIOS tables is generic, and need not be >> duplicated for each platform. This patch series introduces >> ArmPkg/Universal/Smbios, which is largely copied from >> edk2-platforms/Silicon/HiSilicon/Drivers/Smbios and generates SMBIOS >> tables 0,1,2,3,4,713,32 and uses a combination of PCDs and calls into a >> new OemMiscLib to get information which varies between platforms. > > This is still a pretty massive patch to review. > Could you break it up into separate commits for each driver, and the > aforementioned OemMiscLibNull? Yes, I'll do that. -- Rebecca Cran