From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id E018721A07A88 for ; Sat, 1 Jul 2017 14:02:36 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 97234C04D2BD; Sat, 1 Jul 2017 21:04:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 97234C04D2BD Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=lersek@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 97234C04D2BD Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-56.phx2.redhat.com [10.3.116.56]) by smtp.corp.redhat.com (Postfix) with ESMTP id DD5F218114; Sat, 1 Jul 2017 21:04:09 +0000 (UTC) To: Ard Biesheuvel , "Leif Lindholm (Linaro address)" References: <20170629083221.485184-1-ruiyu.ni@intel.com> Cc: Ruiyu Ni , edk2-devel@lists.01.org, Hao Wu , "Jordan Justen (Intel address)" , Andrew Fish From: Laszlo Ersek Message-ID: <60ac3e5e-12b6-4bd5-6f7f-a7101b7c7edb@redhat.com> Date: Sat, 1 Jul 2017 23:04:08 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170629083221.485184-1-ruiyu.ni@intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Sat, 01 Jul 2017 21:04:11 +0000 (UTC) Subject: Re: [PATCH 0/3] MdeModulePkg/ResetSystem: Implement ResetNotification protocol X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 01 Jul 2017 21:02:37 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Ard, Leif, On 06/29/17 10:32, Ruiyu Ni wrote: > Ruiyu Ni (3): > MdePkg: Add ResetNotification protocol definition > MdeModulePkg/ResetSystem: Remove unnecessary global variable > MdeModulePkg/ResetSystem: Implement ResetNotification protocol > > .../Universal/ResetSystemRuntimeDxe/ResetSystem.c | 146 +++++++++++++++++++-- > .../Universal/ResetSystemRuntimeDxe/ResetSystem.h | 21 ++- > .../ResetSystemRuntimeDxe.inf | 5 +- > MdePkg/Include/Protocol/ResetNotification.h | 86 ++++++++++++ > MdePkg/MdePkg.dec | 3 + > 5 files changed, 247 insertions(+), 14 deletions(-) > create mode 100644 MdePkg/Include/Protocol/ResetNotification.h > I think we should - either port this feature (patch 3/3) to EmbeddedPkg/ResetRuntimeDxe, - or else rebase all platforms that consume EmbeddedPkg/ResetRuntimeDxe to MdeModulePkg/Universal/ResetSystemRuntimeDxe, and delete EmbeddedPkg/ResetRuntimeDxe from the tree. What do you guys think? Other producers of gEfiResetArchProtocolGuid could be affected as well (just from a quick grep): - DuetPkg/AcpiResetDxe - EmulatorPkg/ResetRuntimeDxe - Nt32Pkg/ResetRuntimeDxe Thanks Laszlo