From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mx.groups.io with SMTP id smtpd.web10.9954.1686147882394194617 for ; Wed, 07 Jun 2023 07:24:42 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="signature has expired" header.i=@bsdio.com header.s=fm2 header.b=2CAbCVyB; spf=pass (domain: bsdio.com, ip: 66.111.4.29, mailfrom: rebecca@bsdio.com) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id AB5535C0113; Wed, 7 Jun 2023 10:24:41 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Wed, 07 Jun 2023 10:24:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdio.com; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1686147881; x=1686234281; bh=Z9eFpQM8WRz2wxqvZ0kqoUX0FxzXydwQDOq m/pjDtxU=; b=2CAbCVyBBy8lgQ1laDG+dq2fGonZJbDwNQdLKXXuhVaX8w7LyW6 Cou3WGlj1glCa10dCzFSn6Lqkisl3k0SwA2fOIXeNxFKYff5nfhISrod9syviaV2 9clCHRzhw/BqcPvE5RMHRBjq8PfX5Rf6lW/sibT0yfFEIKCVdoE1pZKTzUc8N7T6 Li6TyYfDyJTAlJ2oPao2PHgXo1dX4hk9yxQLY5ad+seqAmotX7hntLWs6ou0EU8f DuGQ/M1nzV0rpHKc3F/BcpZ5VF5KUVxLHutvIVip2+JzpajkEjTYY2kx2O67u+dt upc4gCw5+l4YcIBKyBWuLqFOIVP6mCaFl6g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1686147881; x=1686234281; bh=Z9eFpQM8WRz2wxqvZ0kqoUX0FxzXydwQDOq m/pjDtxU=; b=gDX1AuiBVleEwr2zXlOZ0WjrfOwyg+kFIDwVqo+kbZN7WX1P/DT 3KwOb8auKfgeNgx7Uu3+2jkFMp0VGwP0RVgTDULKkViLkf1yXT9ENW3pFeiZeDgp U9Q0eSUJj/TXitugLxJxnaEMjgEMmQyhTvypsaAhdzFV4jFqklv6Scp9rjXlj24p R5uHipJzRJznoRuX8juXFzNoNaOUUrnQZVDpNzfvqMr6iZpKcQ4aBZaHWo+qxvee nMay80qnAskjLvX1TLX9o+Ap1p3JKUUEQ60EKdt/QSuS8us+XCTe1Y/MALJqprZg UgqSQjHNg/kkOjDDONLnNzv2ivSuKBcj7Gg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrgedtgedgjeehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtkeertddtfeejnecuhfhrohhmpeftvggs vggttggrucevrhgrnhcuoehrvggsvggttggrsegsshguihhordgtohhmqeenucggtffrrg htthgvrhhnpeeuhfevfefgtdegieetvdeuieeiffegleduueejkedugeefgeeuveeuffff ieelfeenucffohhmrghinhepughstgdrihhntgdpfhgufhdrihhntgenucevlhhushhtvg hrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehrvggsvggttggrsegsshgu ihhordgtohhm X-ME-Proxy: Feedback-ID: i5b994698:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 7 Jun 2023 10:24:40 -0400 (EDT) Message-ID: <60c51212-1100-0239-5fb8-41cb454a4773@bsdio.com> Date: Wed, 7 Jun 2023 08:24:38 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v2 1/1] OvmfPkg/Bhyve: include TPM driver To: =?UTF-8?Q?Corvin_K=c3=b6hne?= , devel@edk2.groups.io Cc: =?UTF-8?Q?Corvin_K=c3=b6hne?= , Ard Biesheuvel , Jiewen Yao , Jordan Justen , Gerd Hoffmann , Peter Grehan References: <20230607131719.514706-1-corvink@FreeBSD.org> <20230607131719.514706-2-corvink@FreeBSD.org> From: "Rebecca Cran" In-Reply-To: <20230607131719.514706-2-corvink@FreeBSD.org> Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Reviewed-by: Rebecca Cran -- Rebecca Cran On 6/7/23 07:17, Corvin Köhne wrote: > From: Corvin Köhne > > Bhyve will gain support for TPM emulation in the near future. Therefore, > prepare OVMF by copying all TPM driver used by qemu's OVMF DSC into the > bhyve OVMF DSC. > > Signed-off-by: Corvin Köhne > Cc: Ard Biesheuvel > Cc: Jiewen Yao > Cc: Jordan Justen > Cc: Gerd Hoffmann > Cc: Rebecca Cran > Cc: Peter Grehan > --- > OvmfPkg/Bhyve/BhyveX64.dsc | 17 +++++++++++++++-- > OvmfPkg/Bhyve/BhyveX64.fdf | 7 +++++++ > 2 files changed, 22 insertions(+), 2 deletions(-) > > diff --git a/OvmfPkg/Bhyve/BhyveX64.dsc b/OvmfPkg/Bhyve/BhyveX64.dsc > index 7b974706f958..7fa40998ae80 100644 > --- a/OvmfPkg/Bhyve/BhyveX64.dsc > +++ b/OvmfPkg/Bhyve/BhyveX64.dsc > @@ -32,6 +32,8 @@ [Defines] > DEFINE SMM_REQUIRE = FALSE > DEFINE SOURCE_DEBUG_ENABLE = FALSE > > +!include OvmfPkg/Include/Dsc/OvmfTpmDefines.dsc.inc > + > # > # Network definition > # > @@ -226,8 +228,7 @@ [LibraryClasses] > OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLib/BaseOrderedCollectionRedBlackTreeLib.inf > XenPlatformLib|OvmfPkg/Library/XenPlatformLib/XenPlatformLib.inf > > - Tcg2PhysicalPresenceLib|OvmfPkg/Library/Tcg2PhysicalPresenceLibNull/DxeTcg2PhysicalPresenceLib.inf > - TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf > +!include OvmfPkg/Include/Dsc/OvmfTpmLibs.dsc.inc > > [LibraryClasses.common] > BaseCryptLib|CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf > @@ -564,12 +565,17 @@ [PcdsDynamicDefault] > > gEfiSecurityPkgTokenSpaceGuid.PcdOptionRomImageVerificationPolicy|0x00 > > +!include OvmfPkg/Include/Dsc/OvmfTpmPcds.dsc.inc > + > # MdeModulePkg resolution sets up the system display resolution > gEfiMdeModulePkgTokenSpaceGuid.PcdVideoHorizontalResolution|0 > gEfiMdeModulePkgTokenSpaceGuid.PcdVideoVerticalResolution|0 > gEfiMdeModulePkgTokenSpaceGuid.PcdConOutRow|0 > gEfiMdeModulePkgTokenSpaceGuid.PcdConOutColumn|0 > > +[PcdsDynamicHii] > +!include OvmfPkg/Include/Dsc/OvmfTpmPcdsHii.dsc.inc > + > ################################################################################ > # > # Components Section - list of all EDK II Modules needed by this Platform. > @@ -609,6 +615,8 @@ [Components] > > } > > +!include OvmfPkg/Include/Dsc/OvmfTpmComponentsPei.dsc.inc > + > # > # DXE Phase modules > # > @@ -632,6 +640,7 @@ [Components] > !if $(SECURE_BOOT_ENABLE) == TRUE > NULL|SecurityPkg/Library/DxeImageVerificationLib/DxeImageVerificationLib.inf > !endif > +!include OvmfPkg/Include/Dsc/OvmfTpmSecurityStub.dsc.inc > } > > MdeModulePkg/Universal/EbcDxe/EbcDxe.inf > @@ -826,3 +835,7 @@ [Components] > NULL|MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLib.inf > } > > + # > + # TPM support > + # > +!include OvmfPkg/Include/Dsc/OvmfTpmComponentsDxe.dsc.inc > diff --git a/OvmfPkg/Bhyve/BhyveX64.fdf b/OvmfPkg/Bhyve/BhyveX64.fdf > index 3f6270c048cc..c62d5757092e 100644 > --- a/OvmfPkg/Bhyve/BhyveX64.fdf > +++ b/OvmfPkg/Bhyve/BhyveX64.fdf > @@ -158,6 +158,8 @@ [FV.PEIFV] > INF OvmfPkg/Bhyve/SmmAccess/SmmAccessPei.inf > !endif > > +!include OvmfPkg/Include/Fdf/OvmfTpmPei.fdf.inc > + > ################################################################################ > > [FV.DXEFV] > @@ -335,6 +337,11 @@ [FV.DXEFV] > INF MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRuntimeDxe.inf > !endif > > +# > +# TPM support > +# > +!include OvmfPkg/Include/Fdf/OvmfTpmDxe.fdf.inc > + > ################################################################################ > > [FV.FVMAIN_COMPACT]