Re: [PATCH] MdeModulePkg/PiSmmCore: AllocatePool should use MemoryType.

[Laszlo Ersek <lersek@redhat.com>]

On 12/02/16 03:03, Yao, Jiewen wrote:
> Thank you Laszlo.
> 
>  
> 
> This time, I did not use number purposely.
> 
>  
> 
> My thinking is that each patch resolves a specific problem. Although I
> fixed all of them at same time, they can be check in independently.

Ah! I looked briefly at the patches and was wondering about the
connection between them. And, I applied them all together and tested
them together.

When I applied them with "git am", I was slightly annoyed that I had to
rename the patches myself, because the file names didn't have numbers
(from the subject lines) and so "git am *" wouldn't keep the original order.

So apparently this was all intentional :) In the future I'd still
recommend to use numbers, also a cover letter, and in the cover letter
just state that the patches are independent. The subject on the cover
letter can be "various fixes" or some such.

Thanks!
Laszlo

> 
>  
> 
> Thank you
> 
> Yao Jiewen
> 
>  
> 
> *From:*Laszlo Ersek [mailto:lersek@redhat.com]
> *Sent:* Friday, December 2, 2016 5:51 AM
> *To:* Yao, Jiewen <jiewen.yao@intel.com>; edk2-devel@ml01.01.org
> *Cc:* Kinney, Michael D <michael.d.kinney@intel.com>; Fan, Jeff
> <jeff.fan@intel.com>
> *Subject:* Re: [edk2] [PATCH] MdeModulePkg/PiSmmCore: AllocatePool
> should use MemoryType.
> 
>  
> 
> On 12/01/16 09:23, Jiewen Yao wrote:
>> PiSmmCore supports page level protection based upon the Memory Type
>> (EfiRuntimeServicesCode/EfiRuntimeServicesData) and PE image.
>> 
>> However, the Memory Type information is ignored in AllocatePool().
>> If a caller calls AllocatePool with EfiRuntimeServicesCode,
>> the final memory is still allocated as EfiRuntimeServicesData.
>> 
>> This patch supports AllocatePool with EfiRuntimeServicesCode.
>> 
>> Cc: Jeff Fan <jeff.fan@intel.com <mailto:jeff.fan@intel.com>>
>> Cc: Michael D Kinney <michael.d.kinney@intel.com <mailto:michael.d.kinney@intel.com>>
>> Cc: Laszlo Ersek <lersek@redhat.com <mailto:lersek@redhat.com>>
>> Contributed-under: TianoCore Contribution Agreement 1.0
>> Signed-off-by: Jiewen Yao <jiewen.yao@intel.com <mailto:jiewen.yao@intel.com>>
>> ---
>>  MdeModulePkg/Core/PiSmmCore/PiSmmCore.h          |  13 ++-
>>  MdeModulePkg/Core/PiSmmCore/Pool.c               |  66 +++++++++---
>>  MdeModulePkg/Core/PiSmmCore/SmramProfileRecord.c | 114 +++++++++++---------
>>  3 files changed, 124 insertions(+), 69 deletions(-)
> 
> series
> Regression-tested-by: Laszlo Ersek <lersek@redhat.com
> <mailto:lersek@redhat.com>>
> 
> (Please make sure to number the patches in the series next time.)
> 
> Thanks
> Laszlo
>