From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 45BD281F4B for ; Fri, 2 Dec 2016 01:44:17 -0800 (PST) Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 67EF98FD0B; Fri, 2 Dec 2016 09:44:16 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-74.phx2.redhat.com [10.3.116.74]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id uB29iECZ025573; Fri, 2 Dec 2016 04:44:15 -0500 To: "Yao, Jiewen" , "edk2-devel@ml01.01.org" References: <1480580607-19928-1-git-send-email-jiewen.yao@intel.com> <74D8A39837DF1E4DA445A8C0B3885C50386DF3E3@shsmsx102.ccr.corp.intel.com> Cc: "Kinney, Michael D" , "Fan, Jeff" From: Laszlo Ersek Message-ID: <60cdf4c8-05b8-f11e-5206-f107f3ad5fab@redhat.com> Date: Fri, 2 Dec 2016 10:44:14 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <74D8A39837DF1E4DA445A8C0B3885C50386DF3E3@shsmsx102.ccr.corp.intel.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.26 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Fri, 02 Dec 2016 09:44:16 +0000 (UTC) Subject: Re: [PATCH] MdeModulePkg/PiSmmCore: AllocatePool should use MemoryType. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Dec 2016 09:44:17 -0000 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit On 12/02/16 03:03, Yao, Jiewen wrote: > Thank you Laszlo. > > > > This time, I did not use number purposely. > > > > My thinking is that each patch resolves a specific problem. Although I > fixed all of them at same time, they can be check in independently. Ah! I looked briefly at the patches and was wondering about the connection between them. And, I applied them all together and tested them together. When I applied them with "git am", I was slightly annoyed that I had to rename the patches myself, because the file names didn't have numbers (from the subject lines) and so "git am *" wouldn't keep the original order. So apparently this was all intentional :) In the future I'd still recommend to use numbers, also a cover letter, and in the cover letter just state that the patches are independent. The subject on the cover letter can be "various fixes" or some such. Thanks! Laszlo > > > > Thank you > > Yao Jiewen > > > > *From:*Laszlo Ersek [mailto:lersek@redhat.com] > *Sent:* Friday, December 2, 2016 5:51 AM > *To:* Yao, Jiewen ; edk2-devel@ml01.01.org > *Cc:* Kinney, Michael D ; Fan, Jeff > > *Subject:* Re: [edk2] [PATCH] MdeModulePkg/PiSmmCore: AllocatePool > should use MemoryType. > > > > On 12/01/16 09:23, Jiewen Yao wrote: >> PiSmmCore supports page level protection based upon the Memory Type >> (EfiRuntimeServicesCode/EfiRuntimeServicesData) and PE image. >> >> However, the Memory Type information is ignored in AllocatePool(). >> If a caller calls AllocatePool with EfiRuntimeServicesCode, >> the final memory is still allocated as EfiRuntimeServicesData. >> >> This patch supports AllocatePool with EfiRuntimeServicesCode. >> >> Cc: Jeff Fan > >> Cc: Michael D Kinney > >> Cc: Laszlo Ersek > >> Contributed-under: TianoCore Contribution Agreement 1.0 >> Signed-off-by: Jiewen Yao > >> --- >> MdeModulePkg/Core/PiSmmCore/PiSmmCore.h | 13 ++- >> MdeModulePkg/Core/PiSmmCore/Pool.c | 66 +++++++++--- >> MdeModulePkg/Core/PiSmmCore/SmramProfileRecord.c | 114 +++++++++++--------- >> 3 files changed, 124 insertions(+), 69 deletions(-) > > series > Regression-tested-by: Laszlo Ersek > > > (Please make sure to number the patches in the series next time.) > > Thanks > Laszlo >