From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.groups.io with SMTP id smtpd.web08.8381.1625587352282262325 for ; Tue, 06 Jul 2021 09:02:32 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=M7ZUMi5F; spf=pass (domain: redhat.com, ip: 216.205.24.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1625587351; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SI0I6RZcvAqGrdv+yrJq8sni0Zy4VpuooaPWkriD7xA=; b=M7ZUMi5F4GoHuALoO3faOt8PvHD0WzOMYeUJEJistappvSNIg/WVGEkaE6jl77DeY0njEa jyiPdqgdQrrWbx5P/hFqKyCGP3evIh5Ip7kozU48W+CFb29po7BSdb2vk9m1jTy71omgV6 Y4uQleQ54FjDV2qsHpal9Z+7ZtLRWas= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-477-smV8aH4aOEa5e4-Trj97fQ-1; Tue, 06 Jul 2021 12:02:26 -0400 X-MC-Unique: smV8aH4aOEa5e4-Trj97fQ-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0A2BB8015C6; Tue, 6 Jul 2021 16:02:24 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-113-54.ams2.redhat.com [10.36.113.54]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C0C3B5D6AD; Tue, 6 Jul 2021 16:02:21 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH 1/1] OvmfPkg: Remove unused print service driver (PrintDxe) To: devel@edk2.groups.io, philmd@redhat.com Cc: Ard Biesheuvel , Jordan Justen , Brijesh Singh , Erdem Aktas , James Bottomley , Jiewen Yao , Min Xu , Tom Lendacky References: <20210706095345.1109163-1-philmd@redhat.com> From: "Laszlo Ersek" Message-ID: <60dd70d6-313b-28bd-f8ec-a29379ec6bfd@redhat.com> Date: Tue, 6 Jul 2021 18:02:20 +0200 MIME-Version: 1.0 In-Reply-To: <20210706095345.1109163-1-philmd@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 07/06/21 11:53, Philippe Mathieu-Daudé wrote: > From: Philippe Mathieu-Daude > > The Print service driver is not used by OVMF, remove it. > > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Cc: Jordan Justen > Cc: Brijesh Singh > Cc: Erdem Aktas > Cc: James Bottomley > Cc: Jiewen Yao > Cc: Min Xu > Cc: Tom Lendacky > Suggested-by: Laszlo Ersek > Signed-off-by: Philippe Mathieu-Daude > --- > OvmfPkg/AmdSev/AmdSevX64.dsc | 1 - > OvmfPkg/OvmfPkgIa32.dsc | 1 - > OvmfPkg/OvmfPkgIa32X64.dsc | 1 - > OvmfPkg/OvmfPkgX64.dsc | 1 - > OvmfPkg/AmdSev/AmdSevX64.fdf | 1 - > OvmfPkg/OvmfPkgIa32.fdf | 1 - > OvmfPkg/OvmfPkgIa32X64.fdf | 1 - > OvmfPkg/OvmfPkgX64.fdf | 1 - > 8 files changed, 8 deletions(-) I think the same applies to all of the DSC/FDF files (basically, "platforms") under OvmfPkg -- including Bhyve and Xen. PrintDxe produces gEfiPrint2ProtocolGuid and gEfiPrint2SProtocolGuid, and those are consumed by the following PrintLib instance: MdeModulePkg/Library/DxePrintLibPrint2Protocol/DxePrintLibPrint2Protocol.inf However, none of the OVMF DSC files contain such a PrintLib class resolution, so none of the OVMF platforms need PrintDxe. Thanks, Laszlo > > diff --git a/OvmfPkg/AmdSev/AmdSevX64.dsc b/OvmfPkg/AmdSev/AmdSevX64.dsc > index 1d487befae08..d1974b4a6873 100644 > --- a/OvmfPkg/AmdSev/AmdSevX64.dsc > +++ b/OvmfPkg/AmdSev/AmdSevX64.dsc > @@ -722,7 +722,6 @@ [Components] > DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf > PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf > } > - MdeModulePkg/Universal/PrintDxe/PrintDxe.inf > MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf > MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf > MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf > diff --git a/OvmfPkg/OvmfPkgIa32.dsc b/OvmfPkg/OvmfPkgIa32.dsc > index f53efeae7986..dff4b97b37c0 100644 > --- a/OvmfPkg/OvmfPkgIa32.dsc > +++ b/OvmfPkg/OvmfPkgIa32.dsc > @@ -816,7 +816,6 @@ [Components] > DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf > PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf > } > - MdeModulePkg/Universal/PrintDxe/PrintDxe.inf > MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf > MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf > MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf > diff --git a/OvmfPkg/OvmfPkgIa32X64.dsc b/OvmfPkg/OvmfPkgIa32X64.dsc > index b3662e17f256..f3df655c990e 100644 > --- a/OvmfPkg/OvmfPkgIa32X64.dsc > +++ b/OvmfPkg/OvmfPkgIa32X64.dsc > @@ -830,7 +830,6 @@ [Components.X64] > DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf > PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf > } > - MdeModulePkg/Universal/PrintDxe/PrintDxe.inf > MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf > MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf > MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf > diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc > index 0a237a905866..dc9a2720f9b2 100644 > --- a/OvmfPkg/OvmfPkgX64.dsc > +++ b/OvmfPkg/OvmfPkgX64.dsc > @@ -828,7 +828,6 @@ [Components] > DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf > PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf > } > - MdeModulePkg/Universal/PrintDxe/PrintDxe.inf > MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf > MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf > MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf > diff --git a/OvmfPkg/AmdSev/AmdSevX64.fdf b/OvmfPkg/AmdSev/AmdSevX64.fdf > index 9977b0f00a18..42f120d016e1 100644 > --- a/OvmfPkg/AmdSev/AmdSevX64.fdf > +++ b/OvmfPkg/AmdSev/AmdSevX64.fdf > @@ -234,7 +234,6 @@ [FV.DXEFV] > INF MdeModulePkg/Application/UiApp/UiApp.inf > INF OvmfPkg/QemuKernelLoaderFsDxe/QemuKernelLoaderFsDxe.inf > INF MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf > -INF MdeModulePkg/Universal/PrintDxe/PrintDxe.inf > INF MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf > INF MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf > INF MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf > diff --git a/OvmfPkg/OvmfPkgIa32.fdf b/OvmfPkg/OvmfPkgIa32.fdf > index 04b41445ca34..031eb4225c53 100644 > --- a/OvmfPkg/OvmfPkgIa32.fdf > +++ b/OvmfPkg/OvmfPkgIa32.fdf > @@ -254,7 +254,6 @@ [FV.DXEFV] > INF MdeModulePkg/Application/UiApp/UiApp.inf > INF OvmfPkg/QemuKernelLoaderFsDxe/QemuKernelLoaderFsDxe.inf > INF MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf > -INF MdeModulePkg/Universal/PrintDxe/PrintDxe.inf > INF MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf > INF MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf > INF MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf > diff --git a/OvmfPkg/OvmfPkgIa32X64.fdf b/OvmfPkg/OvmfPkgIa32X64.fdf > index 02fd8f0c413e..7194f08e6024 100644 > --- a/OvmfPkg/OvmfPkgIa32X64.fdf > +++ b/OvmfPkg/OvmfPkgIa32X64.fdf > @@ -255,7 +255,6 @@ [FV.DXEFV] > INF MdeModulePkg/Application/UiApp/UiApp.inf > INF OvmfPkg/QemuKernelLoaderFsDxe/QemuKernelLoaderFsDxe.inf > INF MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf > -INF MdeModulePkg/Universal/PrintDxe/PrintDxe.inf > INF MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf > INF MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf > INF MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf > diff --git a/OvmfPkg/OvmfPkgX64.fdf b/OvmfPkg/OvmfPkgX64.fdf > index 5fa8c0895808..b304e3149d4f 100644 > --- a/OvmfPkg/OvmfPkgX64.fdf > +++ b/OvmfPkg/OvmfPkgX64.fdf > @@ -267,7 +267,6 @@ [FV.DXEFV] > INF MdeModulePkg/Application/UiApp/UiApp.inf > INF OvmfPkg/QemuKernelLoaderFsDxe/QemuKernelLoaderFsDxe.inf > INF MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf > -INF MdeModulePkg/Universal/PrintDxe/PrintDxe.inf > INF MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf > INF MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf > INF MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf >