From: "Rebecca Cran" <rebecca@nuviainc.com>
To: Leif Lindholm <leif@nuviainc.com>
Cc: devel@edk2.groups.io, Ard Biesheuvel <ardb+tianocore@kernel.org>
Subject: Re: [PATCH v2 2/3] ArmPkg: Rename some functions and parameters in OemMiscLib
Date: Sun, 21 Feb 2021 16:04:31 -0700 [thread overview]
Message-ID: <60e89245-a027-d082-9ece-bc9fed791583@nuviainc.com> (raw)
In-Reply-To: <20210221212153.GO1664@vanye>
On 2/21/21 2:21 PM, Leif Lindholm wrote:
> On Sat, Feb 20, 2021 at 20:28:59 -0700, Rebecca Cran wrote:
>> -UINT8
>> -GetChassisType (
>> - VOID
>> - )
>> -{
>> - EFI_STATUS Status;
>> - UINT8 ChassisType;
>> -
>> - Status = OemGetChassisType (&ChassisType);
>> - if (EFI_ERROR (Status)) {
>> - return 0;
>> - }
>> -
>> - return ChassisType;
>> -}
>> -
>
> This function is outright deleted, not renamed.
> Does this belong in another patch?
I think it belongs here: it was just a helper function for when
OemGetChassisType returned EFI_STATUS. Since it now returns the same
data as this function, we don't need it anymore.
--
Rebecca Cran
next prev parent reply other threads:[~2021-02-21 23:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-21 3:28 [PATCH v2 0/3] ArmPkg: Fix several issues in OemMiscLib Rebecca Cran
2021-02-21 3:28 ` [PATCH v2 1/3] ArmPkg: Fix ordering of return type and EFIAPI specifier " Rebecca Cran
2021-02-21 20:48 ` Leif Lindholm
2021-02-21 3:28 ` [PATCH v2 2/3] ArmPkg: Rename some functions and parameters " Rebecca Cran
2021-02-21 21:21 ` Leif Lindholm
2021-02-21 23:04 ` Rebecca Cran [this message]
2021-02-22 12:35 ` Leif Lindholm
2021-02-22 14:33 ` Rebecca Cran
2021-02-21 3:29 ` [PATCH v2 3/3] ArmPkg: Update OemGetChassisType function to return MISC_CHASSIS_TYPE Rebecca Cran
2021-02-21 21:36 ` Leif Lindholm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60e89245-a027-d082-9ece-bc9fed791583@nuviainc.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox