From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f181.google.com (mail-qk1-f181.google.com [209.85.222.181]) by mx.groups.io with SMTP id smtpd.web12.27400.1613948674212497757 for ; Sun, 21 Feb 2021 15:04:34 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=pC4vZBW0; spf=pass (domain: nuviainc.com, ip: 209.85.222.181, mailfrom: rebecca@nuviainc.com) Received: by mail-qk1-f181.google.com with SMTP id b14so11053586qkk.0 for ; Sun, 21 Feb 2021 15:04:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=M5Xctz8w+2TTQBHRsM3PPFuCkMGn9Sf09r4VsNMqTDA=; b=pC4vZBW0MhLnCiL4UB8M5NlFntZFRh9gbwSP77tHGFyNIW+pkxvskpFi3te+oE/ZNB WtuHnfoZrpBBCYsxar5J99AnuQI9GLgEC+e08psXE0ysRSQmCqJ0BPUnfzP/zZGsjVHS kgxW55mqddGiHW2vSQlbjh9soctS41aTbk1GxAKvtydwI7/0eqczaCBmppyHS4EGyveX GpkcjrS2NETy0SQxhtXhQmMaQdf/+x17YKEw4GgM9VQ+tWdLGR/0LynUE2xqCmcCcTTa P1SH+B+K8zfYmhOFscZnPsVfEJXmOFavg02pw2bTeOssuZQ1JLtPdVxEOf9hSUMrrOIY LudA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=M5Xctz8w+2TTQBHRsM3PPFuCkMGn9Sf09r4VsNMqTDA=; b=dATEoG4T/S1af32lBv/IiPlMhIOtFqRyH+h9Lz+ELhkIvNKSifwRSo5akf86eOomnj /UQDGuVgeQpcdycyFASLns/94/MrhM5NZf6j2hQ37QemQjmro+JGJ79laJx+F4Jbr7+S GkkbocXYKzULI6XUTCJpC18DL/bZ/xOG2M+VM///5cyx2vRZ72ncce4oMMDs45+g2BaZ qG15n+hl5bDlx1f8YK+e2dLJaT4io+SwqEz1pEW27Nh2KpZfwnmc90wgClOSfLLsN4+9 9cKGfAknH0M2Cy7tyut1xAbx/ZgHygOoel0rLSHL0MuWxlspQzZ319gIXcYkN/VKLHMO fJdw== X-Gm-Message-State: AOAM531Frx0q6fVHODrMh3ADmiUni0t2AJUnmrkL2VSFqjF/q12hRPsk 0bjJ9X9ga0yqbWzthg4/eriD3A== X-Google-Smtp-Source: ABdhPJxS6+SxGkduIBObeHhq8KGXEp62IOVXfGyDzRw8sydQsDKY05VDs5B6N2hv9kGLkAUPuEeqTw== X-Received: by 2002:a37:52d7:: with SMTP id g206mr18206999qkb.343.1613948673389; Sun, 21 Feb 2021 15:04:33 -0800 (PST) Return-Path: Received: from [10.0.10.142] (c-174-52-16-57.hsd1.ut.comcast.net. [174.52.16.57]) by smtp.gmail.com with ESMTPSA id n67sm11068257qkb.35.2021.02.21.15.04.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 21 Feb 2021 15:04:33 -0800 (PST) Subject: Re: [PATCH v2 2/3] ArmPkg: Rename some functions and parameters in OemMiscLib To: Leif Lindholm Cc: devel@edk2.groups.io, Ard Biesheuvel References: <20210221032900.6485-1-rebecca@nuviainc.com> <20210221032900.6485-3-rebecca@nuviainc.com> <20210221212153.GO1664@vanye> From: "Rebecca Cran" Message-ID: <60e89245-a027-d082-9ece-bc9fed791583@nuviainc.com> Date: Sun, 21 Feb 2021 16:04:31 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210221212153.GO1664@vanye> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 2/21/21 2:21 PM, Leif Lindholm wrote: > On Sat, Feb 20, 2021 at 20:28:59 -0700, Rebecca Cran wrote: >> -UINT8 >> -GetChassisType ( >> - VOID >> - ) >> -{ >> - EFI_STATUS Status; >> - UINT8 ChassisType; >> - >> - Status = OemGetChassisType (&ChassisType); >> - if (EFI_ERROR (Status)) { >> - return 0; >> - } >> - >> - return ChassisType; >> -} >> - > > This function is outright deleted, not renamed. > Does this belong in another patch? I think it belongs here: it was just a helper function for when OemGetChassisType returned EFI_STATUS. Since it now returns the same data as this function, we don't need it anymore. -- Rebecca Cran