From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from nwk-aaemail-lapp01.apple.com (nwk-aaemail-lapp01.apple.com [17.151.62.66]) by mx.groups.io with SMTP id smtpd.web10.8390.1596036105473780301 for ; Wed, 29 Jul 2020 08:21:45 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@apple.com header.s=20180706 header.b=UgEBGsk4; spf=pass (domain: apple.com, ip: 17.151.62.66, mailfrom: afish@apple.com) Received: from pps.filterd (nwk-aaemail-lapp01.apple.com [127.0.0.1]) by nwk-aaemail-lapp01.apple.com (8.16.0.43/8.16.0.42) with SMTP id 06TFFMNJ041817; Wed, 29 Jul 2020 08:21:41 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=apple.com; h=content-type : mime-version : subject : from : in-reply-to : date : cc : content-transfer-encoding : message-id : references : to; s=20180706; bh=1V8KAYuuob7N1tWn4HpAWpn7A7ysGH3jGzjJvKmsOXQ=; b=UgEBGsk4eIz+YrNPaDKdXdXsSa/SH2Ah9FCj9cFD3qfgx0yM3b2mr0vXHt0gufeV/3y9 jOZxg9wJmbFzygLz+xv/rPRJdXXaur9vRQhToAdwkV/uS05l6Cgndo+9hwi8LFuJOs5G Y5HohIEHUBrgN7Qu4I+YRK017N1fL77BmOF47IN5Hacws6VW/7QLZOmBjrGTRBEf7DZ/ lHQY8++g3/ZbzzI4aLsG82LFXlxk/BrK5JgktMi88EIGs2wTZ3H4vzLOtMKVVErLszRX 5riOTuMkqOxcCp+1PXbfxGLMC/K4KoPZuq+JH/PYj4q1st0EmEQe6N/qDZQI2BVTo1iu Yg== Received: from rn-mailsvcp-mta-lapp03.rno.apple.com (rn-mailsvcp-mta-lapp03.rno.apple.com [10.225.203.151]) by nwk-aaemail-lapp01.apple.com with ESMTP id 32gkp08t8g-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO); Wed, 29 Jul 2020 08:21:41 -0700 Received: from rn-mailsvcp-mmp-lapp04.rno.apple.com (rn-mailsvcp-mmp-lapp04.rno.apple.com [17.179.253.17]) by rn-mailsvcp-mta-lapp03.rno.apple.com (Oracle Communications Messaging Server 8.1.0.5.20200312 64bit (built Mar 12 2020)) with ESMTPS id <0QE800F43LC4HQ00@rn-mailsvcp-mta-lapp03.rno.apple.com>; Wed, 29 Jul 2020 08:21:40 -0700 (PDT) Received: from process_milters-daemon.rn-mailsvcp-mmp-lapp04.rno.apple.com by rn-mailsvcp-mmp-lapp04.rno.apple.com (Oracle Communications Messaging Server 8.1.0.5.20200312 64bit (built Mar 12 2020)) id <0QE800U00L9KNG00@rn-mailsvcp-mmp-lapp04.rno.apple.com>; Wed, 29 Jul 2020 08:21:40 -0700 (PDT) X-Va-A: X-Va-T-CD: e0acb9dc03d22e4581b62f3d752335f3 X-Va-E-CD: 66536f32f0b0bcc544e076009ad2beef X-Va-R-CD: 1f9cb5b31018f5179d5a68716218be9a X-Va-CD: 0 X-Va-ID: 1663aa51-7639-4e2c-9993-7439a1938d88 X-V-A: X-V-T-CD: e0acb9dc03d22e4581b62f3d752335f3 X-V-E-CD: 66536f32f0b0bcc544e076009ad2beef X-V-R-CD: 1f9cb5b31018f5179d5a68716218be9a X-V-CD: 0 X-V-ID: 44937400-eabc-4776-8c62-72daa625a460 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235,18.0.687 definitions=2020-07-29_10:2020-07-29,2020-07-29 signatures=0 Received: from [17.235.54.163] (unknown [17.235.54.163]) by rn-mailsvcp-mmp-lapp04.rno.apple.com (Oracle Communications Messaging Server 8.1.0.5.20200312 64bit (built Mar 12 2020)) with ESMTPSA id <0QE8007K0LC2NQ00@rn-mailsvcp-mmp-lapp04.rno.apple.com>; Wed, 29 Jul 2020 08:21:40 -0700 (PDT) MIME-version: 1.0 (Mac OS X Mail 13.4 \(3608.80.23.2.2\)) Subject: Re: [edk2-devel] [PATCH 00/15] Add a plugin LicenseCheck in open ci From: "Andrew Fish" In-reply-to: <42dff41e-b38a-cd08-2ed1-35d83385dfac@redhat.com> Date: Wed, 29 Jul 2020 08:21:38 -0700 Cc: Mike Kinney , "Gao, Liming" , "Zhang, Shenglei" , Sean Brogan , Bret Barkelew , "Dong, Eric" , "Gao, Zhichao" , "Yao, Jiewen" , Chao Zhang , Jordan Justen , Maciej Rabeda , "Wu, Jiaxin" , "Fu, Siyuan" , "Wang, Jian J" , "Wu, Hao A" , "Ni, Ray" , "Lu, XiaoyuX" , Ard Biesheuvel , Leif Lindholm Message-id: <61060829-B0CA-41EA-97D7-A1AF8B0D1FCD@apple.com> References: <20200720083709.17264-1-shenglei.zhang@intel.com> <42dff41e-b38a-cd08-2ed1-35d83385dfac@redhat.com> To: edk2-devel-groups-io , Laszlo Ersek X-Mailer: Apple Mail (2.3608.80.23.2.2) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235,18.0.687 definitions=2020-07-29_10:2020-07-29,2020-07-29 signatures=0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit > On Jul 29, 2020, at 2:21 AM, Laszlo Ersek wrote: > > On 07/29/20 03:32, Kinney, Michael D wrote: >> Hi Liming, >> >> There are exception to PatchCheck as well for line endings and tabs. >> >> Seems like a similar problem, and a single CI plugin could >> support all these cases. > > The exceptions for LicenseCheck are individual files that package > maintainers (and contributors too) could customize. The primary use case > is permitting generated files to have no SPDX tag at all. PatchCheck > does not have a customizable exception list; it only considers general > rules that apply to the whole tree. > > I did suggest "@file: generated" as a general marker for generated files > (which would opt them out of SPDX enforcement), here: > . > This sounds like a good plan for any file generated by the edk2. Thanks, Andrew Fish > I'm equally happy with an IgnoreFiles stanza in > "OvmfPkg/OvmfPkg.ci.yaml", or a marker like "@file: generated" in some > files under OvmfPkg. What's important to me is that we can control and > update the license checks for OvmfPkg/ files with OvmfPkg/ patches. That > is, in case we need to tweak the license check for some OvmfPkg/ file, > the corresponding patch should need OvmfPkg maintainer approval *only*. > Adding exceptions to PatchCheck has been difficult, as (a) it affects > all of edk2, (b) technically it needs to pass BaseTools review. > > With the license check, I'm happy to have the mechanism under BaseTools > and/or CI, but the policy should be per package. Again my sole > motivation at this time is generated files that we need to check in for > whatever reason. > > Thanks! > Laszlo > > > >