From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id AED8322361E78 for ; Thu, 8 Feb 2018 09:20:31 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 14975C047B94; Thu, 8 Feb 2018 17:26:11 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-94.phx2.redhat.com [10.3.116.94]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3E5C760C9F; Thu, 8 Feb 2018 17:26:08 +0000 (UTC) To: "Carsey, Jaben" , "edk2-devel@lists.01.org" Cc: "Ni, Ruiyu" , "Justen, Jordan L" , Brijesh Singh , Gary Lin , Ard Biesheuvel References: <20180207224435.10730-1-lersek@redhat.com> From: Laszlo Ersek Message-ID: <610d9ab4-f891-279a-fcf4-50ae4bff06cf@redhat.com> Date: Thu, 8 Feb 2018 18:26:07 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Thu, 08 Feb 2018 17:26:16 +0000 (UTC) Subject: Re: [PATCH v2 0/2] sync some function definitions with their declarations X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Feb 2018 17:20:32 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 02/08/18 16:14, Carsey, Jaben wrote: > Reviewed-by: Jaben Carsey Thank you all; series pushed as commit range de8373fa07f8..c0d221a34854. Laszlo >> -----Original Message----- >> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of >> Laszlo Ersek >> Sent: Wednesday, February 07, 2018 2:45 PM >> To: edk2-devel@lists.01.org >> Cc: Ni, Ruiyu ; Brijesh Singh ; >> Ard Biesheuvel ; Justen, Jordan L >> ; Gary Lin ; Carsey, Jaben >> >> Subject: [edk2] [PATCH v2 0/2] sync some function definitions with their >> declarations >> Importance: High >> >> Repo: https://github.com/lersek/edk2.git >> Branch: sync_defs_to_decls_v2 >> >> This is version 2 of the series that I posted earlier. Because that >> series didn't reach the list at all, due to SMTP issues on my end, I'm >> including the v1 blurb here: >> >>> The patches say it all, just a side remark up here: >>> >>> These errors would have been caught long ago if we had enabled the >>> "-Wmissing-prototypes" gcc option. >>> >>> (Unfortunately, we can't enable that option even now, because it -- >>> laudably -- forces the programmer to give internal linkage ("STATIC") >>> to their helper / local functions, and -- as we've learned -- some >>> versions of the the Visual Studio debugger choke on STATIC functions. >>> Thus, core modules basically never make their internal functions >>> STATIC.) >> >> The v2 changes are noted per patch. >> >> (This posting should hopefully reach the list; while the original SMTP >> issue remains undiagnosed, I attempted to put a work-around in place. >> Let's see if it works.) >> >> Cc: Ard Biesheuvel >> Cc: Brijesh Singh >> Cc: Gary Lin >> Cc: Jaben Carsey >> Cc: Jordan Justen >> Cc: Ruiyu Ni >> >> Thanks, >> Laszlo >> >> Laszlo Ersek (2): >> ShellPkg/UefiShellDebug1CommandsLib: sync Compress() definition with >> decl. >> OvmfPkg/PlatformPei: sync AmdSevInitialize() definition with >> declaration >> >> OvmfPkg/PlatformPei/AmdSev.c | 3 ++- >> ShellPkg/Library/UefiShellDebug1CommandsLib/Compress.c | 14 >> ++++++++------ >> ShellPkg/Library/UefiShellDebug1CommandsLib/Compress.h | 1 - >> 3 files changed, 10 insertions(+), 8 deletions(-) >> >> -- >> 2.14.1.3.gb7cf6e02401b >> >> _______________________________________________ >> edk2-devel mailing list >> edk2-devel@lists.01.org >> https://lists.01.org/mailman/listinfo/edk2-devel > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel >