From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id CA0EE7803CD for ; Mon, 8 Jan 2024 16:23:04 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=cBEw0ofkZjpJqDKuDYV3HG3k69Dp6q1QZZpeuSUWjnw=; c=relaxed/simple; d=groups.io; h=Subject:To:From:User-Agent:MIME-Version:Date:References:In-Reply-To:Message-ID:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20140610; t=1704730983; v=1; b=vbf+gAOqp3YAljkoDe+4o1vPxDWPyuL7pGlq2YDXsWRJQqsSAjLfbeE9ylA4658zzB1xQ9lg EzWpJjHc9kDkm3YuN2fZDqZdPXiANn4HP7t4syUFSWI+rxhre7XGH+ddm46q5bW2Nr8bVVsY6pL QNKvjXc+8sq6y51bzMX3wlyA= X-Received: by 127.0.0.2 with SMTP id er1rYY7687511xghMSiStwKs; Mon, 08 Jan 2024 08:23:03 -0800 Subject: Re: [edk2-devel] [PATCH v10 4/5] MdePkg: Utilize Cache Management Operations Implementation For RISC-V To: yorange ,devel@edk2.groups.io From: "Dhaval Sharma" X-Originating-Location: Bengaluru, Karnataka, IN (171.76.80.114) X-Originating-Platform: Linux Chrome 119 User-Agent: GROUPS.IO Web Poster MIME-Version: 1.0 Date: Mon, 08 Jan 2024 08:23:02 -0800 References: <17828.1704727587183697949@groups.io> In-Reply-To: <17828.1704727587183697949@groups.io> Message-ID: <6131.1704730982570913230@groups.io> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,dhaval@rivosinc.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 3iaXEILuoUc5LFR3MXquob2kx7686176AA= Content-Type: multipart/alternative; boundary="wK241io1UfmeHDGKx3Bc" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=vbf+gAOq; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io --wK241io1UfmeHDGKx3Bc Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi yangcheng/Pedro, Thanks for bringing this up. I understand the issue and probably we could j= ust keep it simple with a warning instead of an assert. But wanted to menti= on a couple of points: 1. I think initially even in my patchset it was DEBUG message but there was= a comment to turn it into Assert and I kind of agreed to it thinking that = Assert is also typically ignored in release mode and comes into effect duri= ng debug build. 2. It might be okay to keep it that way because at least in debug mode it b= rings it to a developer's notice that the functionality he/she intends to c= all is not implemented by underlying layer. Whatever we decide, will be applicable to other places in this file as well= . Pedro IMO, it would be better to have simple warnings instead of injectin= g NOPS as it at least notifies the user about actual underlying behavior. -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113406): https://edk2.groups.io/g/devel/message/113406 Mute This Topic: https://groups.io/mt/103150435/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --wK241io1UfmeHDGKx3Bc Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi yangcheng/Pedro,
Thanks for bringing this up. I understand the issu= e and probably we could just keep it simple with a warning instead of an as= sert. But wanted to mention a couple of points:
1. I think initially e= ven in my patchset it was DEBUG message but there was a comment to turn it = into Assert and I kind of agreed to it thinking that Assert is also typical= ly ignored in release mode and comes into effect during debug build.
2= . It might be okay to keep it that way because at least in debug mode it br= ings it to a developer's notice that the functionality he/she intends to ca= ll is not implemented by underlying layer.
Whatever we decide, will be= applicable to other places in this file as well. Pedro IMO, it would be be= tter to have simple warnings instead of injecting NOPS as it at least notif= ies the user about actual underlying behavior.
_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#113406) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--wK241io1UfmeHDGKx3Bc--