From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.85.221.66, mailfrom: philmd@redhat.com) Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by groups.io with SMTP; Tue, 30 Jul 2019 07:07:50 -0700 Received: by mail-wr1-f66.google.com with SMTP id x1so16036414wrr.9 for ; Tue, 30 Jul 2019 07:07:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=n8zSwdzREdYWr3JluKHan+A+bca3NZDAt/5Bx6kIsnw=; b=eBc8DY392dAaXXh2yhAnRk2xlDprNqu46i6LtyKrENfslVBnE3SOtsPtj63n2vRQ9n duy0RbMWH7TNQ0L3mCpEM2l8gACCcObZvxMFC75c2CBOpY8tK8rS1tSEPaAdj861vZnS K6kasOD15SbtCV0+igFGlUsk+5IUNNTNrA83/PfNBQ4cnMWvIba6Omxa2bVVP0m00C2G EFVNBCvI//8cVp7VFHi34jEyWgeEk3VyPdnw8B0DUzlx65RikUvUlQSBA7ickBnse4tc ydKLcoe+/kykwifJEdWNmHiHF6swY/Lnt2FwBGOxTD8Lm0YWO/1hn1ed4swND7urCfkk D6HQ== X-Gm-Message-State: APjAAAWnjFHycnZIeBt5JT0Pd+BQf53l64zCegAqHtaA6y97IR6ijZ3t sHn+LoZpT73REzC/aDYSOCUW4w== X-Google-Smtp-Source: APXvYqxNTI+jh330rvdUgYs6eRYBz6p4dYZnUQDq4OwHr8MLeFGjBlFk/n9ijPbI4S94cPuN4WKcfg== X-Received: by 2002:adf:e2c1:: with SMTP id d1mr133940463wrj.283.1564495668436; Tue, 30 Jul 2019 07:07:48 -0700 (PDT) Return-Path: Received: from [192.168.1.38] (190.red-81-40-121.staticip.rima-tde.net. [81.40.121.190]) by smtp.gmail.com with ESMTPSA id b203sm79338058wmd.41.2019.07.30.07.07.47 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Tue, 30 Jul 2019 07:07:47 -0700 (PDT) Subject: Re: [edk2-devel] [PATCH 0/2] ArmPkg: DebugPeCoffExtraActionLib: debugger commands are not errors To: devel@edk2.groups.io, leif.lindholm@linaro.org Cc: Laszlo Ersek , Ard Biesheuvel References: <20190729180321.1715-1-philmd@redhat.com> <20190730140110.GH22656@bivouac.eciton.net> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Openpgp: id=89C1E78F601EE86C867495CBA2A3FD6EDEADC0DE; url=http://pgp.mit.edu/pks/lookup?op=get&search=0xA2A3FD6EDEADC0DE Message-ID: <613626ea-1cad-9366-81bb-b4e067c4b6e4@redhat.com> Date: Tue, 30 Jul 2019 16:07:47 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20190730140110.GH22656@bivouac.eciton.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 7/30/19 4:01 PM, Leif Lindholm wrote: > On Mon, Jul 29, 2019 at 08:03:19PM +0200, Philippe Mathieu-Daude wrote: >> Hi, >> >> This series completes the cleanup from commit 1fce963d89f3 ("ArmPkg: >> DebugPeCoffExtraActionLib: debugger commands are not errors", from >> 2015-03-02), on PeCoffLoaderUnloadImageExtraAction(). >> >> This solves an issue when building in silent mode with >> -D DEBUG_PRINT_ERROR_LEVEL=0x80000000. With the QemuRamFbDxe platform >> DXE driver, when we get a driver dispatch failure it is reported as >> an error level: >> >> qemu-system-aarch64 -machine virt,gic-version=3,accel=kvm -cpu host \ >> -display none -serial stdio -bios /usr/share/AAVMF/AAVMF_CODE.fd >> remove-symbol-file /builddir/build/BUILD/edk2-89910a39dcfd/Build/ArmVirtQemu-AARCH64/DEBUG_GCC5/AARCH64/OvmfPkg/QemuRamfbDxe/QemuRamfbDxe/DEBUG/QemuRamfbDxe.dll 0x3F5F6000 >> >> The second patch is an obvious typo fix. > > I added the word "comment" in subject/message of 2/2, to make > it explicit that the typo does not affect functionality. Good idea, thanks. > > Reviewed-by: Leif Lindholm > Pushed as 8fed4e47d9a6..3d34b5f32692. Thanks Laszlo and Leif! > > Thanks! > >> Regards, >> >> Phil. >> >> Philippe Mathieu-Daudé (2): >> ArmPkg: DebugPeCoffExtraActionLib: debugger commands are not errors >> ArmPkg: DebugPeCoffExtraActionLib: fix trivial typos >> >> .../DebugPeCoffExtraActionLib.c | 12 ++++++------ >> 1 file changed, 6 insertions(+), 6 deletions(-) >> >> -- >> 2.20.1 >> > > >