From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from userp2130.oracle.com (userp2130.oracle.com [156.151.31.86]) by mx.groups.io with SMTP id smtpd.web11.4264.1587811497845450547 for ; Sat, 25 Apr 2020 03:44:58 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=hMTw1DTe; spf=pass (domain: oracle.com, ip: 156.151.31.86, mailfrom: nikita.leshchenko@oracle.com) Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 03PAgplX171999; Sat, 25 Apr 2020 10:44:53 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=content-type : mime-version : subject : from : in-reply-to : date : cc : content-transfer-encoding : message-id : references : to; s=corp-2020-01-29; bh=3+HCZsot/BHYe18OJUk7Pxvyanga5j7gp0NEGkn42yg=; b=hMTw1DTehAFEt8bZex+42ivN/UzezZaZCQ6eLIRoIe79UxWp0zbHurcCJhHA7YJtlpZl 3Qm6Nt2AsN/5DyMcWckcVcly0VJrslsUSNuQCKjgfyhxjbZGm4MjjlCXN1KBGmebFGOn YZrpqRV7xlRh5lvbhEgasMoC+6OyQZoDJjOyFLDm6obh0OdYQT9tWRZJcE3RjiOEDLml rdFzKoggTJBWnkvBYSQqio89pF9B9SPs17DIyEAqhFqkopkHMgu6Qt9FkqWY13CNLevr JqccCC2vO4ioRu+SunBb9qWZZpk6I63EGmZ1p3YMUiNGkvypPy/F21ZzhpdSh13BKb5K Pw== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by userp2130.oracle.com with ESMTP id 30mcmqrrmm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 25 Apr 2020 10:44:52 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 03PAffv2089993; Sat, 25 Apr 2020 10:44:52 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userp3020.oracle.com with ESMTP id 30mchh84ac-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 25 Apr 2020 10:44:52 +0000 Received: from abhmp0011.oracle.com (abhmp0011.oracle.com [141.146.116.17]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 03PAiodQ005935; Sat, 25 Apr 2020 10:44:50 GMT Received: from wintermute.home (/213.57.201.13) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sat, 25 Apr 2020 03:44:50 -0700 Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\)) Subject: Re: [edk2-devel] [PATCH v5 03/12] OvmfPkg/MptScsiDxe: Report name of driver From: "Nikita Leshenko" In-Reply-To: Date: Sat, 25 Apr 2020 13:44:46 +0300 Cc: "liran.alon@oracle.com" , "aaron.young@oracle.com" , "Justen, Jordan L" , Laszlo Ersek , Ard Biesheuvel Message-Id: <616BEA2B-FB3A-40F5-9A0F-24283FD5F658@oracle.com> References: <20200424175927.41210-1-nikita.leshchenko@oracle.com> <20200424175927.41210-4-nikita.leshchenko@oracle.com> To: devel@edk2.groups.io, jaben.carsey@intel.com X-Mailer: Apple Mail (2.3445.9.1) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9601 signatures=668686 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 bulkscore=0 phishscore=0 adultscore=0 mlxscore=0 suspectscore=0 malwarescore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2004250093 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9601 signatures=668686 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 spamscore=0 clxscore=1015 priorityscore=1501 suspectscore=0 impostorscore=0 adultscore=0 malwarescore=0 bulkscore=0 lowpriorityscore=0 mlxlogscore=999 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2004250093 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable > On 24 Apr 2020, at 21:02, Carsey, Jaben = wrote: >=20 > I don't remember reviewing this previously (not recently at least), = maybe the RB should be CC? The version that you reviewed was submitted more than a year ago, indeed a long time ago: https://edk2.groups.io/g/devel/message/36232 >=20 > One comment inline below. >=20 >> -----Original Message----- >> From: devel@edk2.groups.io On Behalf Of Nikita >> Leshenko >> Sent: Friday, April 24, 2020 10:59 AM >> To: devel@edk2.groups.io >> Cc: Nikita Leshenko ; >> liran.alon@oracle.com; aaron.young@oracle.com; Justen, Jordan L >> ; Laszlo Ersek ; Ard >> Biesheuvel ; Carsey, Jaben >> >> Subject: [edk2-devel] [PATCH v5 03/12] OvmfPkg/MptScsiDxe: Report = name >> of driver >>=20 >> [...] >> +EFI_STATUS >> +EFIAPI >> +MptScsiGetDeviceName ( >> + IN EFI_COMPONENT_NAME_PROTOCOL *This, >> + IN EFI_HANDLE DeviceHandle, >> + IN EFI_HANDLE ChildHandle, >> + IN CHAR8 *Language, >> + OUT CHAR16 **ControllerName >> + ) >> +{ >> + return EFI_UNSUPPORTED; >> +} >> + >> +STATIC >> +EFI_COMPONENT_NAME_PROTOCOL mComponentName =3D { >> + &MptScsiGetDriverName, >> + &MptScsiGetDeviceName, >> + "eng" // SupportedLanguages, ISO 639-2 language codes }; >> + >> +STATIC >> +EFI_COMPONENT_NAME2_PROTOCOL mComponentName2 =3D { >> + (EFI_COMPONENT_NAME2_GET_DRIVER_NAME) >> &MptScsiGetDriverName, >> + (EFI_COMPONENT_NAME2_GET_CONTROLLER_NAME) >> &MptScsiGetDeviceName, >> + "en" // SupportedLanguages, RFC 4646 language codes }; >=20 > I think that the }; needs to be outside of the comment for both of = these structures. I don't know why your copy of the mail doesn't have a newline, but that = wasn't my intention. (And my copy of the mail seems to have it, strange...) The patch looks like intended on the mailing list archive and of Github: Here is this patch on the mailing list archive: https://www.mail-archive.com/devel@edk2.groups.io/msg18861.html And here is this patch on Github: = https://github.com/nikital/edk2/commit/41855cc48125321fce3323473379edcf098= c3c01 Thanks, Nikita